<!-- 
RSS generated by JIRA (9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b) at Mon Feb 12 02:01:51 CET 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Magnolia - Issue tracker</title>
    <link>https://jira.magnolia-cms.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-uk</language>    <build-info>
        <version>9.4.2</version>
        <build-number>940002</build-number>
        <build-date>19-01-2023</build-date>
    </build-info>


<item>
            <title>[MGNLFORUM-220] fix DefaultForumManagerTest</title>
                <link>https://jira.magnolia-cms.com/browse/MGNLFORUM-220</link>
                <project id="10130" key="MGNLFORUM">Forum (closed)</project>
                    <description>&lt;p&gt;fix DefaultForumManagerTest#testCreatingForumShouldUseUniqueCleanUpNameAndAddTitleProperty &lt;br/&gt;
and #testCreatingForumShouldCleanUpNameAddTitlePropertyAndCreateAdhocRoles.&lt;br/&gt;
These 2 methods fail with Unexpected method call getWorkspace(); see stackTrace&lt;/p&gt;

&lt;p&gt;java.lang.AssertionError: &lt;br/&gt;
  Unexpected method call getWorkspace():&lt;br/&gt;
    isExist(&quot;/mon-forum&quot;): expected: 1, actual: 0&lt;br/&gt;
    getRoot(): expected: 1, actual: 0&lt;br/&gt;
	at org.easymock.internal.MockInvocationHandler.invoke(MockInvocationHandler.java:32)&lt;br/&gt;
	at org.easymock.internal.ObjectMethodsFilter.invoke(ObjectMethodsFilter.java:61)&lt;br/&gt;
	at com.sun.proxy.$Proxy5.getWorkspace(Unknown Source)&lt;br/&gt;
	at info.magnolia.cms.core.Path.getUniqueLabel(Path.java:148)&lt;br/&gt;
	at info.magnolia.module.forum.DefaultForumManager.createForum(DefaultForumManager.java:133)&lt;br/&gt;
	at info.magnolia.module.forum.DefaultForumManager.createForum(DefaultForumManager.java:126)&lt;br/&gt;
	at info.magnolia.module.forum.DefaultForumManagerTest.testCreatingForumShouldCleanUpNameAddTitlePropertyAndCreateAdhocRoles(DefaultForumManagerTest.java:194)&lt;br/&gt;
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)&lt;br/&gt;
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)&lt;br/&gt;
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)&lt;br/&gt;
	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:81)&lt;br/&gt;
	at org.junit.runner.JUnitCore.run(JUnitCore.java:130)&lt;br/&gt;
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:77)&lt;br/&gt;
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:195)&lt;br/&gt;
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:63)&lt;br/&gt;
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)&lt;br/&gt;
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)&lt;br/&gt;
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:120)&lt;/p&gt;

&lt;p&gt;java.lang.AssertionError: &lt;br/&gt;
  Unexpected method call getWorkspace():&lt;br/&gt;
    isExist(&quot;/mon-forum&quot;): expected: 1, actual: 0&lt;br/&gt;
    isExist(&quot;/mon-forum0&quot;): expected: 1, actual: 0&lt;br/&gt;
    getRoot(): expected: 1, actual: 0&lt;br/&gt;
	at org.easymock.internal.MockInvocationHandler.invoke(MockInvocationHandler.java:32)&lt;br/&gt;
	at org.easymock.internal.ObjectMethodsFilter.invoke(ObjectMethodsFilter.java:61)&lt;br/&gt;
	at com.sun.proxy.$Proxy2.getWorkspace(Unknown Source)&lt;br/&gt;
	at info.magnolia.cms.core.Path.getUniqueLabel(Path.java:148)&lt;br/&gt;
	at info.magnolia.module.forum.DefaultForumManager.createForum(DefaultForumManager.java:133)&lt;br/&gt;
	at info.magnolia.module.forum.DefaultForumManager.createForum(DefaultForumManager.java:126)&lt;br/&gt;
	at info.magnolia.module.forum.DefaultForumManagerTest.testCreatingForumShouldUseUniqueCleanUpNameAndAddTitleProperty(DefaultForumManagerTest.java:137)&lt;br/&gt;
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)&lt;br/&gt;
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)&lt;br/&gt;
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)&lt;br/&gt;
	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:81)&lt;br/&gt;
	at org.junit.runner.JUnitCore.run(JUnitCore.java:130)&lt;br/&gt;
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:77)&lt;br/&gt;
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:195)&lt;br/&gt;
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:63)&lt;br/&gt;
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)&lt;br/&gt;
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)&lt;br/&gt;
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:120)&lt;/p&gt;</description>
                <environment></environment>
        <key id="35924">MGNLFORUM-220</key>
            <summary>fix DefaultForumManagerTest</summary>
                <type id="1" iconUrl="https://jira.magnolia-cms.com/secure/viewavatar?size=xsmall&amp;avatarId=10883&amp;avatarType=issuetype">Bug</type>
                                            <priority id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/priorities/neutral.gif">Neutral</priority>
                        <status id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="cmeier">Christoph Meier</assignee>
                                    <reporter username="cmeier">Christoph Meier</reporter>
                        <labels>
                    </labels>
                <created>Wed, 15 Jan 2014 19:56:35 +0100</created>
                <updated>Wed, 19 Feb 2014 13:23:47 +0100</updated>
                            <resolved>Mon, 17 Feb 2014 14:56:31 +0100</resolved>
                                                    <fixVersion>3.3</fixVersion>
                                    <component>persistence</component>
                    <component>security</component>
                        <due></due>
                            <votes>0</votes>
                                    <watches>3</watches>
                                                                                                                <comments>
                            <comment id="78492" author="cmeier" created="Thu, 23 Jan 2014 14:35:51 +0100"  >&lt;p&gt;As long as this forum depends on magnolia-core 5.2, but not higher, the test works fine.&lt;/p&gt;</comment>
                            <comment id="79216" author="cmeier" created="Wed, 5 Feb 2014 17:34:52 +0100"  >&lt;p&gt;since we want to have dependecy to 5.2.2, this must be &quot;fixed&quot;, therefore reopenend.&lt;/p&gt;</comment>
                            <comment id="79642" author="had" created="Thu, 13 Feb 2014 14:04:14 +0100"  >&lt;p&gt;While the use of deprecated API in the test might be forced by code under the test that was not updated yet, there is no reason for not replacing EasyMock with Mockito for the tests that are being modified.&lt;/p&gt;</comment>
                            <comment id="79780" author="cmeier" created="Mon, 17 Feb 2014 12:52:39 +0100"  >&lt;p&gt;Changing from Easymock- to Mockito-Framework was not completely trivial;  many of the test would must have been changed significant.&lt;br/&gt;
Hence i decided to rewrite the test-class using a RepositoryTestCase which made it easier and allowed much more meaningful &#8222;black box testing&#8220;; at the same time could get rid of usage of &#8222;old content-API&#8220;.&lt;/p&gt;

</comment>
                            <comment id="79787" author="dlipp" created="Mon, 17 Feb 2014 13:51:09 +0100"  >&lt;p&gt;DefaultForumManagerTest&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;remove unused logger, accessManager + mgnlContext&lt;/li&gt;
	&lt;li&gt;use our import conventions&lt;/li&gt;
	&lt;li&gt;static imports before non-static ones&lt;/li&gt;
	&lt;li&gt;use .* for more than one static import to the same package&lt;br/&gt;
    -&amp;gt; import static org.junit.Assert.*;&lt;br/&gt;
       import static org.mockito.Mockito.*;&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;AbstractForumRepositoryTestCase&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;should not catch + log RepositoryException but leave it untreated (declared with throws Exception)&lt;br/&gt;
  -&amp;gt; that would guarantee that the test fails right in setup in case of probs with repo&lt;br/&gt;
  -&amp;gt; remove logger that&apos;s then no longer used&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;(btw: unless there&apos;s more subclasses of AbstractForumRepositoryTestCase coming soon, I&apos;d merge that code into DefaultForumManagerTest&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10040">
                    <name>causality</name>
                                            <outwardlinks description="caused by">
                                        <issuelink>
            <issuekey id="36394">MGNLFORUM-230</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_14166" key="com.okapya.jira.checklist:checklist">
                        <customfieldname>Acceptance criteria</customfieldname>
                        <customfieldvalues>
                            
        <checklist>
        <![CDATA[
                            




                
                                    <div class="o-completion" style="display: flex; flex-shrink: 0;"><span  class="aui-lozenge aui-lozenge-complete" style="font-size: 12px; font-weight: normal; display: flex; flex-direction: row; align-items: center;" ><span style="padding-right: 4px; vertical-align: middle;"><svg width="15" height="15" viewBox="0 0 15 15" xmlns="http://www.w3.org/2000/svg" fill="white"><path clip-rule="evenodd" d="m10.41037,3.42544l-7.86501,0c-0.72395,0 -1.31084,0.58688 -1.31084,1.31084l0,7.86508c0,0.7239 0.58689,1.3108 1.31084,1.3108l7.86501,0c0.724,0 1.3109,-0.5869 1.3109,-1.3108l0,-7.86508c0,-0.72396 -0.5869,-1.31084 -1.3109,-1.31084zm-7.86501,-0.65542c-1.08593,0 -1.96626,0.88032 -1.96626,1.96626l0,7.86508c0,1.0859 0.88033,1.9662 1.96626,1.9662l7.86501,0c1.086,0 1.9663,-0.8803 1.9663,-1.9662l0,-7.86508c0,-1.08594 -0.8803,-1.96626 -1.9663,-1.96626l-7.86501,0z" fill-rule="evenodd"/><path d="m5.09049,10.18526l-1.82767,-1.82766l-0.78479,0.78479l2.61246,2.61246l5.38758,-5.38754l-0.78483,-0.78479l-4.60275,4.60274z"/></svg></span><span>Empty</span></span></div>
                        ]]>
    </checklist>


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10111" key="com.atlassian.jira.toolkit:reporterdomain">
                        <customfieldname>Company</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>magnolia-cms.com</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10031" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Thu, 13 Feb 2014 14:04:14 +0100</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_12730" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_14151" key="com.atlassian.jira.toolkit:message">
                        <customfieldname>Docu info</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10061" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comm is not jira-dev</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10071" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last participant</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>mmuehlebach</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_13136" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            10 years, 6 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10020" key="com.atlassian.jira.toolkit:attachments">
                        <customfieldname>Number of attachments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10150" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname>Number of comments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>5.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>cmeier</customfieldvalue>
            <customfieldvalue>dlipp</customfieldvalue>
            <customfieldvalue>had</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10833" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i030dr:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10244" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>17643</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_14145" key="com.intenso.jira.issue-templates:issue-templates-customfield">
                        <customfieldname>Template</customfieldname>
                        <customfieldvalues>
                            


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_15131" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Time in Discovery</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>