<!-- 
RSS generated by JIRA (9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b) at Mon Feb 12 10:16:14 CET 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Magnolia - Issue tracker</title>
    <link>https://jira.magnolia-cms.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-uk</language>    <build-info>
        <version>9.4.2</version>
        <build-number>940002</build-number>
        <build-date>19-01-2023</build-date>
    </build-info>


<item>
            <title>[MGNLMIGRATION-1] Check if a node exist before operating on it</title>
                <link>https://jira.magnolia-cms.com/browse/MGNLMIGRATION-1</link>
                <project id="10574" key="MGNLMIGRATION">Migration 4.4 to 4.5 (closed)</project>
                    <description>&lt;p&gt;When migrating other modules than the ones from the default migration, it often happen that an &quot;PathNotFound&quot; error occurs. &lt;/p&gt;</description>
                <environment></environment>
        <key id="23348">MGNLMIGRATION-1</key>
            <summary>Check if a node exist before operating on it</summary>
                <type id="1" iconUrl="https://jira.magnolia-cms.com/secure/viewavatar?size=xsmall&amp;avatarId=10883&amp;avatarType=issuetype">Bug</type>
                                            <priority id="2" iconUrl="https://jira.magnolia-cms.com/images/icons/priorities/critical.svg">Critical</priority>
                        <status id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="sschmitt">Samuel Schmitt</assignee>
                                    <reporter username="sschmitt">Samuel Schmitt</reporter>
                        <labels>
                    </labels>
                <created>Wed, 7 Mar 2012 13:20:23 +0100</created>
                <updated>Wed, 25 Jul 2012 09:27:42 +0200</updated>
                            <resolved>Wed, 7 Mar 2012 13:25:31 +0100</resolved>
                                                    <fixVersion>1.0.1</fixVersion>
                                        <due></due>
                            <votes>0</votes>
                                    <watches>1</watches>
                                                                                                                <comments>
                            <comment id="45141" author="mderting" created="Thu, 8 Mar 2012 15:35:29 +0100"  >&lt;p&gt;Hi Samuel,&lt;/p&gt;

&lt;p&gt;I saw you made some fixes regarding this issue.  I ran into similar problems in some of the other migration scripts.  See the attached patches.&lt;/p&gt;

&lt;p&gt;btw, there&apos;s one more on the way.&lt;/p&gt;

&lt;p&gt;Let me know what you think, or if you have any questions.&lt;/p&gt;

&lt;p&gt;Cheers,&lt;br/&gt;
Matt&lt;/p&gt;</comment>
                            <comment id="45142" author="mderting" created="Thu, 8 Mar 2012 15:37:34 +0100"  >&lt;p&gt;Hi Samuel,&lt;/p&gt;

&lt;p&gt;Ok, all four patch files are attached.&lt;/p&gt;

&lt;p&gt;Cheers,&lt;br/&gt;
Matt&lt;/p&gt;</comment>
                            <comment id="45147" author="sschmitt" created="Thu, 8 Mar 2012 16:12:20 +0100"  >&lt;p&gt;Thanks for the patches, I will update everything !!&lt;/p&gt;</comment>
                            <comment id="45276" author="mderting" created="Fri, 9 Mar 2012 20:03:34 +0100"  >&lt;p&gt;Hi Samuel,&lt;/p&gt;

&lt;p&gt;Found other occurrence in ExtraSTKTasks.groovy, see attached patch.&lt;/p&gt;

&lt;p&gt;Also, there are two other scripts that I have questions about.&lt;/p&gt;

&lt;p&gt;The first one is: &lt;tt&gt;TransformExtends.groovy&lt;/tt&gt;, within the &lt;tt&gt;prepareAndCreateSTKComparisonMap&lt;/tt&gt; method there is the following:&lt;/p&gt;

&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;def genericNode = hm.getContent(modulePath+&lt;span class=&quot;code-quote&quot;&gt;&quot;dialogs/&lt;span class=&quot;code-keyword&quot;&gt;generic&lt;/span&gt;&quot;&lt;/span&gt;)
def masterNode = genericNode.createContent(&lt;span class=&quot;code-quote&quot;&gt;&quot;master&quot;&lt;/span&gt;)
def changeTeaserMap = [&lt;span class=&quot;code-quote&quot;&gt;&quot;/tabLinkList&quot;&lt;/span&gt; : &quot;&quot;]
genericNode.save()
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;My question is, do you think this could be revised to handle cases where the migration scripts fail during the update process? Currently, if this happens you can end up with duplicate &lt;tt&gt;master&lt;/tt&gt; nodes.  I was thinking maybe the above code could be changed to the following instead?&lt;/p&gt;

&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;def genericNode = hm.getContent(modulePath+&lt;span class=&quot;code-quote&quot;&gt;&quot;dialogs/&lt;span class=&quot;code-keyword&quot;&gt;generic&lt;/span&gt;&quot;&lt;/span&gt;)
def masterNode = genericNode.getOrCreateContent(&lt;span class=&quot;code-quote&quot;&gt;&quot;master&quot;&lt;/span&gt;)
def changeTeaserMap = [&lt;span class=&quot;code-quote&quot;&gt;&quot;/tabLinkList&quot;&lt;/span&gt; : &quot;&quot;]
genericNode.save()
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;The second script I have a question about is: &lt;tt&gt;TransformSTKTemplates.groovy&lt;/tt&gt;, within the &lt;tt&gt;migrateTemplateDefinition&lt;/tt&gt; method, there is the following:&lt;/p&gt;

&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;createContentNavigationArea(template)
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;Similar to my first question, calling this method here doesn&apos;t first check to see if the &lt;tt&gt;contentNavigation&lt;/tt&gt; node already exists. Therefore, it&apos;s possible to end up with duplicate &lt;tt&gt;contentNavigation&lt;/tt&gt; nodes.&lt;/p&gt;

&lt;p&gt;Let me know your thoughts.&lt;/p&gt;


&lt;p&gt;Cheers,&lt;br/&gt;
Matt&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10020">
                    <name>dependency</name>
                                                                <inwardlinks description="is depended upon by">
                                        <issuelink>
            <issuekey id="23227">MGNLMIGRATION-24</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                            <attachment id="15879" name="BuildDialogIdMap.groovy.patch" size="741" author="mderting" created="Thu, 8 Mar 2012 15:35:29 +0100"/>
                            <attachment id="15891" name="ExtraSTKTasks.groovy.patch" size="827" author="mderting" created="Fri, 9 Mar 2012 20:03:34 +0100"/>
                            <attachment id="15880" name="Migration.groovy.patch" size="1641" author="mderting" created="Thu, 8 Mar 2012 15:35:29 +0100"/>
                            <attachment id="15881" name="MigrationUtil.groovy.patch" size="1074" author="mderting" created="Thu, 8 Mar 2012 15:35:29 +0100"/>
                            <attachment id="15882" name="RemoveTemplateToPrototypeRedundancy.groovy.patch" size="1192" author="mderting" created="Thu, 8 Mar 2012 15:36:07 +0100"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_14166" key="com.okapya.jira.checklist:checklist">
                        <customfieldname>Acceptance criteria</customfieldname>
                        <customfieldvalues>
                            
        <checklist>
        <![CDATA[
                            




                
                                    <div class="o-completion" style="display: flex; flex-shrink: 0;"><span  class="aui-lozenge aui-lozenge-complete" style="font-size: 12px; font-weight: normal; display: flex; flex-direction: row; align-items: center;" ><span style="padding-right: 4px; vertical-align: middle;"><svg width="15" height="15" viewBox="0 0 15 15" xmlns="http://www.w3.org/2000/svg" fill="white"><path clip-rule="evenodd" d="m10.41037,3.42544l-7.86501,0c-0.72395,0 -1.31084,0.58688 -1.31084,1.31084l0,7.86508c0,0.7239 0.58689,1.3108 1.31084,1.3108l7.86501,0c0.724,0 1.3109,-0.5869 1.3109,-1.3108l0,-7.86508c0,-0.72396 -0.5869,-1.31084 -1.3109,-1.31084zm-7.86501,-0.65542c-1.08593,0 -1.96626,0.88032 -1.96626,1.96626l0,7.86508c0,1.0859 0.88033,1.9662 1.96626,1.9662l7.86501,0c1.086,0 1.9663,-0.8803 1.9663,-1.9662l0,-7.86508c0,-1.08594 -0.8803,-1.96626 -1.9663,-1.96626l-7.86501,0z" fill-rule="evenodd"/><path d="m5.09049,10.18526l-1.82767,-1.82766l-0.78479,0.78479l2.61246,2.61246l5.38758,-5.38754l-0.78483,-0.78479l-4.60275,4.60274z"/></svg></span><span>Empty</span></span></div>
                        ]]>
    </checklist>


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10111" key="com.atlassian.jira.toolkit:reporterdomain">
                        <customfieldname>Company</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>magnolia-cms.com</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10031" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Thu, 8 Mar 2012 15:35:29 +0100</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_12730" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_14151" key="com.atlassian.jira.toolkit:message">
                        <customfieldname>Docu info</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10061" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comm is not jira-dev</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10071" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last participant</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>mmuehlebach</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_13136" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            11 years, 50 weeks, 2 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10020" key="com.atlassian.jira.toolkit:attachments">
                        <customfieldname>Number of attachments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>5.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10150" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname>Number of comments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>4.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>mderting</customfieldvalue>
            <customfieldvalue>sschmitt</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10833" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i03ujz:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10244" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>22560</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_14145" key="com.intenso.jira.issue-templates:issue-templates-customfield">
                        <customfieldname>Template</customfieldname>
                        <customfieldvalues>
                            


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_15131" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Time in Discovery</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>