<!-- 
RSS generated by JIRA (9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b) at Mon Feb 12 10:17:17 CET 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Magnolia - Issue tracker</title>
    <link>https://jira.magnolia-cms.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-uk</language>    <build-info>
        <version>9.4.2</version>
        <build-number>940002</build-number>
        <build-date>19-01-2023</build-date>
    </build-info>


<item>
            <title>[MGNLMIGRATION-113] Migrate TemplateScripts Task: Move Groovy Class into Java Class</title>
                <link>https://jira.magnolia-cms.com/browse/MGNLMIGRATION-113</link>
                <project id="10574" key="MGNLMIGRATION">Migration 4.4 to 4.5 (closed)</project>
                    <description>&lt;p&gt;Groovy class: &lt;br/&gt;
  TemplateScript and MigrateTemplateScripts should be moved into Java service.&lt;/p&gt;</description>
                <environment></environment>
        <key id="25878">MGNLMIGRATION-113</key>
            <summary>Migrate TemplateScripts Task: Move Groovy Class into Java Class</summary>
                <type id="5" iconUrl="https://jira.magnolia-cms.com/secure/viewavatar?size=xsmall&amp;avatarId=10896&amp;avatarType=issuetype">Sub-task</type>
                            <parent id="25877">MGNLMIGRATION-112</parent>
                                    <priority id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/priorities/neutral.gif">Neutral</priority>
                        <status id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="rsiska">Robert &#352;i&#353;ka</assignee>
                                    <reporter username="ehechinger">Eric Hechinger</reporter>
                        <labels>
                    </labels>
                <created>Fri, 12 Oct 2012 09:31:47 +0200</created>
                <updated>Fri, 7 Dec 2012 14:09:44 +0100</updated>
                            <resolved>Fri, 7 Dec 2012 13:23:42 +0100</resolved>
                                    <version>1.1.3</version>
                                    <fixVersion>1.2</fixVersion>
                                        <due></due>
                            <votes>0</votes>
                                    <watches>0</watches>
                                                                                                                <comments>
                            <comment id="52984" author="cdesales" created="Tue, 6 Nov 2012 14:34:41 +0100"  >&lt;p&gt;Both Files have already been translated from Groovy to Java.&lt;/p&gt;

&lt;p&gt;TemplateScript =&amp;gt; TemplateScriptParser&lt;br/&gt;
MigrateTemplateScripts =&amp;gt; TemplateScriptMigrationTask&lt;/p&gt;

&lt;p&gt;Please elaborate on the description of the issue if additional details need to be considered or implemented.&lt;/p&gt;</comment>
                            <comment id="52995" author="cdesales" created="Tue, 6 Nov 2012 15:53:53 +0100"  >&lt;p&gt;Except for the problem described in &lt;a href=&quot;https://jira.magnolia-cms.com/browse/MGNLMIGRATION-159&quot; title=&quot;Templates in the Magnolia site definition are not migrated&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MGNLMIGRATION-159&quot;&gt;&lt;del&gt;MGNLMIGRATION-159&lt;/del&gt;&lt;/a&gt; all FTL scripts are processed.&lt;/p&gt;</comment>
                            <comment id="54175" author="had" created="Sun, 2 Dec 2012 22:13:11 +0100"  >&lt;p&gt;MigrateTemplateExecuteScripts.groovy&lt;/p&gt;
&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;  16       modulesMap = [&quot;standard-templating-kit&quot;, &quot;/Users/erichechinger/Dev/Temp/templates/templating-kit&quot;]
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;That doesn&apos;t seem right, does it?&lt;/p&gt;

&lt;p&gt;JspTemplate&lt;/p&gt;
&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt; 788 
 789                     // TODO: attributes.get(&quot;items&quot;)
 790 
1132             if (!path.isEmpty()) {
1133                 //FIXME: ctx variable is not exposed?!
1204                 //FIXME: relative link
1205             }
1206             
1207             //TODO escapeXml, lineBreak, dateLanguage, scope

&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;Pls no more todo&apos;s or fixme&apos;s - create tickets for those things if you can&apos;t do them directly.&lt;/p&gt;

&lt;p&gt;FreemarkerTemplate:&lt;/p&gt;
&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt; 468             if (t.data.equals(&quot;@cmsu.table&quot;)) {
 469                 //do tables manually, lazy
 470                 // TODO
 471             }
 472     
 473             if (t.data.equals(&quot;@cmsu.xmp&quot;)) {
 474                 // TODO
 475             }


 864 
 865                     // TODO: attributes.get(&quot;items&quot;)
 866 
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;The least you should do is spit out a warning about those not being migrated.&lt;/p&gt;

&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt; 933                     if (!newBarExists) {
 934                         //if (!areaTag.isArea) {
 935                         markAsArea(this.root, areaName, t, t);
 936                         t.addAfter(areaTag);
 937                         //}
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;IF the code is worng them remove it, don&apos;t leave it in commented out.&lt;/p&gt;

&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;1280                 //FIXME: relative link
1281             }
1282 
1283             if (attributes.containsKey(&quot;defaultValue&quot;)) {
1284                 defaultValue = &quot;!&quot; + wrapNull(attributes.get(&quot;defaultValue&quot;));
1285             } else {
1286                 defaultValue = &quot;!&quot;;
1287             }
1288 
1289             //TODO escapeXml, lineBreak, dateLanguage, scope
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;... more todo&apos;s and fixme&apos;s&lt;/p&gt;

&lt;p&gt;JSPTemplate&lt;/p&gt;
&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt; 197                     // todo?
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;dunno, you tell me?&lt;/p&gt;

&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt; 395             if (t.data.equals(&quot;cmsu:table&quot;)) {
 396                 //do tables manually, lazy
 397                 // TODO
 398             }
 399 
 400             if (t.data.equals(&quot;cmsu:xmp&quot;)) {
 401                 // TODO
 402             }
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;same as above - at the very least print warning.&lt;/p&gt;

&lt;p&gt;TemplateScriptParser&lt;/p&gt;
&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;  95         if (!file.exists()) {
  96             // l.logM(&quot;Template script not found! &quot; + absolutePath, 1)  TODO MGNLMIGRATION-75:
  97             return;

&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;if you are not going to print this message then remove the code ... btw &lt;a href=&quot;https://jira.magnolia-cms.com/browse/MGNLMIGRATION-75&quot; title=&quot;Main Reporting Task: Use Reporting service to log information in the Migration Tasks&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MGNLMIGRATION-75&quot;&gt;&lt;del&gt;MGNLMIGRATION-75&lt;/del&gt;&lt;/a&gt; is resolved, but this file is not modified under that ticket.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10111" key="com.atlassian.jira.toolkit:reporterdomain">
                        <customfieldname>Company</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>magnolia-cms.com</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10031" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Tue, 6 Nov 2012 14:34:41 +0100</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_12730" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_14151" key="com.atlassian.jira.toolkit:message">
                        <customfieldname>Docu info</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10061" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comm is not jira-dev</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>false</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10071" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last participant</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>ajones</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_13136" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            11 years, 12 weeks ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10020" key="com.atlassian.jira.toolkit:attachments">
                        <customfieldname>Number of attachments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10150" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname>Number of comments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>3.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>cdesales</customfieldvalue>
            <customfieldvalue>ehechinger</customfieldvalue>
            <customfieldvalue>had</customfieldvalue>
            <customfieldvalue>rsiska</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10833" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i04dgn:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10244" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>25625</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_14145" key="com.intenso.jira.issue-templates:issue-templates-customfield">
                        <customfieldname>Template</customfieldname>
                        <customfieldvalues>
                            


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_15131" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Time in Discovery</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            </customfields>
    </item>
</channel>
</rss>