<!-- 
RSS generated by JIRA (9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b) at Mon Feb 12 10:19:59 CET 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Magnolia - Issue tracker</title>
    <link>https://jira.magnolia-cms.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-uk</language>    <build-info>
        <version>9.4.2</version>
        <build-number>940002</build-number>
        <build-date>19-01-2023</build-date>
    </build-info>


<item>
            <title>[MGNLMODSTR-5] Cannot go to admincentral from domain root or rendered page on author</title>
                <link>https://jira.magnolia-cms.com/browse/MGNLMODSTR-5</link>
                <project id="10260" key="MGNLMODSTR">Modifystream (closed)</project>
                    <description>&lt;p&gt;Doing domain mapping is a productivity boost and a time-saver for the team. However since 5.0 we return a page in preview fashion if editor access the site via a domain mapped to it, disallowing her to edit any content right away or switch to AdminCentral with one click. &lt;/p&gt;

&lt;p&gt;To reproduce:&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;map a domain to site&lt;/li&gt;
	&lt;li&gt;request the site via its domain&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;4.5 behavior was to directly display the page too, but being logged in meant for the user to be in edit-mode.&lt;/p&gt;

&lt;p&gt;The new page editor is bound to the page app, thus cannot run &quot;standalone&quot;.&lt;/p&gt;</description>
                <environment></environment>
        <key id="34642">MGNLMODSTR-5</key>
            <summary>Cannot go to admincentral from domain root or rendered page on author</summary>
                <type id="1" iconUrl="https://jira.magnolia-cms.com/secure/viewavatar?size=xsmall&amp;avatarId=10883&amp;avatarType=issuetype">Bug</type>
                                            <priority id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/priorities/neutral.gif">Neutral</priority>
                        <status id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="mdivilek">Milan Divilek</assignee>
                                    <reporter username="zdenekskodik">Zdenek Skodik</reporter>
                        <labels>
                            <label>support</label>
                    </labels>
                <created>Tue, 19 Nov 2013 14:11:53 +0100</created>
                <updated>Wed, 9 Sep 2015 09:45:43 +0200</updated>
                            <resolved>Fri, 19 Sep 2014 23:08:39 +0200</resolved>
                                                    <fixVersion>1.0</fixVersion>
                                        <due></due>
                            <votes>0</votes>
                                    <watches>6</watches>
                                                                                                                <comments>
                            <comment id="74218" author="pmundt" created="Fri, 22 Nov 2013 11:12:33 +0100"  >&lt;p&gt;What options do we have?&lt;/p&gt;

&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;Always redirecting the user on an admin instance to /.magnolia/admincentral&lt;br/&gt;
  (No real options as the &quot;real&quot; preview of a page on admin wouldn&apos;t be possible anymore)&lt;/li&gt;
	&lt;li&gt;Just as the &quot;logout&quot; button, show admincentral button if user is logged in&lt;/li&gt;
	&lt;li&gt;?&lt;/li&gt;
&lt;/ul&gt;
</comment>
                            <comment id="75744" author="pmundt" created="Thu, 12 Dec 2013 13:21:57 +0100"  >&lt;p&gt;Related to &lt;a href=&quot;https://jira.magnolia-cms.com/browse/MGNLUI-2520&quot; title=&quot;Re-Enable multisite-resolution in PageEditor&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MGNLUI-2520&quot;&gt;&lt;del&gt;MGNLUI-2520&lt;/del&gt;&lt;/a&gt; to the extent that &quot;old functionality&quot; has to be restored.&lt;/p&gt;</comment>
                            <comment id="78826" author="mgeljic" created="Wed, 29 Jan 2014 12:09:28 +0100"  >&lt;p&gt;Moving this issue to 1.0.x - we need further specification before anything happens there.&lt;/p&gt;</comment>
                            <comment id="82565" author="mgeljic" created="Thu, 3 Apr 2014 14:54:21 +0200"  >&lt;p&gt;Clarifying this issue by rephrasing title and shedding some light after a couple of rounds of investigation. This issue has the two following flavors:&lt;/p&gt;

&lt;p&gt;1. From site domain root, after login we are currently redirected to such site&apos;s root page.&lt;br/&gt;
&amp;#8211; We want to make it configurable per Site (redirectToSiteRoot) whether a site should redirect to admincentral or its site-root.&lt;br/&gt;
&amp;#8211; Default would be &apos;redirect to admincentral&apos;, so that all domains pointing to author instance behave consistently.&lt;/p&gt;

&lt;p&gt;2. From a rendered page on author, there&apos;s nothing to go straight to the admincentral&apos;s pages app so that I can edit that page directly.&lt;br/&gt;
&amp;#8211; Not to spoil direct access to a page on author (also used in page-editor fwiw), we cannot guess behaviour as to whether we should redirect automatically to pages app or not. This would not work well either with a &apos;per domain&apos;-based approach.&lt;br/&gt;
&amp;#8211; We have to re-introduce a button at the top right of the page, which redirects to .magnolia/admincentral#app:pages:detail;/&amp;lt;url&amp;gt;:edit (design input yet to come).&lt;/p&gt;</comment>
                            <comment id="82674" author="had" created="Sun, 6 Apr 2014 03:58:17 +0200"  >&lt;p&gt;The option 1 is not working for the root/home page. You would be never able to see it, since link generated in menu is &lt;a href=&quot;http://yourdomain/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://yourdomain/&lt;/a&gt; which would then redirect you back to admin central.&lt;/p&gt;</comment>
                            <comment id="83447" author="mdivilek" created="Wed, 16 Apr 2014 21:23:26 +0200"  >&lt;p&gt;3. Re-introduce a green button which redirects to admincentral. It will be done by introducing filter which will add div with &quot;admincentral&quot; button into body of all pages (except .magnolia). Filter could be easily enable/disable and also of format of div with &quot;admincentral&quot; button will be configurable.&lt;/p&gt;</comment>
                            <comment id="88081" author="pmundt" created="Mon, 14 Jul 2014 15:23:20 +0200"  >&lt;p&gt;Setting fixVersion to &quot;1.0.x&quot; as this issue will not be fixed in the maintenance release of &quot;1.0.5&quot;.&lt;/p&gt;</comment>
                            <comment id="88438" author="mdivilek" created="Fri, 18 Jul 2014 15:35:42 +0200"  >&lt;p&gt;committed proposal of the module which inject admincentral button&lt;br/&gt;
&lt;a href=&quot;https://git.magnolia-cms.com/gitweb/?p=user/mdivilek/injectadmincentralbutton.git;a=summary&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://git.magnolia-cms.com/gitweb/?p=user/mdivilek/injectadmincentralbutton.git;a=summary&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="88462" author="had" created="Mon, 21 Jul 2014 09:57:22 +0200"  >&lt;p&gt;Looks good in general, but:&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;get rid of all the comments from pom and module descriptor generated by the artefact.&lt;/li&gt;
	&lt;li&gt;might want to discuss this with Christopher or Tomas or anyone who did more templating, but I think it would be safer to inject your extra div before end of body tag rather then after beginning of it. Since it&apos;s positioned via css it doesn&apos;t matter where it is physically, but it&apos;s definitively safer in case someone is counting divs from top because of other functionality. If that is the case, you probably need to extend functionality to be able to insert before the tag, not only after.&lt;/li&gt;
	&lt;li&gt;naming of variables &lt;tt&gt;initTag&lt;/tt&gt;, &lt;tt&gt;closeTag&lt;/tt&gt; ... seeing those are not really tags, and code doesn&apos;t limit you to tags it might be easier to call them &quot;fragments&quot; and it might be even better to replace those two with single regex ... might want to consult Robert about the regex for it.&lt;/li&gt;
	&lt;li&gt;lastly, get a project created on forge, and commit it there. &lt;img class=&quot;emoticon&quot; src=&quot;https://jira.magnolia-cms.com/images/icons/emoticons/wink.png&quot; height=&quot;16&quot; width=&quot;16&quot; align=&quot;absmiddle&quot; alt=&quot;&quot; border=&quot;0&quot;/&gt;&lt;/li&gt;
&lt;/ul&gt;
</comment>
                            <comment id="88669" author="mdivilek" created="Wed, 23 Jul 2014 20:15:50 +0200"  >&lt;blockquote&gt;&lt;p&gt;it might be even better to replace those two with single regex&lt;/p&gt;&lt;/blockquote&gt;

&lt;p&gt;Checking fragments is done during writing byte to output stream. If we would want to use regex then this would have to be changed -&amp;gt; write whole stream and then do the check for fragment and injection. And in this case it would be probably better use some 3rd party library (probably jsoup) which allows find data using DOM traversal or CSS selectors.&lt;/p&gt;

&lt;blockquote&gt;&lt;p&gt;lastly, get a project created on forge, and commit it there.&lt;/p&gt;&lt;/blockquote&gt;

&lt;p&gt;I changed name of module to magnolia-injection-filter, because it can be used for injection of any code into stream not only the admin central button. Is this name ok? If yes I&apos;ll move it to forge&lt;/p&gt;</comment>
                            <comment id="88694" author="had" created="Thu, 24 Jul 2014 10:31:48 +0200"  >&lt;p&gt;add 1) ok&lt;br/&gt;
add 2) also ok &lt;img class=&quot;emoticon&quot; src=&quot;https://jira.magnolia-cms.com/images/icons/emoticons/smile.png&quot; height=&quot;16&quot; width=&quot;16&quot; align=&quot;absmiddle&quot; alt=&quot;&quot; border=&quot;0&quot;/&gt;&lt;/p&gt;</comment>
                            <comment id="89885" author="rkovarik" created="Mon, 18 Aug 2014 12:01:33 +0200"  >&lt;p&gt;&lt;span class=&quot;nobr&quot;&gt;&lt;a href=&quot;https://jira.magnolia-cms.com/secure/attachment/25444/25444_sitemesh.patch&quot; title=&quot;sitemesh.patch attached to MGNLMODSTR-5&quot;&gt;Solution&lt;sup&gt;&lt;img class=&quot;rendericon&quot; src=&quot;https://jira.magnolia-cms.com/images/icons/link_attachment_7.gif&quot; height=&quot;7&quot; width=&quot;7&quot; align=&quot;absmiddle&quot; alt=&quot;&quot; border=&quot;0&quot;/&gt;&lt;/sup&gt;&lt;/a&gt;&lt;/span&gt; using SiteMesh. &lt;/p&gt;</comment>
                            <comment id="91007" author="had" created="Fri, 12 Sep 2014 08:17:36 +0200"  >&lt;p&gt;Where&apos;s the code? (Not the original commit in your private repo, but the one in target repo w/ updated pom and ready to be released)&lt;/p&gt;</comment>
                            <comment id="91410" author="rkovarik" created="Fri, 19 Sep 2014 08:47:34 +0200"  >&lt;ol&gt;
	&lt;li&gt;&lt;tt&gt;processCodeBeforeInjection&lt;/tt&gt; is hardcoded in &lt;tt&gt;ModifystreamOutputStream&lt;/tt&gt;. Since the modify stream could be used for any content modification, the admincentral button filter should have probably a custom class.&lt;/li&gt;
	&lt;li&gt;&lt;tt&gt;injectAdmincentralButton&lt;/tt&gt; is always bootstrapped which is OK as a modify filter example but should be probably disabled by default.&lt;/li&gt;
	&lt;li&gt;Could you please also add test?&lt;/li&gt;
&lt;/ol&gt;
</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10160">
                    <name>Relates</name>
                                            <outwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="35223">MGNLUI-2520</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                            <issuelinktype id="10021">
                    <name>duplicate</name>
                                                                <inwardlinks description="is duplicated by">
                                        <issuelink>
            <issuekey id="42599">MULTISITE-35</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10010">
                    <name>relation</name>
                                                                <inwardlinks description="is related to">
                                                        </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                            <attachment id="25444" name="sitemesh.patch" size="10012" author="rkovarik" created="Mon, 18 Aug 2014 12:00:25 +0200"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_14166" key="com.okapya.jira.checklist:checklist">
                        <customfieldname>Acceptance criteria</customfieldname>
                        <customfieldvalues>
                            
        <checklist>
        <![CDATA[
                            




                
                                    <div class="o-completion" style="display: flex; flex-shrink: 0;"><span  class="aui-lozenge aui-lozenge-complete" style="font-size: 12px; font-weight: normal; display: flex; flex-direction: row; align-items: center;" ><span style="padding-right: 4px; vertical-align: middle;"><svg width="15" height="15" viewBox="0 0 15 15" xmlns="http://www.w3.org/2000/svg" fill="white"><path clip-rule="evenodd" d="m10.41037,3.42544l-7.86501,0c-0.72395,0 -1.31084,0.58688 -1.31084,1.31084l0,7.86508c0,0.7239 0.58689,1.3108 1.31084,1.3108l7.86501,0c0.724,0 1.3109,-0.5869 1.3109,-1.3108l0,-7.86508c0,-0.72396 -0.5869,-1.31084 -1.3109,-1.31084zm-7.86501,-0.65542c-1.08593,0 -1.96626,0.88032 -1.96626,1.96626l0,7.86508c0,1.0859 0.88033,1.9662 1.96626,1.9662l7.86501,0c1.086,0 1.9663,-0.8803 1.9663,-1.9662l0,-7.86508c0,-1.08594 -0.8803,-1.96626 -1.9663,-1.96626l-7.86501,0z" fill-rule="evenodd"/><path d="m5.09049,10.18526l-1.82767,-1.82766l-0.78479,0.78479l2.61246,2.61246l5.38758,-5.38754l-0.78483,-0.78479l-4.60275,4.60274z"/></svg></span><span>Empty</span></span></div>
                        ]]>
    </checklist>


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10111" key="com.atlassian.jira.toolkit:reporterdomain">
                        <customfieldname>Company</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>magnolia-cms.com</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10031" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Fri, 22 Nov 2013 11:12:33 +0100</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_12730" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_14151" key="com.atlassian.jira.toolkit:message">
                        <customfieldname>Docu info</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10061" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comm is not jira-dev</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>false</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10071" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last participant</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>mmuehlebach</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_13136" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            9 years, 22 weeks, 3 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10020" key="com.atlassian.jira.toolkit:attachments">
                        <customfieldname>Number of attachments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10150" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname>Number of comments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>14.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>had</customfieldvalue>
            <customfieldvalue>mgeljic</customfieldvalue>
            <customfieldvalue>mdivilek</customfieldvalue>
            <customfieldvalue>pmundt</customfieldvalue>
            <customfieldvalue>rkovarik</customfieldvalue>
            <customfieldvalue>zdenekskodik</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10833" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i02aj3:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10244" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>13443</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_14145" key="com.intenso.jira.issue-templates:issue-templates-customfield">
                        <customfieldname>Template</customfieldname>
                        <customfieldvalues>
                            


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_15131" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Time in Discovery</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>