<!-- 
RSS generated by JIRA (9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b) at Mon Feb 12 06:35:11 CET 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Magnolia - Issue tracker</title>
    <link>https://jira.magnolia-cms.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-uk</language>    <build-info>
        <version>9.4.2</version>
        <build-number>940002</build-number>
        <build-date>19-01-2023</build-date>
    </build-info>


<item>
            <title>[MGNLPN-189] Remove personalisation-specific cache configuration</title>
                <link>https://jira.magnolia-cms.com/browse/MGNLPN-189</link>
                <project id="11281" key="MGNLPN">Magnolia Personalization</project>
                    <description>&lt;ol&gt;
	&lt;li&gt;Update dependency to cache 5.3&lt;/li&gt;
	&lt;li&gt;Add update task to use default cache configuration classes again.&lt;/li&gt;
	&lt;li&gt;Deprecate classes which were merged into cache:&lt;/li&gt;
&lt;/ol&gt;
&lt;ul&gt;
	&lt;li&gt;&lt;tt&gt;info.magnolia.personalization.cache.BypassUncacheableEntriesPolicy&lt;/tt&gt;&lt;/li&gt;
	&lt;li&gt;&lt;tt&gt;info.magnolia.module.cache.filter.UncacheableEntry&lt;/tt&gt;&lt;/li&gt;
	&lt;li&gt;Instead of &lt;tt&gt;info.magnolia.personalization.cache.BypassVariantsCacheStore&lt;/tt&gt;, it should be enough to set &quot;Cache-control&quot; header to &quot;no-cache&quot; e.g. in VariantResolver filter if it detects a variant.&lt;/li&gt;
&lt;/ul&gt;
</description>
                <environment></environment>
        <key id="41048">MGNLPN-189</key>
            <summary>Remove personalisation-specific cache configuration</summary>
                <type id="3" iconUrl="https://jira.magnolia-cms.com/secure/viewavatar?size=xsmall&amp;avatarId=10898&amp;avatarType=issuetype">Task</type>
                                            <priority id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/priorities/neutral.gif">Neutral</priority>
                        <status id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="rkovarik">Roman Kova&#345;&#237;k</assignee>
                                    <reporter username="rkovarik">Roman Kova&#345;&#237;k</reporter>
                        <labels>
                            <label>cache</label>
                    </labels>
                <created>Wed, 8 Oct 2014 13:06:51 +0200</created>
                <updated>Thu, 22 Jan 2015 13:26:48 +0100</updated>
                            <resolved>Fri, 7 Nov 2014 14:10:39 +0100</resolved>
                                                    <fixVersion>1.1</fixVersion>
                                    <component>Integration</component>
                        <due></due>
                            <votes>0</votes>
                                    <watches>3</watches>
                                                                                                                <comments>
                            <comment id="92427" author="gjoseph" created="Thu, 9 Oct 2014 11:38:56 +0200"  >&lt;p&gt;Am not convinced about the change to the VariantResolverFilter and the removal of BypassVariantsCacheStore&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;to keep flexibility, there should probably be a visitor pattern for Store implementation or something (so that other modules can contribute their logic), or the logic we have in Store there should be moved to the CachePolicy somehow ? (which means that until we have that, your removing the p13n-specific Store is a good thing&lt;img class=&quot;emoticon&quot; src=&quot;https://jira.magnolia-cms.com/images/icons/emoticons/smile.png&quot; height=&quot;16&quot; width=&quot;16&quot; align=&quot;absmiddle&quot; alt=&quot;&quot; border=&quot;0&quot;/&gt;)&lt;/li&gt;
	&lt;li&gt;I always prefer an explicit call to something like &quot;is the node a variant, if so then we&apos;re uncacheable&quot; rather than setting a header somewhere and as a side-effect we end up not caching the page. It&apos;s a matter of taste, so no strong argument, and in this case it&apos;s pretty explicit&lt;/li&gt;
	&lt;li&gt;But here&apos;s the argument that&apos;s actually worth double checking: won&apos;t setting that header prevent browser caching too ? All we want (AFAIK) is bypass the server-side cache, and let the browser decide if it wants to cache the page (or influence it by other means)&lt;/li&gt;
&lt;/ul&gt;
</comment>
                            <comment id="92453" author="rkovarik" created="Thu, 9 Oct 2014 15:55:30 +0200"  >&lt;blockquote&gt;
&lt;p&gt;...or the logic we have in Store there should be moved to the CachePolicy somehow ?&lt;/p&gt;&lt;/blockquote&gt;
&lt;p&gt;I tried that or just create voter for that but the problem is that we don&apos;t have the necessary information in &lt;tt&gt;AggregationState&lt;/tt&gt; yet. All what we have is just URI.&lt;/p&gt;

&lt;blockquote&gt;
&lt;p&gt;I always prefer an explicit call to something like &quot;is the node a variant, if so then we&apos;re uncacheable&quot; rather than setting a header somewhere and as a side-effect we end up not caching the page.&lt;/p&gt;&lt;/blockquote&gt;
&lt;p&gt;I see your point. I wanted to get rid of p13n specific configuration at all because if you&apos;d need a more specific store, you&apos;d need to implement one for CE and one for EE.&lt;/p&gt;

&lt;blockquote&gt;
&lt;p&gt;won&apos;t setting that header prevent browser caching too?&lt;/p&gt;&lt;/blockquote&gt;
&lt;p&gt;It does &lt;img class=&quot;emoticon&quot; src=&quot;https://jira.magnolia-cms.com/images/icons/emoticons/smile.png&quot; height=&quot;16&quot; width=&quot;16&quot; align=&quot;absmiddle&quot; alt=&quot;&quot; border=&quot;0&quot;/&gt;. I don&apos;t see it as a big problem as:&lt;/p&gt;
&lt;ol&gt;
	&lt;li&gt;&lt;tt&gt;dontCachePages&lt;/tt&gt; voter is usually active anyway.&lt;/li&gt;
	&lt;li&gt;Do we even want to do that? (it would be maybe good to cache a country variant but probably not a new/recurring visitor variant.&lt;br/&gt;
OR we could &lt;a href=&quot;http://jira.magnolia-cms.com/browse/MGNLCACHE-57?focusedCommentId=92603&amp;amp;page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-92603&quot; class=&quot;external-link&quot; rel=&quot;nofollow&quot;&gt;http://jira.magnolia-cms.com/browse/MGNLCACHE-57?focusedCommentId=92603&amp;amp;page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-92603&lt;/a&gt;&lt;/li&gt;
&lt;/ol&gt;
</comment>
                            <comment id="92621" author="gjoseph" created="Mon, 13 Oct 2014 13:54:39 +0200"  >&lt;blockquote&gt;
&lt;blockquote&gt;&lt;p&gt;...or the logic we have in Store there should be moved to the CachePolicy somehow ?&lt;/p&gt;&lt;/blockquote&gt;
&lt;p&gt;I tried that or just create voter for that but the problem is that we don&apos;t have the necessary information in AggregationState yet. All what we have is just URI.&lt;/p&gt;

&lt;blockquote&gt;&lt;p&gt;I always prefer an explicit call to something like &quot;is the node a variant, if so then we&apos;re uncacheable&quot; rather than setting a header somewhere and as a side-effect we end up not caching the page.&lt;/p&gt;&lt;/blockquote&gt;
&lt;p&gt;I see your point. I wanted to get rid of p13n specific configuration at all because if you&apos;d need a more specific store, you&apos;d need to implement one for CE and one for EE.&lt;/p&gt;&lt;/blockquote&gt;
&lt;p&gt;Agreed on both point; the stuff I&apos;m suggesting would require more changes in Cache module, I&apos;m aware it&apos;s not possible as-is with the current API.&lt;/p&gt;

&lt;blockquote&gt;
&lt;blockquote&gt;&lt;p&gt;won&apos;t setting that header prevent browser caching too?&lt;/p&gt;&lt;/blockquote&gt;
&lt;p&gt;It does . I don&apos;t see it as a big problem as:&lt;/p&gt;
&lt;ol&gt;
	&lt;li&gt;dontCachePages voter is usually active anyway.&lt;/li&gt;
	&lt;li&gt;Do we even want to do that? (it would be maybe good to cache a country variant but probably not a new/recurring visitor variant.&lt;/li&gt;
&lt;/ol&gt;
&lt;/blockquote&gt;

&lt;p&gt;The problem is not so much the effect of the header itself than the fact that it&apos;s a hidden side-effect, and that the day it&apos;ll be a problem for someone somewhere, it&apos;ll be harder to track down that necessary.&lt;/p&gt;</comment>
                            <comment id="92629" author="rkovarik" created="Mon, 13 Oct 2014 15:42:49 +0200"  >&lt;p&gt;Does it make sense to use &lt;a href=&quot;https://jira.magnolia-cms.com/browse/MGNLCACHE-77&quot; title=&quot;Introduce mechanism for setting ttl independently from browser caching&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MGNLCACHE-77&quot;&gt;&lt;del&gt;MGNLCACHE-77&lt;/del&gt;&lt;/a&gt; header instead?&lt;/p&gt;</comment>
                            <comment id="92763" author="gjoseph" created="Wed, 15 Oct 2014 13:41:52 +0200"  >&lt;p&gt; I like the decoupling this permits between cache-Store and p13n. I don&apos;t like the &quot;magic number&quot; approach. Did you think of any possible alternatives ? (incl deeper changes to cache apis)&lt;/p&gt;</comment>
                            <comment id="93298" author="rkovarik" created="Fri, 24 Oct 2014 09:39:19 +0200"  >&lt;p&gt;Reopen: adjust to changes in depending ticket.&lt;/p&gt;</comment>
                            <comment id="93610" author="rkovarik" created="Wed, 29 Oct 2014 08:43:20 +0100"  >&lt;p&gt;Review by architects:&lt;/p&gt;
&lt;ol&gt;
	&lt;li&gt;HasVariantVoter needs javadoc&lt;/li&gt;
	&lt;li&gt;If not, then when using Provider&amp;lt;AggState&amp;gt;, name it aggstateProvider (injected at different scope)&lt;/li&gt;
	&lt;li&gt;PersonalizationIntegrationModuleVersionHandler : avoid bootstrap file for 2-properties node of isNotVariant, use NodeBuilder or simple tasks instead.&lt;/li&gt;
	&lt;li&gt;HasVariantVoter is not-ed in config - maybe it&#8217;s easier to read if it&#8217;s positive ? WDYT about rename to IsCacheable (in the p13n packages) and avoid the &#8220;not&#8221; ?&lt;/li&gt;
	&lt;li&gt;HasVariantVoter extends AbstractBoolVoter&amp;lt;Object&amp;gt; -&amp;gt; should be typed. This lead us to see that the passed value (CachedEntry) is actually not used by voter&lt;/li&gt;
&lt;/ol&gt;
</comment>
                            <comment id="93617" author="rkovarik" created="Wed, 29 Oct 2014 10:47:44 +0100"  >&lt;ol&gt;
	&lt;li&gt;fixed.&lt;/li&gt;
	&lt;li&gt;fixed.&lt;/li&gt;
	&lt;li&gt;fixed.&lt;/li&gt;
	&lt;li&gt;&lt;/li&gt;
	&lt;li&gt;The idea was to make the voter more generic to make it possible to use elsewhere. We do the same in half of &lt;tt&gt;info.magnolia.voting.voters&lt;/tt&gt; .&lt;br/&gt;
Everything squashed on the branch &lt;a href=&quot;https://jira.magnolia-cms.com/browse/MGNLPN-189&quot; title=&quot;Remove personalisation-specific cache configuration&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MGNLPN-189&quot;&gt;&lt;del&gt;MGNLPN-189&lt;/del&gt;&lt;/a&gt;-squash.&lt;/li&gt;
&lt;/ol&gt;
</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10020">
                    <name>dependency</name>
                                            <outwardlinks description="depends upon">
                                        <issuelink>
            <issuekey id="38769">MGNLCACHE-57</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                            <issuelinktype id="10022">
                    <name>supersession</name>
                                            <outwardlinks description="supersedes">
                                        <issuelink>
            <issuekey id="40256">MGNLPN-186</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="38708">MGNLPN-112</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_14166" key="com.okapya.jira.checklist:checklist">
                        <customfieldname>Acceptance criteria</customfieldname>
                        <customfieldvalues>
                            
        <checklist>
        <![CDATA[
                            




                
                                    <div class="o-completion" style="display: flex; flex-shrink: 0;"><span  class="aui-lozenge aui-lozenge-complete" style="font-size: 12px; font-weight: normal; display: flex; flex-direction: row; align-items: center;" ><span style="padding-right: 4px; vertical-align: middle;"><svg width="15" height="15" viewBox="0 0 15 15" xmlns="http://www.w3.org/2000/svg" fill="white"><path clip-rule="evenodd" d="m10.41037,3.42544l-7.86501,0c-0.72395,0 -1.31084,0.58688 -1.31084,1.31084l0,7.86508c0,0.7239 0.58689,1.3108 1.31084,1.3108l7.86501,0c0.724,0 1.3109,-0.5869 1.3109,-1.3108l0,-7.86508c0,-0.72396 -0.5869,-1.31084 -1.3109,-1.31084zm-7.86501,-0.65542c-1.08593,0 -1.96626,0.88032 -1.96626,1.96626l0,7.86508c0,1.0859 0.88033,1.9662 1.96626,1.9662l7.86501,0c1.086,0 1.9663,-0.8803 1.9663,-1.9662l0,-7.86508c0,-1.08594 -0.8803,-1.96626 -1.9663,-1.96626l-7.86501,0z" fill-rule="evenodd"/><path d="m5.09049,10.18526l-1.82767,-1.82766l-0.78479,0.78479l2.61246,2.61246l5.38758,-5.38754l-0.78483,-0.78479l-4.60275,4.60274z"/></svg></span><span>Empty</span></span></div>
                        ]]>
    </checklist>


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10111" key="com.atlassian.jira.toolkit:reporterdomain">
                        <customfieldname>Company</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>magnolia-cms.com</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10031" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Thu, 9 Oct 2014 11:38:56 +0200</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_12730" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_14151" key="com.atlassian.jira.toolkit:message">
                        <customfieldname>Docu info</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10061" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comm is not jira-dev</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10071" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last participant</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>mmuehlebach</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_13136" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            9 years, 16 weeks, 4 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10020" key="com.atlassian.jira.toolkit:attachments">
                        <customfieldname>Number of attachments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10150" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname>Number of comments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>8.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>gjoseph</customfieldvalue>
            <customfieldvalue>rkovarik</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                <customfield id="customfield_10833" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i03r67:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10244" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>22010</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_14167" key="com.okapya.jira.checklist:checklist">
                        <customfieldname>Task DoR</customfieldname>
                        <customfieldvalues>
                            
        <checklist>
        <![CDATA[
                            




                
                                    <div class="o-completion" style="display: flex; flex-shrink: 0;"><span  class="aui-lozenge aui-lozenge-complete" style="font-size: 12px; font-weight: normal; display: flex; flex-direction: row; align-items: center;" ><span style="padding-right: 4px; vertical-align: middle;"><svg width="15" height="15" viewBox="0 0 15 15" xmlns="http://www.w3.org/2000/svg" fill="white"><path clip-rule="evenodd" d="m10.41037,3.42544l-7.86501,0c-0.72395,0 -1.31084,0.58688 -1.31084,1.31084l0,7.86508c0,0.7239 0.58689,1.3108 1.31084,1.3108l7.86501,0c0.724,0 1.3109,-0.5869 1.3109,-1.3108l0,-7.86508c0,-0.72396 -0.5869,-1.31084 -1.3109,-1.31084zm-7.86501,-0.65542c-1.08593,0 -1.96626,0.88032 -1.96626,1.96626l0,7.86508c0,1.0859 0.88033,1.9662 1.96626,1.9662l7.86501,0c1.086,0 1.9663,-0.8803 1.9663,-1.9662l0,-7.86508c0,-1.08594 -0.8803,-1.96626 -1.9663,-1.96626l-7.86501,0z" fill-rule="evenodd"/><path d="m5.09049,10.18526l-1.82767,-1.82766l-0.78479,0.78479l2.61246,2.61246l5.38758,-5.38754l-0.78483,-0.78479l-4.60275,4.60274z"/></svg></span><span>Empty</span></span></div>
                        ]]>
    </checklist>


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    <customfield id="customfield_14145" key="com.intenso.jira.issue-templates:issue-templates-customfield">
                        <customfieldname>Template</customfieldname>
                        <customfieldvalues>
                            


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_15131" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Time in Discovery</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>