<!-- 
RSS generated by JIRA (9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b) at Mon Feb 12 06:47:59 CET 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Magnolia - Issue tracker</title>
    <link>https://jira.magnolia-cms.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-uk</language>    <build-info>
        <version>9.4.2</version>
        <build-number>940002</build-number>
        <build-date>19-01-2023</build-date>
    </build-info>


<item>
            <title>[MGNLRES-160] Create Publish and Unpublish actions</title>
                <link>https://jira.magnolia-cms.com/browse/MGNLRES-160</link>
                <project id="10282" key="MGNLRES">Magnolia Resources Module</project>
                    <description>&lt;p&gt;Publish action has to publish the ancestor&apos;s of a given node. E.g &lt;tt&gt;/foo/bar.txt&lt;/tt&gt; will publish foo as well.&lt;br/&gt;
However, Unpublish action should just unpublish the given node E.g &lt;tt&gt;/foo/bar.txt&lt;/tt&gt; will just unpublish bar.&lt;/p&gt;</description>
                <environment></environment>
        <key id="45416">MGNLRES-160</key>
            <summary>Create Publish and Unpublish actions</summary>
                <type id="5" iconUrl="https://jira.magnolia-cms.com/secure/viewavatar?size=xsmall&amp;avatarId=10896&amp;avatarType=issuetype">Sub-task</type>
                            <parent id="44040">MGNLRES-140</parent>
                                    <priority id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/priorities/neutral.gif">Neutral</priority>
                        <status id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="ilgun">Ilgun Ilgun</assignee>
                                    <reporter username="ilgun">Ilgun Ilgun</reporter>
                        <labels>
                            <label>platform-cell</label>
                    </labels>
                <created>Fri, 29 May 2015 10:54:00 +0200</created>
                <updated>Mon, 29 Jun 2015 17:12:42 +0200</updated>
                            <resolved>Tue, 23 Jun 2015 16:34:39 +0200</resolved>
                                                    <fixVersion>2.4</fixVersion>
                                    <component>app</component>
                        <due></due>
                            <votes>0</votes>
                                    <watches>2</watches>
                                                                                                                <comments>
                            <comment id="105740" author="apchelintcev" created="Fri, 5 Jun 2015 13:58:06 +0200"  >&lt;p&gt;These actions are not gonna work with the new Resources app out of the box since they rely on the published items to be {{JcrNodeAdapter}}s.&lt;/p&gt;</comment>
                            <comment id="105888" author="ilgun" created="Tue, 9 Jun 2015 10:58:08 +0200"  >&lt;p&gt;Changes can be found in:  &lt;tt&gt;feature/hotfix-activation-actions&lt;/tt&gt;&lt;/p&gt;</comment>
                            <comment id="106651" author="apchelintcev" created="Tue, 23 Jun 2015 09:12:00 +0200"  >&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;HotfixActivationAction:
	&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
		&lt;li&gt;import org.apache.commons.codec.binary.StringUtils; - that&apos;s not the StringUtils you&apos;re looking for, org.apache.commons.lang3.StringUtils your friend is =)&lt;/li&gt;
		&lt;li&gt;JavaDoc Explain a bit the principles:
		&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
			&lt;li&gt;relation with the ActivationAction,&lt;/li&gt;
			&lt;li&gt;node preparation principle etc.&lt;/li&gt;
			&lt;li&gt;structure of the incoming item (what name/kind of properties to expect in there)&lt;/li&gt;
		&lt;/ul&gt;
		&lt;/li&gt;
		&lt;li&gt;resourceHandle.getValue().toString() -&amp;gt; resourceHandle.getString()&lt;/li&gt;
		&lt;li&gt;publishParentNodes() should not be called from the c-tor, there&apos;s an execute() method for that&lt;/li&gt;
		&lt;li&gt;definition.setRecursive(true); - potentially problematic call, since the action definition is kind of a singleton, so we shouldn&apos;t modify those like that, consider using wrappers/delegate definitions for the delegate actions&lt;/li&gt;
		&lt;li&gt;&quot;resourceHandle&quot; - could it be a constant?&lt;/li&gt;
	&lt;/ul&gt;
	&lt;/li&gt;
&lt;/ul&gt;


&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;IsNotDeletedRule:
	&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
		&lt;li&gt;JavaDoc:
		&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
			&lt;li&gt;&apos;the item&apos; -&amp;gt; the passed 
{@ link ResourcePath}
&lt;p&gt;?&lt;/p&gt;&lt;/li&gt;
			&lt;li&gt;embrace JcrOrigin into 
{@ link}&lt;/li&gt;
			&lt;li&gt;mgnl:deleted - 
{@ code}
&lt;p&gt;?&lt;/p&gt;&lt;/li&gt;
		&lt;/ul&gt;
		&lt;/li&gt;
	&lt;/ul&gt;
	&lt;/li&gt;
&lt;/ul&gt;


&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;IsPublishedRule:
	&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
		&lt;li&gt;JavaDoc - same, introduce links where possible, be specific about the item type.&lt;/li&gt;
		&lt;li&gt;extract LayeredResourcePath cast into a local var&lt;/li&gt;
		&lt;li&gt;String resourcePath -&amp;gt; resourceHandle, itemId -&amp;gt; resourcePath&lt;/li&gt;
		&lt;li&gt;use &apos;final&apos;for local vars&lt;/li&gt;
	&lt;/ul&gt;
	&lt;/li&gt;
&lt;/ul&gt;


&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;HotfixActivationActionTest:
	&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
		&lt;li&gt;Unnecessary casts to Booleans (e.g. context.getAttribute( etc)&lt;/li&gt;
		&lt;li&gt;All setImplementation(..) calls seem to be unnecessary&lt;/li&gt;
		&lt;li&gt;If you&apos;re dealing w/ RepoTestCase (which provides real jcr stuff), why you&apos;d need mock sessions, maybe consider MgnlTestCase?&lt;/li&gt;
		&lt;li&gt;You instantiate MockContext, but the super class already prepares one - maybe re-use it?&lt;/li&gt;
	&lt;/ul&gt;
	&lt;/li&gt;
&lt;/ul&gt;
</comment>
                            <comment id="106700" author="ilgun" created="Tue, 23 Jun 2015 12:17:37 +0200"  >&lt;p&gt;Made the necessary changes regarding the review.&lt;/p&gt;</comment>
                            <comment id="106741" author="apchelintcev" created="Tue, 23 Jun 2015 15:12:16 +0200"  >&lt;p&gt;HotfixActivationAction:&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;Why re-use onPreExecute() method? - that is not the logical place where the activation should be triggered,  there is an execute() method that invokes the activation of the items&lt;/li&gt;
	&lt;li&gt;Check info.magnolia.ui.framework.action.AbstractMultiItemAction#getItems - I think that it would be more subtle and correct to override that method and leave the rest of the action as is&lt;/li&gt;
	&lt;li&gt;check the JavaDoc
	&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
		&lt;li&gt;still mentions non-existent publishParentNodes method,&lt;/li&gt;
		&lt;li&gt;&quot;allows to activate/deactivate a hotfix&quot; -&amp;gt; &quot;allows to publish/un-publish a hotfixed version of a resource&lt;/li&gt;
		&lt;li&gt;*  
{@link ActivationAction}
&lt;p&gt;. - should be removed since current class extends ActivationAction.&lt;/p&gt;&lt;/li&gt;
	&lt;/ul&gt;
	&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;IsPublishedrule:&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;JavaDoc
	&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
		&lt;li&gt;use link for info.magnolia.jcr.util.NodeTypes.Activatable#ACTIVATION_STATUS_NOT_ACTIVATED&lt;/li&gt;
	&lt;/ul&gt;
	&lt;/li&gt;
&lt;/ul&gt;
</comment>
                            <comment id="106762" author="ilgun" created="Tue, 23 Jun 2015 16:34:39 +0200"  >&lt;p&gt;Made necessary changes regarding review.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10111" key="com.atlassian.jira.toolkit:reporterdomain">
                        <customfieldname>Company</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>magnolia-cms.com</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10031" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Fri, 5 Jun 2015 13:58:06 +0200</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_12730" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_14151" key="com.atlassian.jira.toolkit:message">
                        <customfieldname>Docu info</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10061" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comm is not jira-dev</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10071" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last participant</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>ajones</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_13136" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            8 years, 34 weeks, 5 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10020" key="com.atlassian.jira.toolkit:attachments">
                        <customfieldname>Number of attachments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10150" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname>Number of comments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>6.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>apchelintcev</customfieldvalue>
            <customfieldvalue>ilgun</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10833" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i04zv0:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10244" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10245" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="59">5.4 Sprint 4</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_12430" key="com.atlassian.teams:rm-teams-custom-field-team">
                        <customfieldname>Team</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[27]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_14145" key="com.intenso.jira.issue-templates:issue-templates-customfield">
                        <customfieldname>Template</customfieldname>
                        <customfieldvalues>
                            


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_15131" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Time in Discovery</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            </customfields>
    </item>
</channel>
</rss>