<!-- 
RSS generated by JIRA (9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b) at Mon Feb 12 07:35:16 CET 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Magnolia - Issue tracker</title>
    <link>https://jira.magnolia-cms.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-uk</language>    <build-info>
        <version>9.4.2</version>
        <build-number>940002</build-number>
        <build-date>19-01-2023</build-date>
    </build-info>


<item>
            <title>[MGNLSTK-1300] Vertical Navigation isShowVerticalNavigation returns incorrect value</title>
                <link>https://jira.magnolia-cms.com/browse/MGNLSTK-1300</link>
                <project id="10287" key="MGNLSTK">Magnolia Standard Templating Kit (closed)</project>
                    <description>&lt;p&gt;The method createVerticalNavigation() correctly checks the start level, but the method isShowVerticalNavigation() does not. Affecting everything that uses the vertical navigation.&lt;/p&gt;

&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
    &lt;span class=&quot;code-keyword&quot;&gt;public&lt;/span&gt; &lt;span class=&quot;code-object&quot;&gt;boolean&lt;/span&gt; isShowVerticalNavigation() {
        &lt;span class=&quot;code-keyword&quot;&gt;try&lt;/span&gt; {
            &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt;(isShowHorizontalNavigation() &amp;amp;&amp;amp; siteRoot.getDepth() + &lt;span class=&quot;code-keyword&quot;&gt;this&lt;/span&gt;.getHorizontalLevel() &amp;gt; currentNode.getDepth() ){
                &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; &lt;span class=&quot;code-keyword&quot;&gt;false&lt;/span&gt;;
            }
            &lt;span class=&quot;code-keyword&quot;&gt;final&lt;/span&gt; &lt;span class=&quot;code-object&quot;&gt;boolean&lt;/span&gt; enabled = siteNavigation.getVertical().getEnabled();
            &lt;span class=&quot;code-keyword&quot;&gt;final&lt;/span&gt; &lt;span class=&quot;code-object&quot;&gt;boolean&lt;/span&gt; empty = createVerticalNavigation().getItems().isEmpty();
            &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; enabled &amp;amp;&amp;amp; !empty;
        }
        &lt;span class=&quot;code-keyword&quot;&gt;catch&lt;/span&gt; (RepositoryException e) {
            log.error(&lt;span class=&quot;code-quote&quot;&gt;&quot;Can&apos;t check existence of vertical navigation&quot;&lt;/span&gt;,e);
            &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; &lt;span class=&quot;code-keyword&quot;&gt;false&lt;/span&gt;;
        }
    }
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;Should be something like:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
    &lt;span class=&quot;code-keyword&quot;&gt;public&lt;/span&gt; &lt;span class=&quot;code-object&quot;&gt;boolean&lt;/span&gt; isShowVerticalNavigation() {
        &lt;span class=&quot;code-object&quot;&gt;int&lt;/span&gt; startlevel = siteNavigation.getVertical().getStartLevel() &amp;gt; 0 ? siteNavigation.getVertical().getStartLevel() : startLevel + getHorizontalLevel();
        &lt;span class=&quot;code-keyword&quot;&gt;try&lt;/span&gt; {
            &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt;(isShowHorizontalNavigation() &amp;amp;&amp;amp; siteRoot.getDepth() + startLevel &amp;gt; currentNode.getDepth() ){
                &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; &lt;span class=&quot;code-keyword&quot;&gt;false&lt;/span&gt;;
            }
            &lt;span class=&quot;code-keyword&quot;&gt;final&lt;/span&gt; &lt;span class=&quot;code-object&quot;&gt;boolean&lt;/span&gt; enabled = siteNavigation.getVertical().getEnabled();
            &lt;span class=&quot;code-keyword&quot;&gt;final&lt;/span&gt; &lt;span class=&quot;code-object&quot;&gt;boolean&lt;/span&gt; empty = createVerticalNavigation().getItems().isEmpty();
            &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; enabled &amp;amp;&amp;amp; !empty;
        }
        &lt;span class=&quot;code-keyword&quot;&gt;catch&lt;/span&gt; (RepositoryException e) {
            log.error(&lt;span class=&quot;code-quote&quot;&gt;&quot;Can&apos;t check existence of vertical navigation&quot;&lt;/span&gt;,e);
            &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; &lt;span class=&quot;code-keyword&quot;&gt;false&lt;/span&gt;;
        }
    }
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</description>
                <environment></environment>
        <key id="34556">MGNLSTK-1300</key>
            <summary>Vertical Navigation isShowVerticalNavigation returns incorrect value</summary>
                <type id="1" iconUrl="https://jira.magnolia-cms.com/secure/viewavatar?size=xsmall&amp;avatarId=10883&amp;avatarType=issuetype">Bug</type>
                                            <priority id="3" iconUrl="https://jira.magnolia-cms.com/images/icons/priorities/major.svg">Major</priority>
                        <status id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="pmundt">Philip Mundt</assignee>
                                    <reporter username="rulate">Ricardo Ulate</reporter>
                        <labels>
                            <label>maintenance</label>
                            <label>next</label>
                            <label>quickwin</label>
                            <label>support</label>
                    </labels>
                <created>Fri, 15 Nov 2013 15:19:16 +0100</created>
                <updated>Mon, 3 Feb 2014 14:40:25 +0100</updated>
                            <resolved>Mon, 3 Feb 2014 09:09:58 +0100</resolved>
                                    <version>2.7</version>
                                    <fixVersion>2.0.17</fixVersion>
                    <fixVersion>2.7.2</fixVersion>
                                        <due></due>
                            <votes>0</votes>
                                    <watches>3</watches>
                                                                                                                <comments>
                            <comment id="78853" author="czimmermann" created="Wed, 29 Jan 2014 15:15:02 +0100"  >&lt;p&gt;Fix isShowVerticalNavigation to take startLevel setting of verticalNavigation into account so that for example the horizontal and vertical navigation can be displayed at the same time.&lt;/p&gt;

&lt;p&gt;Example of what did not work properly previously, but now works:&lt;br/&gt;
On a fresh install of STK and demo project:&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;Open Site Definitions App&lt;/li&gt;
	&lt;li&gt;Navigate to: /templates/prototype/navigation/vertical and add property startLevel=1&lt;/li&gt;
	&lt;li&gt;Navigate to: /templates/prototype/navigation/horizontal and set property level=2&lt;/li&gt;
	&lt;li&gt;In Pages app open /demo-project/about&lt;br/&gt;
&amp;gt; With the fix the horizontal nav will be displayed on top and the vertical nav will be displayed to the left. Without the fix, the vertical nav will not be displayed.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Note, also see for reference: &lt;a href=&quot;http://documentation.magnolia-cms.com/display/DOCS/Navigation&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://documentation.magnolia-cms.com/display/DOCS/Navigation&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="79001" author="mdivilek" created="Fri, 31 Jan 2014 12:34:28 +0100"  >&lt;p&gt;Reopen:&lt;/p&gt;

&lt;p&gt;1. If you compare determination of start level in info.magnolia.module.templatingkit.navigation.SiteNavigationModel#isShowVerticalNavigation and in info.magnolia.module.templatingkit.navigation.SiteNavigationModel#createVerticalNavigation then it&apos;s different.&lt;br/&gt;
In &lt;tt&gt;#createVerticalNavigation()&lt;/tt&gt; method if &lt;tt&gt;siteNavigation.getVertical().getStartLevel() &amp;gt; 0&lt;/tt&gt; then &lt;tt&gt;siteNavigation.getVertical().getStartLevel()&lt;/tt&gt; is used as &lt;tt&gt;startLevel&lt;/tt&gt;, but in &lt;tt&gt;#isShowVerticalNavigation&lt;/tt&gt; method &lt;tt&gt;siteRoot.getDepth() + siteNavigation.getVertical().getStartLevel()&lt;/tt&gt; is used as &lt;tt&gt;startLevel&lt;/tt&gt;. It causing wrong vertical navigation when siteRoot (Home page) is not on top level. Correctly we should use &lt;tt&gt;siteRoot.getDepth() + siteNavigation.getVertical().getStartLevel()&lt;/tt&gt; in both of them.&lt;/p&gt;

&lt;p&gt;Reproduce:&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;in Site Definitions App add property &lt;tt&gt;startLevel=1&lt;/tt&gt; to &lt;tt&gt;/templates/prototype/navigation/vertical&lt;/tt&gt;&lt;/li&gt;
	&lt;li&gt;Create new top level site called &lt;tt&gt;firstLevel&lt;/tt&gt; with template &quot;redirect&quot;&lt;/li&gt;
	&lt;li&gt;Create sub page called &lt;tt&gt;secondLevel&lt;/tt&gt; with template &quot;redirect&quot;&lt;/li&gt;
	&lt;li&gt;Move whole demo-project under &lt;tt&gt;secondLevel&lt;/tt&gt;&lt;/li&gt;
	&lt;li&gt;Open /firstLevel/secondLevel/demo-project/about site and you can see wrong vertical navigation. It contains menu &lt;tt&gt;secondLevel&lt;/tt&gt; and &lt;tt&gt;demo-project&lt;/tt&gt; items&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;2. Because the determination of startLevel should be same in both (&lt;tt&gt;#isShowVerticalNavigation&lt;/tt&gt;, &lt;tt&gt;#createVerticalNavigation&lt;/tt&gt;) method we should consider to create new  private method for determination of startLevel and then use this method in both methods.&lt;/p&gt;

&lt;p&gt;3. Why did you create new isShowVerticalNavigationPrevious() method and let there old code? If the old code is wrong then we should remove it.&lt;/p&gt;

&lt;p&gt;4. I would do also the backport into 2.0.x version (Magnolia 4.5.x). See discussion under &lt;a href=&quot;http://documentation.magnolia-cms.com/display/DOCS/Navigation&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://documentation.magnolia-cms.com/display/DOCS/Navigation&lt;/a&gt; . It should be easy port, because there should not be difference between code. &lt;/p&gt;


</comment>
                            <comment id="79092" author="mdivilek" created="Mon, 3 Feb 2014 10:59:22 +0100"  >&lt;p&gt;Reopen:&lt;/p&gt;

&lt;p&gt;If no vertical start level was set then you do &lt;tt&gt;startLevel += getHorizontalStartLevel() + getHorizontalLevel();&lt;/tt&gt; , but problem is &lt;tt&gt;getHorizontalStartLevel()&lt;/tt&gt; this property is not used during creation of info.magnolia.module.templatingkit.navigation.SiteNavigationModel#getHorizontalNavigation, because horizontal menu has to begin on siteRoot.&lt;/p&gt;

&lt;p&gt;Correct code should be only &lt;tt&gt;startLevel += getHorizontalLevel();&lt;/tt&gt;&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10160">
                    <name>Relates</name>
                                            <outwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="31065">MGNLSTK-1178</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                            <issuelinktype id="10010">
                    <name>relation</name>
                                            <outwardlinks description="is related to">
                                                        </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_14166" key="com.okapya.jira.checklist:checklist">
                        <customfieldname>Acceptance criteria</customfieldname>
                        <customfieldvalues>
                            
        <checklist>
        <![CDATA[
                            




                
                                    <div class="o-completion" style="display: flex; flex-shrink: 0;"><span  class="aui-lozenge aui-lozenge-complete" style="font-size: 12px; font-weight: normal; display: flex; flex-direction: row; align-items: center;" ><span style="padding-right: 4px; vertical-align: middle;"><svg width="15" height="15" viewBox="0 0 15 15" xmlns="http://www.w3.org/2000/svg" fill="white"><path clip-rule="evenodd" d="m10.41037,3.42544l-7.86501,0c-0.72395,0 -1.31084,0.58688 -1.31084,1.31084l0,7.86508c0,0.7239 0.58689,1.3108 1.31084,1.3108l7.86501,0c0.724,0 1.3109,-0.5869 1.3109,-1.3108l0,-7.86508c0,-0.72396 -0.5869,-1.31084 -1.3109,-1.31084zm-7.86501,-0.65542c-1.08593,0 -1.96626,0.88032 -1.96626,1.96626l0,7.86508c0,1.0859 0.88033,1.9662 1.96626,1.9662l7.86501,0c1.086,0 1.9663,-0.8803 1.9663,-1.9662l0,-7.86508c0,-1.08594 -0.8803,-1.96626 -1.9663,-1.96626l-7.86501,0z" fill-rule="evenodd"/><path d="m5.09049,10.18526l-1.82767,-1.82766l-0.78479,0.78479l2.61246,2.61246l5.38758,-5.38754l-0.78483,-0.78479l-4.60275,4.60274z"/></svg></span><span>Empty</span></span></div>
                        ]]>
    </checklist>


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10111" key="com.atlassian.jira.toolkit:reporterdomain">
                        <customfieldname>Company</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>ilscipio.com</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10031" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Wed, 29 Jan 2014 15:15:02 +0100</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_12730" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_14151" key="com.atlassian.jira.toolkit:message">
                        <customfieldname>Docu info</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10061" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comm is not jira-dev</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>false</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10071" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last participant</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>mmuehlebach</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_13136" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            10 years, 2 weeks, 6 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10020" key="com.atlassian.jira.toolkit:attachments">
                        <customfieldname>Number of attachments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10150" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname>Number of comments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>3.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>czimmermann</customfieldvalue>
            <customfieldvalue>mdivilek</customfieldvalue>
            <customfieldvalue>pmundt</customfieldvalue>
            <customfieldvalue>rulate</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10090" key="com.atlassian.jira.plugin.system.customfieldtypes:multicheckboxes">
                        <customfieldname>Patch included</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10100"><![CDATA[Yes]]></customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_10833" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i029zr:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10244" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>13356</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_14145" key="com.intenso.jira.issue-templates:issue-templates-customfield">
                        <customfieldname>Template</customfieldname>
                        <customfieldvalues>
                            


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_15131" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Time in Discovery</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>