<!-- 
RSS generated by JIRA (9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b) at Mon Feb 12 07:28:15 CET 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Magnolia - Issue tracker</title>
    <link>https://jira.magnolia-cms.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-uk</language>    <build-info>
        <version>9.4.2</version>
        <build-number>940002</build-number>
        <build-date>19-01-2023</build-date>
    </build-info>


<item>
            <title>[MGNLSTK-564] DAM Support does not work if I only have DMS handler</title>
                <link>https://jira.magnolia-cms.com/browse/MGNLSTK-564</link>
                <project id="10287" key="MGNLSTK">Magnolia Standard Templating Kit (closed)</project>
                    <description>&lt;p&gt;I removed the &quot;upload&quot; handler from the damSupport, so that the Editor can only choose an image from DMS.&lt;br/&gt;
This is what I&apos;ve done:&lt;br/&gt;
Templating Kit --&amp;gt; Site Definitions --&amp;gt; &amp;lt;my site&amp;gt; --&amp;gt; damSupport --&amp;gt; handlers --&amp;gt; upload.&lt;br/&gt;
I set the &quot;enabled&quot; property of this content node to &quot;false&quot;.&lt;br/&gt;
This way, the Editor can only choose an image from DMS (she can not upload it directly).&lt;/p&gt;

&lt;p&gt;If the DAM support is configured like this, with only one handler, the information about the image is not saved correctly.&lt;br/&gt;
For example:&lt;br/&gt;
If the name of the property that stores the image is &quot;myImage&quot;, then when there are two handlers, after saving the image, in JCR browser I can see that there are two nodes for the image:&lt;br/&gt;
1. myImage = dms&lt;br/&gt;
2. myImageDmsUUID = 766a6d0d-4f96-45d8-a6a6-575bace65636&lt;br/&gt;
But with only one handler in place, all I get after saving the dialog is:&lt;br/&gt;
1. myImageDmsUUID = 766a6d0d-4f96-45d8-a6a6-575bace65636&lt;/p&gt;

&lt;p&gt;Now when I test for the existence of the &quot;myImage&quot; property in freemarker, I get result that there is no image.&lt;/p&gt;</description>
                <environment></environment>
        <key id="17672">MGNLSTK-564</key>
            <summary>DAM Support does not work if I only have DMS handler</summary>
                <type id="1" iconUrl="https://jira.magnolia-cms.com/secure/viewavatar?size=xsmall&amp;avatarId=10883&amp;avatarType=issuetype">Bug</type>
                                            <priority id="3" iconUrl="https://jira.magnolia-cms.com/images/icons/priorities/major.svg">Major</priority>
                        <status id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="ochytil">Ondrej Chytil</assignee>
                                    <reporter username="bobi4597">Bozidar Ilievski</reporter>
                        <labels>
                            <label>stk</label>
                    </labels>
                <created>Wed, 13 Jan 2010 20:59:52 +0100</created>
                <updated>Thu, 30 Sep 2010 16:31:57 +0200</updated>
                            <resolved>Mon, 2 Aug 2010 13:00:44 +0200</resolved>
                                    <version>1.2</version>
                                    <fixVersion>1.3.5</fixVersion>
                                    <component>controls</component>
                        <due></due>
                            <votes>1</votes>
                                    <watches>2</watches>
                                                                                                                <comments>
                            <comment id="26213" author="ebunders" created="Wed, 27 Jan 2010 16:06:21 +0100"  >&lt;p&gt;Some implications of this bug:&lt;/p&gt;

&lt;p&gt;in  info.magnolia.module.templatingkit.dam.DAMSupport&lt;br/&gt;
the following method (line 99) will throw an AssetNotFoundException,&lt;br/&gt;
because the handler can no longer be resolved.&lt;/p&gt;

&lt;p&gt; public Asset getAsset(Content node, String nodeDataPrefix) throws&lt;br/&gt;
DAMException {&lt;br/&gt;
       String handlerName = NodeDataUtil.getString(node, nodeDataPrefix);&lt;br/&gt;
       final String path = node.getHandle() + &quot;/&quot; + nodeDataPrefix;&lt;br/&gt;
       if(StringUtils.isEmpty(handlerName))&lt;/p&gt;
{
           throw new AssetNotFoundException(&quot;No handler defined for &quot; + path);
       }
&lt;p&gt;       final DAMHandler handler = handlers.get(handlerName);&lt;br/&gt;
       if(handler == null)&lt;/p&gt;
{
           throw new DAMException(&quot;No handler found with name [&quot; +
handlerName + &quot;] for [&quot; + path + &quot;]&quot;);
       }
&lt;p&gt;       return handler.getAsset(node, nodeDataPrefix);&lt;br/&gt;
   }&lt;/p&gt;

&lt;p&gt;And in info.magnolia.module.templatingkit.paragraphs.InternalTeaserModel&lt;/p&gt;

&lt;p&gt;in the method findImage() (line 97) the following code will not find the image, because these properties will not be there:&lt;/p&gt;

&lt;p&gt;for (String name : new String[]&lt;/p&gt;
{&quot;image&quot;, &quot;teaserImg&quot;}
&lt;p&gt;) {&lt;br/&gt;
            try {&lt;br/&gt;
                if(content.hasNodeData(name)) {&lt;br/&gt;
                    image = STKUtil.getAsset(content, name);&lt;br/&gt;
                    if(image != null)&lt;/p&gt;
{
                        return image;
                    }
&lt;p&gt;                }&lt;br/&gt;
            }&lt;br/&gt;
            catch (RepositoryException e) &lt;/p&gt;
{
                throw new RuntimeException(e);
            }
&lt;p&gt;        }&lt;/p&gt;

&lt;p&gt;I&apos;m pretty sure there are some more places in the stk where this is broken.&lt;/p&gt;</comment>
                            <comment id="26331" author="ebunders" created="Wed, 3 Feb 2010 11:13:10 +0100"  >&lt;p&gt;I created a fix for this bug, by extending the info.magnolia.module.templatingkit.dam.dialog.DialogDAM class (the class for the Dam dialog control), and add a dummy control with a save handler, that will make sure the missing property is set or removed, as required. It only kicks in when you have just one dam handler configured.&lt;/p&gt;

&lt;p&gt;There are two classes:&lt;/p&gt;

&lt;p&gt;nl.vpro.magnolia.module.images.dam.DialogDamSingleHandlerBugfix is the DamHandler extension. You probably want to rename this. Set this class as your dam handler.&lt;/p&gt;

&lt;p&gt;nl.vpro.magnolia.module.images.dam.DamBugfixSaveHandler is the fieldSaveHandler. If you renme this, make sure you update the reference in line 45 of DialogDamSingleHandlerBugfix.&lt;/p&gt;

&lt;p&gt;To use it set the config propery /config/modules/standard-templating-kit/controls/dam.class = nl.vpro.magnolia.module.images.dam.DialogDamSingleHandlerBugfix&lt;/p&gt;

&lt;p&gt;If you have some questions, let me know&lt;/p&gt;</comment>
                            <comment id="26336" author="ebunders" created="Wed, 3 Feb 2010 13:33:58 +0100"  >&lt;p&gt;I found another symptom of this bug: In the Dialog The control configuration (things like label, description, requred) is not shown. I think what happens is that the actual control that is shown when you have one handler is a &apos;sub&apos; and you can not set properties on the subs.&lt;/p&gt;

&lt;p&gt;Should the control properties be propagated to this sub if there is only one handler?&lt;/p&gt;</comment>
                            <comment id="28182" author="gjoseph" created="Tue, 4 May 2010 15:54:42 +0200"  >&lt;p&gt;Ernst, we&apos;re looking into this - thanks for the fix! Any chance you could provide the fix as a patch file ? (ie modify the current classes)&lt;/p&gt;</comment>
                            <comment id="28278" author="ebunders" created="Mon, 10 May 2010 10:26:26 +0200"  >&lt;p&gt;I don&apos;t think you should use this solution directly, because  it turned out that stk was broken in more places if the first image property is missing: It turned out that stk teasers could no longer find the image of the target they were linking to. So Eventually i fixed this by changing the dam control class, to create an extra hidden form field for the first image property, so it is set at all times. I could send you the code, but i don&apos;t think you should use it, as it reflects my poor understanding of the whole dialog control code. &lt;/p&gt;

&lt;p&gt;I must say the first solution came in handy though: we were adding an image property to a data structure in the datamodel, and by naming it imageMediaUUID we could actually use StkUtil.getAssetLink() with content from the data module, so that is something to consider.&lt;/p&gt;
</comment>
                    </comments>
                    <attachments>
                            <attachment id="13010" name="singleDamHandlerFix.zip" size="3543" author="ebunders" created="Wed, 3 Feb 2010 11:14:53 +0100"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_14166" key="com.okapya.jira.checklist:checklist">
                        <customfieldname>Acceptance criteria</customfieldname>
                        <customfieldvalues>
                            
        <checklist>
        <![CDATA[
                            




                
                                    <div class="o-completion" style="display: flex; flex-shrink: 0;"><span  class="aui-lozenge aui-lozenge-complete" style="font-size: 12px; font-weight: normal; display: flex; flex-direction: row; align-items: center;" ><span style="padding-right: 4px; vertical-align: middle;"><svg width="15" height="15" viewBox="0 0 15 15" xmlns="http://www.w3.org/2000/svg" fill="white"><path clip-rule="evenodd" d="m10.41037,3.42544l-7.86501,0c-0.72395,0 -1.31084,0.58688 -1.31084,1.31084l0,7.86508c0,0.7239 0.58689,1.3108 1.31084,1.3108l7.86501,0c0.724,0 1.3109,-0.5869 1.3109,-1.3108l0,-7.86508c0,-0.72396 -0.5869,-1.31084 -1.3109,-1.31084zm-7.86501,-0.65542c-1.08593,0 -1.96626,0.88032 -1.96626,1.96626l0,7.86508c0,1.0859 0.88033,1.9662 1.96626,1.9662l7.86501,0c1.086,0 1.9663,-0.8803 1.9663,-1.9662l0,-7.86508c0,-1.08594 -0.8803,-1.96626 -1.9663,-1.96626l-7.86501,0z" fill-rule="evenodd"/><path d="m5.09049,10.18526l-1.82767,-1.82766l-0.78479,0.78479l2.61246,2.61246l5.38758,-5.38754l-0.78483,-0.78479l-4.60275,4.60274z"/></svg></span><span>Empty</span></span></div>
                        ]]>
    </checklist>


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10111" key="com.atlassian.jira.toolkit:reporterdomain">
                        <customfieldname>Company</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>netcetera.com.mk</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10031" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Wed, 27 Jan 2010 16:06:21 +0100</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_12730" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_14151" key="com.atlassian.jira.toolkit:message">
                        <customfieldname>Docu info</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10061" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comm is not jira-dev</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10071" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last participant</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>mmuehlebach</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_13136" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            13 years, 41 weeks, 6 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10020" key="com.atlassian.jira.toolkit:attachments">
                        <customfieldname>Number of attachments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10150" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname>Number of comments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>5.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>bobi4597</customfieldvalue>
            <customfieldvalue>ebunders</customfieldvalue>
            <customfieldvalue>gjoseph</customfieldvalue>
            <customfieldvalue>ochytil</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10090" key="com.atlassian.jira.plugin.system.customfieldtypes:multicheckboxes">
                        <customfieldname>Patch included</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10100"><![CDATA[Yes]]></customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_10833" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i0445j:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10244" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>24115</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_14145" key="com.intenso.jira.issue-templates:issue-templates-customfield">
                        <customfieldname>Template</customfieldname>
                        <customfieldvalues>
                            


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_15131" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Time in Discovery</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>