<!-- 
RSS generated by JIRA (9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b) at Mon Feb 12 07:29:21 CET 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Magnolia - Issue tracker</title>
    <link>https://jira.magnolia-cms.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-uk</language>    <build-info>
        <version>9.4.2</version>
        <build-number>940002</build-number>
        <build-date>19-01-2023</build-date>
    </build-info>


<item>
            <title>[MGNLSTK-677] Exception in STKPager::getPageItem()</title>
                <link>https://jira.magnolia-cms.com/browse/MGNLSTK-677</link>
                <project id="10287" key="MGNLSTK">Magnolia Standard Templating Kit (closed)</project>
                    <description>&lt;p&gt;the following line&lt;br/&gt;
    subList = ((List)items).subList(offset, limit);&lt;/p&gt;

&lt;p&gt;generates an exception &lt;br/&gt;
    java.lang.IllegalArgumentException: fromIndex(4) &amp;gt; toIndex(2)&lt;/p&gt;

&lt;p&gt;if offset is larger than limit. &lt;/p&gt;


&lt;p&gt;FIX:&lt;/p&gt;
&lt;hr /&gt;

&lt;p&gt;    public Collection getPageItems() {&lt;/p&gt;

&lt;p&gt;        Collection subList = items;&lt;br/&gt;
        int offset = getOffset();&lt;br/&gt;
        if(count &amp;gt; 0) {&lt;br/&gt;
            int limit = maxResultsPerPage + offset;&lt;br/&gt;
            if(items.size() &amp;lt; limit) &lt;/p&gt;
{
                limit = count;
            }
&lt;p&gt;            if(offset &amp;lt; limit)&lt;/p&gt;
{
            	subList = ((List)items).subList(offset, limit);
            }
&lt;p&gt;else&lt;/p&gt;
{
            	subList = items;
            }
&lt;p&gt;        }&lt;br/&gt;
        return subList;&lt;br/&gt;
    }&lt;/p&gt;



&lt;p&gt;This error happens if the GET Parameter currentPage is set (for example from an old session or an old link), but there are not enought items in the current Collection.&lt;/p&gt;</description>
                <environment></environment>
        <key id="18863">MGNLSTK-677</key>
            <summary>Exception in STKPager::getPageItem()</summary>
                <type id="1" iconUrl="https://jira.magnolia-cms.com/secure/viewavatar?size=xsmall&amp;avatarId=10883&amp;avatarType=issuetype">Bug</type>
                                            <priority id="5" iconUrl="https://jira.magnolia-cms.com/images/icons/priorities/trivial.svg">Trivial</priority>
                        <status id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="ochytil">Ondrej Chytil</assignee>
                                    <reporter username="sbaur">Stefan Baur</reporter>
                        <labels>
                    </labels>
                <created>Thu, 19 Aug 2010 17:31:29 +0200</created>
                <updated>Fri, 11 Feb 2011 14:19:06 +0100</updated>
                            <resolved>Wed, 8 Dec 2010 10:53:41 +0100</resolved>
                                    <version>1.3.4</version>
                                    <fixVersion>1.3.6</fixVersion>
                    <fixVersion>1.4.2</fixVersion>
                                    <component>paragraphs</component>
                        <due></due>
                            <votes>0</votes>
                                    <watches>1</watches>
                                    <workratio workratioPercent="0"/>
                                    <progress percentage="0">
                                    <originalProgress>
                                                    <row percentage="100" backgroundColor="#89afd7"/>
                                            </originalProgress>
                                                    <currentProgress>
                                                    <row percentage="0" backgroundColor="#51a825"/>
                                                    <row percentage="100" backgroundColor="#ec8e00"/>
                                            </currentProgress>
                            </progress>
                                    <aggregateprogress percentage="0">
                                    <originalProgress>
                                                    <row percentage="100" backgroundColor="#89afd7"/>
                                            </originalProgress>
                                                    <currentProgress>
                                                    <row percentage="0" backgroundColor="#51a825"/>
                                                    <row percentage="100" backgroundColor="#ec8e00"/>
                                            </currentProgress>
                            </aggregateprogress>
                                    <timeoriginalestimate seconds="900">0.25h</timeoriginalestimate>
                            <timeestimate seconds="900">0.25h</timeestimate>
                                        <comments>
                            <comment id="30014" author="bertleunis" created="Mon, 27 Sep 2010 17:29:26 +0200"  >&lt;p&gt;I am not convinced that the suggested solution is the best one. The problem with the larger offset occurs when in an overview a paged page is requested that does not exist. So if you have 5 paged pages, and you request page 6 the calculation here goes wrong. (Example: &lt;a href=&quot;http://tegenlicht.vpro.nl/nieuws/?currentPage=1000&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://tegenlicht.vpro.nl/nieuws/?currentPage=1000&lt;/a&gt;).&lt;/p&gt;

&lt;p&gt;The fix suggests that now the complete list is returned. That is fine if you have only 30 articles, but not if you have a much larger number.&lt;/p&gt;

&lt;p&gt;There&apos;s several other options: return 404, return the last paged page, return &apos;no results for this page&apos;.&lt;/p&gt;</comment>
                            <comment id="30020" author="sbaur" created="Mon, 27 Sep 2010 19:52:04 +0200"  >&lt;p&gt;yes, you are right.&lt;br/&gt;
you should return the last available sublist instead.&lt;br/&gt;
or the first?&lt;/p&gt;</comment>
                            <comment id="30041" author="bertleunis" created="Tue, 28 Sep 2010 16:29:57 +0200"  >&lt;p&gt;IMHO the last page would be the right choice. I&apos;ll see if I can write a small patch for that.&lt;/p&gt;</comment>
                            <comment id="30095" author="bertleunis" created="Thu, 30 Sep 2010 15:12:46 +0200"  >&lt;p&gt;Voil&#224;, a small patch. When the offset of the requested page is beyond the actual number of items, the offset is set to that of the last page of items. Also added some code to prevent unfortunate DivideByZero errors.&lt;/p&gt;</comment>
                            <comment id="30099" author="sbaur" created="Fri, 1 Oct 2010 01:54:31 +0200"  >&lt;p&gt;nice. will this update be included in further releases?&lt;/p&gt;</comment>
                            <comment id="30379" author="pbaerfuss" created="Thu, 14 Oct 2010 11:52:42 +0200"  >&lt;p&gt;Yes. Added it to the maintenance mindmap.&lt;/p&gt;</comment>
                            <comment id="31817" author="ochytil" created="Wed, 8 Dec 2010 10:53:41 +0100"  >&lt;p&gt;Thanks for the patch Bert.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10040">
                    <name>causality</name>
                                                                <inwardlinks description="is causing">
                                        <issuelink>
            <issuekey id="20035">MGNLSTK-744</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                            <attachment id="13772" name="STKPager.java.patch" size="1412" author="bertleunis" created="Thu, 30 Sep 2010 15:12:46 +0200"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_14166" key="com.okapya.jira.checklist:checklist">
                        <customfieldname>Acceptance criteria</customfieldname>
                        <customfieldvalues>
                            
        <checklist>
        <![CDATA[
                            




                
                                    <div class="o-completion" style="display: flex; flex-shrink: 0;"><span  class="aui-lozenge aui-lozenge-complete" style="font-size: 12px; font-weight: normal; display: flex; flex-direction: row; align-items: center;" ><span style="padding-right: 4px; vertical-align: middle;"><svg width="15" height="15" viewBox="0 0 15 15" xmlns="http://www.w3.org/2000/svg" fill="white"><path clip-rule="evenodd" d="m10.41037,3.42544l-7.86501,0c-0.72395,0 -1.31084,0.58688 -1.31084,1.31084l0,7.86508c0,0.7239 0.58689,1.3108 1.31084,1.3108l7.86501,0c0.724,0 1.3109,-0.5869 1.3109,-1.3108l0,-7.86508c0,-0.72396 -0.5869,-1.31084 -1.3109,-1.31084zm-7.86501,-0.65542c-1.08593,0 -1.96626,0.88032 -1.96626,1.96626l0,7.86508c0,1.0859 0.88033,1.9662 1.96626,1.9662l7.86501,0c1.086,0 1.9663,-0.8803 1.9663,-1.9662l0,-7.86508c0,-1.08594 -0.8803,-1.96626 -1.9663,-1.96626l-7.86501,0z" fill-rule="evenodd"/><path d="m5.09049,10.18526l-1.82767,-1.82766l-0.78479,0.78479l2.61246,2.61246l5.38758,-5.38754l-0.78483,-0.78479l-4.60275,4.60274z"/></svg></span><span>Empty</span></span></div>
                        ]]>
    </checklist>


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10111" key="com.atlassian.jira.toolkit:reporterdomain">
                        <customfieldname>Company</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>namics.com</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10031" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Mon, 27 Sep 2010 17:29:26 +0200</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_12730" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_14151" key="com.atlassian.jira.toolkit:message">
                        <customfieldname>Docu info</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10061" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comm is not jira-dev</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>false</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10071" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last participant</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>mmuehlebach</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_13136" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            13 years, 11 weeks, 4 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10020" key="com.atlassian.jira.toolkit:attachments">
                        <customfieldname>Number of attachments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10150" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname>Number of comments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>7.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>bertleunis</customfieldvalue>
            <customfieldvalue>ochytil</customfieldvalue>
            <customfieldvalue>pbaerfuss</customfieldvalue>
            <customfieldvalue>sbaur</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10833" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i043c7:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10244" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>23983</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_14145" key="com.intenso.jira.issue-templates:issue-templates-customfield">
                        <customfieldname>Template</customfieldname>
                        <customfieldvalues>
                            


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_15131" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Time in Discovery</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>