<!-- 
RSS generated by JIRA (9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b) at Mon Feb 12 07:30:04 CET 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Magnolia - Issue tracker</title>
    <link>https://jira.magnolia-cms.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-uk</language>    <build-info>
        <version>9.4.2</version>
        <build-number>940002</build-number>
        <build-date>19-01-2023</build-date>
    </build-info>


<item>
            <title>[MGNLSTK-752] Login form field labels are hardcoded</title>
                <link>https://jira.magnolia-cms.com/browse/MGNLSTK-752</link>
                <project id="10287" key="MGNLSTK">Magnolia Standard Templating Kit (closed)</project>
                    <description>&lt;p&gt;&lt;tt&gt;stkPURLogin.ftl&lt;/tt&gt; is now much better (at last, I don&apos;t need to remember how the login field should be named!!), but users should still be able to customize (and translate!) the labels of the username and password fields. The submit button currently uses a resource bundle for its label, and arguably that should be editable by editors too.&lt;/p&gt;

&lt;p&gt;This form also now suffers from the same inconviences noted by &lt;a href=&quot;https://jira.magnolia-cms.com/browse/MGNLFORM-73&quot; title=&quot;&amp;quot;Display marker for required fields&amp;quot; is ignored&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MGNLFORM-73&quot;&gt;&lt;del&gt;MGNLFORM-73&lt;/del&gt;&lt;/a&gt;/&lt;a href=&quot;https://jira.magnolia-cms.com/browse/MGNLFORM-80&quot; title=&quot;&amp;quot;marker for required field&amp;quot; should not displayed if no &amp;quot;text for required symbol&amp;quot;&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MGNLFORM-80&quot;&gt;&lt;del&gt;MGNLFORM-80&lt;/del&gt;&lt;/a&gt;: the marker and its description are hardcoded, and it&apos;s not possible to &quot;hide&quot; them.&lt;/p&gt;

&lt;p&gt;Likewise, it has a &lt;tt&gt;formText&lt;/tt&gt; property which is not used.&lt;/p&gt;

&lt;p&gt;It&apos;s also fairly confusing that this specific form has an &quot;edit&quot; button, whereas all other forms have a &quot;edit form settings&quot; button.&lt;/p&gt;</description>
                <environment></environment>
        <key id="20221">MGNLSTK-752</key>
            <summary>Login form field labels are hardcoded</summary>
                <type id="1" iconUrl="https://jira.magnolia-cms.com/secure/viewavatar?size=xsmall&amp;avatarId=10883&amp;avatarType=issuetype">Bug</type>
                                            <priority id="3" iconUrl="https://jira.magnolia-cms.com/images/icons/priorities/major.svg">Major</priority>
                        <status id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="cringele">Christian Ringele</assignee>
                                    <reporter username="gjoseph">Magnolia International</reporter>
                        <labels>
                    </labels>
                <created>Wed, 9 Mar 2011 19:22:02 +0100</created>
                <updated>Mon, 10 Oct 2011 11:02:30 +0200</updated>
                            <resolved>Fri, 19 Aug 2011 01:25:53 +0200</resolved>
                                    <version>1.4.2</version>
                                    <fixVersion>1.4.5</fixVersion>
                                    <component>paragraphs</component>
                        <due></due>
                            <votes>0</votes>
                                    <watches>0</watches>
                                                                                                                <comments>
                            <comment id="34206" author="gjoseph" created="Fri, 18 Mar 2011 11:06:18 +0100"  >&lt;p&gt;Here&apos;s a patch that&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;shows the complete form, when in edit mode (so editors can see what they&apos;re editing despite being logged in)&lt;/li&gt;
	&lt;li&gt;shows the form title and text (only in the &quot;login&quot; part - perhaps the &quot;logout&quot; part would need its own title and text)&lt;br/&gt;
(i.e it does &lt;b&gt;not&lt;/b&gt; fulfill the problems raised in this issues entirely)&lt;/li&gt;
&lt;/ul&gt;
</comment>
                            <comment id="36698" author="gjoseph" created="Wed, 22 Jun 2011 16:37:46 +0200"  >&lt;p&gt;Using the regular form dialog would also kind of help here. Not sure why there still is a &lt;tt&gt;stkPurForm&lt;/tt&gt; dialog AND a &lt;tt&gt;stkPurLoginForm&lt;/tt&gt; dialog. The former uses the regular form dialog and adds one tab. The latter has only 2 fields, which are not &quot;compatible&quot; with the patch provided here.&lt;/p&gt;</comment>
                            <comment id="37995" author="gjoseph" created="Tue, 2 Aug 2011 19:45:29 +0200"  >&lt;p&gt;The &quot;login.infomessage&quot; messages are a good idea, but their contents need to be reviewed: 1) the login form is not hidden in preview mode out of &lt;b&gt;security&lt;/b&gt; reasons, but simply for consistency. 2) the line bits are most likely going to disrupt any and all layout. Worst case, you should use a &lt;tt&gt;&amp;lt;hr&amp;gt;&lt;/tt&gt; tag, but I&apos;m not even convinced about that. Not sure if we have a generic style for such &quot;author information&quot; (similar to the &quot;unresolved link&quot; case)&lt;/p&gt;

&lt;p&gt;Good job on the update task, although you should use the appropriate InstallContext to get the module&apos;s config node rather than hardcode its path in there. The Javadoc should reflect what the update does (not necessarily in detail, the code is there for that) as well as the task name/description (it doesn&apos;t need to be passed as an argument, since there is one and only usage and use-case)&lt;/p&gt;

&lt;p&gt;Lastly (pffewww), it is regrettable that the diff of the .ftl file is unreadable (the patch was!) - simply because indentation was modified so much in places unrelated to this issue. With other svn/diff tools, this can be read better (ignoring the whitespace doesn&apos;t seem to be an option on our svn-view), but it&apos;d be good practice to keep unrelated code-style changes for separate revisions.&lt;/p&gt;
</comment>
                            <comment id="38483" author="cringele" created="Fri, 19 Aug 2011 01:22:51 +0200"  >&lt;p&gt;Removed the security part.&lt;br/&gt;
I think p-tags are very unlikely to be design breakers, especially when fckContent is rendered in the paragraph &apos;header&apos;. And if breaking design, you don&apos;t need to leave it turned on.&lt;/p&gt;

&lt;p&gt;Thnx, noted.&lt;/p&gt;

&lt;p&gt;Diff in Eclipse handles that quite well. But noted and will try to separate.&lt;/p&gt;</comment>
                            <comment id="38484" author="cringele" created="Fri, 19 Aug 2011 01:25:53 +0200"  >&lt;p&gt;Added render test.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10040">
                    <name>causality</name>
                                                                <inwardlinks description="is causing">
                                        <issuelink>
            <issuekey id="21678">MGNLSTK-798</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10010">
                    <name>relation</name>
                                            <outwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="19687">MGNLSTK-729</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                            <attachment id="14419" name="MGNLSTK-752.patch" size="1040" author="gjoseph" created="Fri, 18 Mar 2011 11:06:18 +0100"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_14166" key="com.okapya.jira.checklist:checklist">
                        <customfieldname>Acceptance criteria</customfieldname>
                        <customfieldvalues>
                            
        <checklist>
        <![CDATA[
                            




                
                                    <div class="o-completion" style="display: flex; flex-shrink: 0;"><span  class="aui-lozenge aui-lozenge-complete" style="font-size: 12px; font-weight: normal; display: flex; flex-direction: row; align-items: center;" ><span style="padding-right: 4px; vertical-align: middle;"><svg width="15" height="15" viewBox="0 0 15 15" xmlns="http://www.w3.org/2000/svg" fill="white"><path clip-rule="evenodd" d="m10.41037,3.42544l-7.86501,0c-0.72395,0 -1.31084,0.58688 -1.31084,1.31084l0,7.86508c0,0.7239 0.58689,1.3108 1.31084,1.3108l7.86501,0c0.724,0 1.3109,-0.5869 1.3109,-1.3108l0,-7.86508c0,-0.72396 -0.5869,-1.31084 -1.3109,-1.31084zm-7.86501,-0.65542c-1.08593,0 -1.96626,0.88032 -1.96626,1.96626l0,7.86508c0,1.0859 0.88033,1.9662 1.96626,1.9662l7.86501,0c1.086,0 1.9663,-0.8803 1.9663,-1.9662l0,-7.86508c0,-1.08594 -0.8803,-1.96626 -1.9663,-1.96626l-7.86501,0z" fill-rule="evenodd"/><path d="m5.09049,10.18526l-1.82767,-1.82766l-0.78479,0.78479l2.61246,2.61246l5.38758,-5.38754l-0.78483,-0.78479l-4.60275,4.60274z"/></svg></span><span>Empty</span></span></div>
                        ]]>
    </checklist>


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10111" key="com.atlassian.jira.toolkit:reporterdomain">
                        <customfieldname>Company</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>magnolia-cms.com</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10031" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Fri, 29 Jul 2011 02:36:18 +0200</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_12730" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_14151" key="com.atlassian.jira.toolkit:message">
                        <customfieldname>Docu info</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10061" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comm is not jira-dev</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10071" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last participant</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>mmuehlebach</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_13136" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            12 years, 27 weeks, 3 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10020" key="com.atlassian.jira.toolkit:attachments">
                        <customfieldname>Number of attachments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10150" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname>Number of comments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>5.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>cringele</customfieldvalue>
            <customfieldvalue>gjoseph</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10090" key="com.atlassian.jira.plugin.system.customfieldtypes:multicheckboxes">
                        <customfieldname>Patch included</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10100"><![CDATA[Yes]]></customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_10833" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i040vj:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10244" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>23584</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_14145" key="com.intenso.jira.issue-templates:issue-templates-customfield">
                        <customfieldname>Template</customfieldname>
                        <customfieldvalues>
                            


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_15131" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Time in Discovery</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>