<!-- 
RSS generated by JIRA (9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b) at Mon Feb 12 07:32:10 CET 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Magnolia - Issue tracker</title>
    <link>https://jira.magnolia-cms.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-uk</language>    <build-info>
        <version>9.4.2</version>
        <build-number>940002</build-number>
        <build-date>19-01-2023</build-date>
    </build-info>


<item>
            <title>[MGNLSTK-973] ThemeInstallTask will never update a mobile theme configuration, missing boostratp task</title>
                <link>https://jira.magnolia-cms.com/browse/MGNLSTK-973</link>
                <project id="10287" key="MGNLSTK">Magnolia Standard Templating Kit (closed)</project>
                    <description>&lt;p&gt;The concept of the ThemeVersionHandler is to reinstall the whole theme on any update of the module.&lt;/p&gt;

&lt;p&gt;But the ThemeInstallTask just bootstraps the base theme configuration, but not a mobile theme.&lt;br/&gt;
This didn&apos;t show up, because on module installation both configurations are bootstrapped by the BaseInstallTasks of the DefaultModuleVersionHandler (basicInstallTasks.add(new ModuleBootstrapTask())&lt;img class=&quot;emoticon&quot; src=&quot;https://jira.magnolia-cms.com/images/icons/emoticons/wink.png&quot; height=&quot;16&quot; width=&quot;16&quot; align=&quot;absmiddle&quot; alt=&quot;&quot; border=&quot;0&quot;/&gt;.&lt;/p&gt;

&lt;p&gt;But on update, only the &apos;base&apos; theme (the one defined in the themes module descriptor) is re-bootstrapped:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;&lt;span class=&quot;code-keyword&quot;&gt;new&lt;/span&gt; BootstrapSingleResource(&lt;span class=&quot;code-quote&quot;&gt;&quot;&quot;, &quot;&lt;/span&gt;&lt;span class=&quot;code-quote&quot;&gt;&quot;, &quot;&lt;/span&gt;/mgnl-bootstrap/theme-&lt;span class=&quot;code-quote&quot;&gt;&quot; + themeName + &quot;&lt;/span&gt;/config.modules.standard-templating-kit.config.themes.&lt;span class=&quot;code-quote&quot;&gt;&quot; + themeName + &quot;&lt;/span&gt;.xml&quot;, ImportUUIDBehavior.IMPORT_UUID_COLLISION_REPLACE_EXISTING).execute(ctx);
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;Solution:&lt;br/&gt;
I think most proper solution would be defining two properties within the module descriptor, one for the base theme, and one for the mobile theme.&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;  &amp;lt;properties&amp;gt;
    &amp;lt;property&amp;gt;
        &amp;lt;name&amp;gt;themeName&amp;lt;/name&amp;gt;
        &amp;lt;value&amp;gt;pop&amp;lt;/value&amp;gt;
    &amp;lt;/property&amp;gt;
    &amp;lt;property&amp;gt;
        &amp;lt;name&amp;gt;mobileThemeName&amp;lt;/name&amp;gt;
        &amp;lt;value&amp;gt;pop-mobile&amp;lt;/value&amp;gt;
    &amp;lt;/property&amp;gt;
  &amp;lt;/properties&amp;gt;
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;Using an custom task which checks if the property &apos;mobileThemeName&apos; is defined, and if so bootstraps it.&lt;br/&gt;
(For the case you&apos;re not using a mobile theme)&lt;/p&gt;</description>
                <environment></environment>
        <key id="24322">MGNLSTK-973</key>
            <summary>ThemeInstallTask will never update a mobile theme configuration, missing boostratp task</summary>
                <type id="1" iconUrl="https://jira.magnolia-cms.com/secure/viewavatar?size=xsmall&amp;avatarId=10883&amp;avatarType=issuetype">Bug</type>
                                            <priority id="2" iconUrl="https://jira.magnolia-cms.com/images/icons/priorities/critical.svg">Critical</priority>
                        <status id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="ochytil">Ondrej Chytil</assignee>
                                    <reporter username="cringele">Christian Ringele</reporter>
                        <labels>
                    </labels>
                <created>Mon, 18 Jun 2012 16:06:16 +0200</created>
                <updated>Mon, 22 Apr 2013 11:02:22 +0200</updated>
                            <resolved>Fri, 19 Apr 2013 16:45:42 +0200</resolved>
                                    <version>2.0</version>
                                    <fixVersion>2.0.10</fixVersion>
                                    <component>themepop</component>
                        <due></due>
                            <votes>0</votes>
                                    <watches>2</watches>
                                                                                                                <comments>
                            <comment id="48077" author="cringele" created="Mon, 18 Jun 2012 16:07:03 +0200"  >&lt;p&gt;Is related to it, because it also should check if the theme configuration exists on install time of the module.&lt;/p&gt;</comment>
                            <comment id="60126" author="had" created="Wed, 10 Apr 2013 13:08:27 +0200"  >&lt;p&gt;Firstly implemented solution is different then proposal in the ticket, so you should update the ticket as well.&lt;br/&gt;
Secondly there is no test.&lt;br/&gt;
And last, but not least, this implementation is overzealous and will bootstrap also incorrect files. The beginning of the file should always be &lt;tt&gt;config.modules.standard-templating-kit.config.themes.&lt;/tt&gt; otherwise you might accidentally bootstrap also js or css or other files w/ theme name in it.&lt;/p&gt;</comment>
                            <comment id="60244" author="ochytil" created="Thu, 11 Apr 2013 23:42:51 +0200"  >&lt;p&gt;File type is restricted to xml with check for name end.&lt;br/&gt;
Adding the beginning of file name - ok, but then still is possible to bootstrap some other file which meets the condition. Also whole thing is then quite hardcoded.&lt;/p&gt;</comment>
                            <comment id="60261" author="had" created="Fri, 12 Apr 2013 08:54:24 +0200"  >&lt;p&gt;Adding the prefix i suggested ensures that only files that are bootstrapped into config:/modules/standard-templating-kit/config/themes/ folder would be bootstrapped. So really just the theme related content. Whether theme is all in one bootstrap file or in many is irrelevant in this case. Since Magnolia will not recognize themes bootstrapped elsewhere it is actually correct to limit task functionality to this path only.&lt;/p&gt;</comment>
                            <comment id="60697" author="ochytil" created="Thu, 18 Apr 2013 20:19:51 +0200"  >&lt;p&gt;Proposed solution was not used.&lt;br/&gt;
Fixed by implementing inner check for bootstrapped files to determine if they belong to theme or its variations based on module and theme name.&lt;/p&gt;</comment>
                            <comment id="60714" author="had" created="Fri, 19 Apr 2013 05:34:33 +0200"  >&lt;p&gt;OK, I&apos;m being picky here, but really is there any reason why don&apos;t you set those params in constructor of the filter and forget about the whole set/get list of methods? It&apos;s not like you will modify those values ever after creation of the filter.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10010">
                    <name>relation</name>
                                            <outwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="24321">MGNLSTK-972</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_14166" key="com.okapya.jira.checklist:checklist">
                        <customfieldname>Acceptance criteria</customfieldname>
                        <customfieldvalues>
                            
        <checklist>
        <![CDATA[
                            




                
                                    <div class="o-completion" style="display: flex; flex-shrink: 0;"><span  class="aui-lozenge aui-lozenge-complete" style="font-size: 12px; font-weight: normal; display: flex; flex-direction: row; align-items: center;" ><span style="padding-right: 4px; vertical-align: middle;"><svg width="15" height="15" viewBox="0 0 15 15" xmlns="http://www.w3.org/2000/svg" fill="white"><path clip-rule="evenodd" d="m10.41037,3.42544l-7.86501,0c-0.72395,0 -1.31084,0.58688 -1.31084,1.31084l0,7.86508c0,0.7239 0.58689,1.3108 1.31084,1.3108l7.86501,0c0.724,0 1.3109,-0.5869 1.3109,-1.3108l0,-7.86508c0,-0.72396 -0.5869,-1.31084 -1.3109,-1.31084zm-7.86501,-0.65542c-1.08593,0 -1.96626,0.88032 -1.96626,1.96626l0,7.86508c0,1.0859 0.88033,1.9662 1.96626,1.9662l7.86501,0c1.086,0 1.9663,-0.8803 1.9663,-1.9662l0,-7.86508c0,-1.08594 -0.8803,-1.96626 -1.9663,-1.96626l-7.86501,0z" fill-rule="evenodd"/><path d="m5.09049,10.18526l-1.82767,-1.82766l-0.78479,0.78479l2.61246,2.61246l5.38758,-5.38754l-0.78483,-0.78479l-4.60275,4.60274z"/></svg></span><span>Empty</span></span></div>
                        ]]>
    </checklist>


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10111" key="com.atlassian.jira.toolkit:reporterdomain">
                        <customfieldname>Company</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>magnolia-cms.com</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10031" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Wed, 10 Apr 2013 13:08:27 +0200</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_12730" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_14151" key="com.atlassian.jira.toolkit:message">
                        <customfieldname>Docu info</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10061" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comm is not jira-dev</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>false</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10071" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last participant</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>mmuehlebach</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_13136" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            10 years, 44 weeks, 3 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10020" key="com.atlassian.jira.toolkit:attachments">
                        <customfieldname>Number of attachments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10150" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname>Number of comments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>6.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>cringele</customfieldvalue>
            <customfieldvalue>had</customfieldvalue>
            <customfieldvalue>ochytil</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10833" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i01fmv:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10244" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>8415</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_14145" key="com.intenso.jira.issue-templates:issue-templates-customfield">
                        <customfieldname>Template</customfieldname>
                        <customfieldvalues>
                            


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_15131" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Time in Discovery</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>