<!-- 
RSS generated by JIRA (9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b) at Mon Feb 12 08:46:45 CET 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Magnolia - Issue tracker</title>
    <link>https://jira.magnolia-cms.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-uk</language>    <build-info>
        <version>9.4.2</version>
        <build-number>940002</build-number>
        <build-date>19-01-2023</build-date>
    </build-info>


<item>
            <title>[MGNLUI-1454] MultiProperty handling.</title>
                <link>https://jira.magnolia-cms.com/browse/MGNLUI-1454</link>
                <project id="10625" key="MGNLUI">Magnolia UI</project>
                    <description>&lt;p&gt;Create Specific properties in order to store the multi selected values into 3 different way:&lt;br/&gt;
*Single field property (value separated with string)&lt;br/&gt;
*Multi-property values&lt;br/&gt;
*Multi sub nodes&lt;/p&gt;

&lt;p&gt;The builder create a MultiProperty object (extend VaadinProperty). This property then delegate to configured Handler the retrieval and storage of properties in the appropriate form (single vale, multi values or multi child node)&lt;/p&gt;</description>
                <environment></environment>
        <key id="30847">MGNLUI-1454</key>
            <summary>MultiProperty handling.</summary>
                <type id="5" iconUrl="https://jira.magnolia-cms.com/secure/viewavatar?size=xsmall&amp;avatarId=10896&amp;avatarType=issuetype">Sub-task</type>
                            <parent id="30825">MGNLUI-1449</parent>
                                    <priority id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/priorities/neutral.gif">Neutral</priority>
                        <status id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="ehechinger">Eric Hechinger</assignee>
                                    <reporter username="ehechinger">Eric Hechinger</reporter>
                        <labels>
                            <label>adapters</label>
                    </labels>
                <created>Tue, 28 May 2013 11:00:34 +0200</created>
                <updated>Tue, 25 Jun 2013 15:34:29 +0200</updated>
                            <resolved>Wed, 5 Jun 2013 16:48:54 +0200</resolved>
                                    <version>5.0</version>
                                    <fixVersion>5.0</fixVersion>
                                    <component>framework</component>
                        <due></due>
                            <votes>0</votes>
                                    <watches>2</watches>
                                                                                                                <comments>
                            <comment id="63862" author="tmattsson" created="Tue, 4 Jun 2013 11:59:09 +0200"  >&lt;p&gt;SaveModeType&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;should be in the form.field.definition package&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;MultiProperty&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;what would it take to make MultiProperty able to support more types than strings?&lt;/li&gt;
	&lt;li&gt;field delegate should be renamed to handler&lt;/li&gt;
	&lt;li&gt;unnecessary cast in setValue()&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;MultiValueHandler&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;javadoc is confusing, should say that the responsibility of the handler is to store the value in a adapter&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;MultiValuesHandler&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;extends SingleValueHandler, would it not make more sense to add an Abstract base class if all we need to share is a util method?&lt;/li&gt;
	&lt;li&gt;the name is confusing would make more sense if this was MultiValueHandler&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;SubNodesValueHandler&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;the terms root and parent seems to mean the same thing, can we use parent consistently instead?&lt;/li&gt;
	&lt;li&gt;the term rootChild should be just child&lt;/li&gt;
	&lt;li&gt;the name child sometimes seems to be the node holding the entries and sometimes the entry itself, we should use the term entry to make it clear which is what&lt;/li&gt;
	&lt;li&gt;should not call applyChanges() since this should only be done once when actually saving the data, use getJcrItem() instead&lt;/li&gt;
	&lt;li&gt;spelling error in SubNodesValueHandlerTest chield should be child&lt;/li&gt;
	&lt;li&gt;unnecessary casts in getOrCreateChildNode()&lt;/li&gt;
	&lt;li&gt;StringUtils.rightPad does not cut the string down to 20 chars, only makes it at least 20 chars long&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;MultiValuesHandlerTest&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;copyright header says 2012&lt;/li&gt;
	&lt;li&gt;should call applyChanges() only once per test&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;SingleValueHandlerTest&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;copyright header says 2012&lt;/li&gt;
	&lt;li&gt;should call applyChanges() only once per test&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;SubNodesValueHandlerTest&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;copyright header says 2012&lt;/li&gt;
	&lt;li&gt;should call applyChanges() only once per test&lt;/li&gt;
&lt;/ul&gt;
</comment>
                            <comment id="63928" author="ehechinger" created="Wed, 5 Jun 2013 11:15:14 +0200"  >&lt;p&gt;SaveModeType&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;should be in the form.field.definition package&lt;br/&gt;
(ehe: current package package info.magnolia.ui.form.field.definition)&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;MultiProperty&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;what would it take to make MultiProperty able to support more types than strings?&lt;br/&gt;
(ehe: I wanted to handle it in a more generic task &lt;a href=&quot;https://jira.magnolia-cms.com/browse/MGNLUI-1455&quot; title=&quot;Generalize List element type in MultiValuesHandler and SubNodesValueHandler&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MGNLUI-1455&quot;&gt;&lt;del&gt;MGNLUI-1455&lt;/del&gt;&lt;/a&gt;)&lt;/li&gt;
	&lt;li&gt;field delegate should be renamed to handler (ehe:ok)&lt;/li&gt;
	&lt;li&gt;unnecessary cast in setValue() (ehe:ok)&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;MultiValueHandler&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;javadoc is confusing, should say that the responsibility of the handler is to store the value in a adapter&lt;br/&gt;
(ehe:ok)&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;MultiValuesHandler&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;extends SingleValueHandler, would it not make more sense to add an Abstract base class if all we need to share is a util method?&lt;br/&gt;
(ehe: make sens, I was asking my self the same question.)&lt;/li&gt;
	&lt;li&gt;the name is confusing would make more sense if this was MultiValueHandler&lt;br/&gt;
(ehe: MultiValueHandler is already the name of the implemented interface.)&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;SubNodesValueHandler&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;the terms root and parent seems to mean the same thing, can we use parent consistently instead?&lt;/li&gt;
	&lt;li&gt;the term rootChild should be just child&lt;/li&gt;
	&lt;li&gt;the name child sometimes seems to be the node holding the entries and sometimes the entry itself, we should use the term entry to make it clear which is what&lt;br/&gt;
(ehe: ok, tried to add consistency to the variable name.)&lt;/li&gt;
	&lt;li&gt;should not call applyChanges() since this should only be done once when actually saving the data, use getJcrItem() instead&lt;br/&gt;
(ehe: agree event un-necessary method, removed)&lt;/li&gt;
	&lt;li&gt;spelling error in SubNodesValueHandlerTest chield should be child&lt;/li&gt;
	&lt;li&gt;unnecessary casts in getOrCreateChildNode()&lt;br/&gt;
(ehe: agree)&lt;/li&gt;
	&lt;li&gt;StringUtils.rightPad does not cut the string down to 20 chars, only makes it at least 20 chars long&lt;br/&gt;
(ehe: agree, my mistake, Name may be less than 20 char but not longer)&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;MultiValuesHandlerTest&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;copyright header says 2012&lt;/li&gt;
	&lt;li&gt;should call applyChanges() only once per test&lt;br/&gt;
(ehe: agree)&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;SingleValueHandlerTest&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;copyright header says 2012&lt;/li&gt;
	&lt;li&gt;should call applyChanges() only once per test&lt;br/&gt;
(ehe: agree)&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;SubNodesValueHandlerTest&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;copyright header says 2012&lt;/li&gt;
	&lt;li&gt;should call applyChanges() only once per test&lt;br/&gt;
(ehe: agree)&lt;/li&gt;
&lt;/ul&gt;
</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10111" key="com.atlassian.jira.toolkit:reporterdomain">
                        <customfieldname>Company</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>magnolia-cms.com</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10031" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Tue, 4 Jun 2013 11:59:09 +0200</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_12730" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_14151" key="com.atlassian.jira.toolkit:message">
                        <customfieldname>Docu info</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10061" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comm is not jira-dev</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10071" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last participant</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>ajones</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_13136" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            10 years, 37 weeks, 4 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10020" key="com.atlassian.jira.toolkit:attachments">
                        <customfieldname>Number of attachments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10150" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname>Number of comments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>ehechinger</customfieldvalue>
            <customfieldvalue>tmattsson</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10833" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i0064v:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10244" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1022</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10245" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="9">Beta 3</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14145" key="com.intenso.jira.issue-templates:issue-templates-customfield">
                        <customfieldname>Template</customfieldname>
                        <customfieldvalues>
                            


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_15131" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Time in Discovery</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            </customfields>
    </item>
</channel>
</rss>