<!-- 
RSS generated by JIRA (9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b) at Mon Feb 12 08:34:26 CET 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Magnolia - Issue tracker</title>
    <link>https://jira.magnolia-cms.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-uk</language>    <build-info>
        <version>9.4.2</version>
        <build-number>940002</build-number>
        <build-date>19-01-2023</build-date>
    </build-info>


<item>
            <title>[MGNLUI-186] Thumbnail view should show icons for nodes that are not images.</title>
                <link>https://jira.magnolia-cms.com/browse/MGNLUI-186</link>
                <project id="10625" key="MGNLUI">Magnolia UI</project>
                    <description>&lt;p&gt;pdf, audio, video should all serve icon images from admincentral theme.&lt;/p&gt;</description>
                <environment></environment>
        <key id="26303">MGNLUI-186</key>
            <summary>Thumbnail view should show icons for nodes that are not images.</summary>
                <type id="2" iconUrl="https://jira.magnolia-cms.com/secure/viewavatar?size=xsmall&amp;avatarId=10891&amp;avatarType=issuetype">New Feature</type>
                                            <priority id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/priorities/neutral.gif">Neutral</priority>
                        <status id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="czimmermann">Christopher Zimmermann</assignee>
                                    <reporter username="czimmermann">Christopher Zimmermann</reporter>
                        <labels>
                    </labels>
                <created>Fri, 9 Nov 2012 16:41:31 +0100</created>
                <updated>Mon, 11 Feb 2013 11:35:40 +0100</updated>
                            <resolved>Tue, 27 Nov 2012 17:12:21 +0100</resolved>
                                                    <fixVersion>5.0</fixVersion>
                                        <due></due>
                            <votes>0</votes>
                                    <watches>0</watches>
                                                                                                                <comments>
                            <comment id="53214" author="czimmermann" created="Mon, 12 Nov 2012 09:31:11 +0100"  >&lt;p&gt;Its working - but: &lt;br/&gt;
Currenlty using SVG files referenced from images tags. This wont work on all browsers. Need to make it work - possibly by creating png files for non-modern browsers.&lt;/p&gt;

&lt;p&gt;Need to clean up how path is created to icons in ThumbnailContainerProperty.getValue().&lt;/p&gt;</comment>
                            <comment id="53304" author="had" created="Thu, 15 Nov 2012 13:49:53 +0100"  >&lt;p&gt;This ticket is still in-progress so up-front appology if i bring up something you wanted to do anyway but:&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;code changes committed under this ticket number were done in magnolia-ui module &lt;a href=&quot;https://git.magnolia-cms.com/gitweb/?p=magnolia_ui.git;a=commitdiff;h=8abf4a07132691fc68df8219f2d84290130c59bc&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://git.magnolia-cms.com/gitweb/?p=magnolia_ui.git;a=commitdiff;h=8abf4a07132691fc68df8219f2d84290130c59bc&lt;/a&gt;  Each commit has to have ticket under it&apos;s own project number. How can one ever know what is changed in Magnolia UI or why it needs to be released if changes made to it are spread in jira projects belonging to other modules?&lt;/li&gt;
	&lt;li&gt;This 
&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;} catch (Exception e) {
   log.warn(&quot;Could not get type from asset Node: {}&quot;, e.getMessage());
   return null;
}
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;is simply wrong. NEVER catch generic exception unless there is special use case for it. The only exceptions that the code above that is allowed to throw is &lt;tt&gt;RepositoryException&lt;/tt&gt; when repo becomes unavailable in which case it is unrecoverable error and has to be logged as error. &lt;tt&gt;PathNotFoundException&lt;/tt&gt; and/or &lt;tt&gt;ItemNotFoundException&lt;/tt&gt; can be prevented by calling &lt;tt&gt;node.hasProperty(&quot;type&quot;)&lt;/tt&gt; before attempting to retrieve it.&lt;/p&gt;&lt;/li&gt;
	&lt;li&gt;code for dealing with different media types is too rigid. I can already see bunch of image/video/audio formats that it doesn&apos;t deal with. Those formats should be added in configurable manner so it is possible to define mapping and add extra types at runtime. Magnolia has already code for dealing with mime types. Why don&apos;t we simply assign icons to different mime types as extra property and do not retrieve them via &lt;tt&gt;MIMEMapping&lt;/tt&gt;?&lt;/li&gt;
&lt;/ul&gt;
</comment>
                            <comment id="53625" author="czimmermann" created="Fri, 23 Nov 2012 13:48:55 +0100"  >&lt;p&gt;I see the point about the MIMEMapping. But if you look at the new DefaultImageProvider.resolveIconClassName() method you can see that it is choosing icons based on the mime type, not on the extension. Which is valuable.&lt;br/&gt;
Possibly there should be a new configuration node in MIMEMapping module that maps from MIMEType fragments to icons - as is hardcoded currently in the method. Thoughts? &lt;/p&gt;</comment>
                            <comment id="53626" author="czimmermann" created="Fri, 23 Nov 2012 13:57:47 +0100"  >&lt;p&gt;DefaultImageProvider now returns a Resource which is either an ExternalResource if its able to generate an image file, or its an IconFontResource which contains the CssClassName for the icon which is appropriate for the type of document, based on the documents MimeType. &lt;br/&gt;
ResourceSerializer adds an &quot;iconfont://&quot; uri scheme to the front of any IconFontResource items.&lt;br/&gt;
VThumbnail checks the type of resource which has been serialized by checking for the &quot;iconfont://&quot; at the front of the string, if so it builds a VIcon, otherwise it builds an image for the thumbnail.&lt;/p&gt;

&lt;p&gt;In order to get DefaultImageProvider to create an IconFontResource it needed to be refactored and moved out of the magnolia.ui.model package where it did not belong. In model, it was renamed into ImageProviderDefinition and ConfiguredImageProviderDefinition to match the pattern of the other model classes. Where necessary other files were changed to use the ComponentProvider in order to instantiate the ImageProvider based on configuration.&lt;/p&gt;

&lt;p&gt;ActionBar was also updated to create an Icon when the resource is an IconFontResource.&lt;/p&gt;</comment>
                            <comment id="54098" author="ejervidalo" created="Fri, 30 Nov 2012 11:39:22 +0100"  >&lt;p&gt;Created a follow up ticket in s10.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10040">
                    <name>causality</name>
                                                                <inwardlinks description="is causing">
                                        <issuelink>
            <issuekey id="26680">MGNLUI-289</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10010">
                    <name>relation</name>
                                            <outwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="26501">MGNLUI-213</issuekey>
        </issuelink>
                            </outwardlinks>
                                                                <inwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="26482">MGNLDAM-28</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_14166" key="com.okapya.jira.checklist:checklist">
                        <customfieldname>Acceptance criteria</customfieldname>
                        <customfieldvalues>
                            
        <checklist>
        <![CDATA[
                            




                
                                    <div class="o-completion" style="display: flex; flex-shrink: 0;"><span  class="aui-lozenge aui-lozenge-complete" style="font-size: 12px; font-weight: normal; display: flex; flex-direction: row; align-items: center;" ><span style="padding-right: 4px; vertical-align: middle;"><svg width="15" height="15" viewBox="0 0 15 15" xmlns="http://www.w3.org/2000/svg" fill="white"><path clip-rule="evenodd" d="m10.41037,3.42544l-7.86501,0c-0.72395,0 -1.31084,0.58688 -1.31084,1.31084l0,7.86508c0,0.7239 0.58689,1.3108 1.31084,1.3108l7.86501,0c0.724,0 1.3109,-0.5869 1.3109,-1.3108l0,-7.86508c0,-0.72396 -0.5869,-1.31084 -1.3109,-1.31084zm-7.86501,-0.65542c-1.08593,0 -1.96626,0.88032 -1.96626,1.96626l0,7.86508c0,1.0859 0.88033,1.9662 1.96626,1.9662l7.86501,0c1.086,0 1.9663,-0.8803 1.9663,-1.9662l0,-7.86508c0,-1.08594 -0.8803,-1.96626 -1.9663,-1.96626l-7.86501,0z" fill-rule="evenodd"/><path d="m5.09049,10.18526l-1.82767,-1.82766l-0.78479,0.78479l2.61246,2.61246l5.38758,-5.38754l-0.78483,-0.78479l-4.60275,4.60274z"/></svg></span><span>Empty</span></span></div>
                        ]]>
    </checklist>


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10111" key="com.atlassian.jira.toolkit:reporterdomain">
                        <customfieldname>Company</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>magnolia-cms.com</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10031" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Thu, 15 Nov 2012 13:49:53 +0100</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_12730" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_14151" key="com.atlassian.jira.toolkit:message">
                        <customfieldname>Docu info</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10061" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comm is not jira-dev</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10071" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last participant</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>mmuehlebach</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_13136" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            11 years, 12 weeks, 2 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10020" key="com.atlassian.jira.toolkit:attachments">
                        <customfieldname>Number of attachments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10150" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname>Number of comments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>5.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>czimmermann</customfieldvalue>
            <customfieldvalue>ejervidalo</customfieldvalue>
            <customfieldvalue>had</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                <customfield id="customfield_10833" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i00g0n:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10244" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2631</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14145" key="com.intenso.jira.issue-templates:issue-templates-customfield">
                        <customfieldname>Template</customfieldname>
                        <customfieldvalues>
                            


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_15131" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Time in Discovery</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>