<!-- 
RSS generated by JIRA (9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b) at Mon Feb 12 10:56:50 CET 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Magnolia - Issue tracker</title>
    <link>https://jira.magnolia-cms.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-uk</language>    <build-info>
        <version>9.4.2</version>
        <build-number>940002</build-number>
        <build-date>19-01-2023</build-date>
    </build-info>


<item>
            <title>[MSITEMESH-1] Integrate SiteMesh 3</title>
                <link>https://jira.magnolia-cms.com/browse/MSITEMESH-1</link>
                <project id="12082" key="MSITEMESH">SiteMesh</project>
                    <description></description>
                <environment></environment>
        <key id="41682">MSITEMESH-1</key>
            <summary>Integrate SiteMesh 3</summary>
                <type id="5" iconUrl="https://jira.magnolia-cms.com/secure/viewavatar?size=xsmall&amp;avatarId=10896&amp;avatarType=issuetype">Sub-task</type>
                            <parent id="41775">MSITEMESH-8</parent>
                                    <priority id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/priorities/neutral.gif">Neutral</priority>
                        <status id="6" iconUrl="https://jira.magnolia-cms.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="rkovarik">Roman Kova&#345;&#237;k</assignee>
                                    <reporter username="rkovarik">Roman Kova&#345;&#237;k</reporter>
                        <labels>
                    </labels>
                <created>Tue, 18 Nov 2014 08:06:35 +0100</created>
                <updated>Mon, 15 Dec 2014 15:30:12 +0100</updated>
                            <resolved>Mon, 15 Dec 2014 12:29:44 +0100</resolved>
                                                    <fixVersion>1.0</fixVersion>
                                        <due></due>
                            <votes>0</votes>
                                    <watches>3</watches>
                                                                                                                <comments>
                            <comment id="95981" author="had" created="Sat, 6 Dec 2014 13:14:51 +0100"  >&lt;ol&gt;
	&lt;li&gt;&lt;tt&gt;RuleConfig&lt;/tt&gt; says &quot;// drop this&quot; ... so why don&apos;t you?&lt;/li&gt;
	&lt;li&gt;&lt;tt&gt;pom.xml&lt;/tt&gt; should extend enterprise parent. Then you can also get rid of the whole &lt;tt&gt;&amp;lt;build/&amp;gt;&lt;/tt&gt; section in the pom.&lt;/li&gt;
	&lt;li&gt;Not sure if &lt;tt&gt;InjectAdmincentralButtonTag&lt;/tt&gt; should be integral part of the module. In here it serves only as a sample no? Might be better to keep it separate or in the very least change the package to make it clear what this is for.&lt;/li&gt;
	&lt;li&gt;&lt;tt&gt;AbstractRule&lt;/tt&gt; would benefit from some java doc. What is it for? What is &lt;tt&gt;includeInContent&lt;/tt&gt; flag enabling? When do I likely want to use it? ...&lt;/li&gt;
	&lt;li&gt;&lt;tt&gt;MagnoliaContentProcessor&lt;/tt&gt; - javadoc again. The &quot; * Magnolia specific implementation of 
{@link TagBasedContentProcessor}
&lt;p&gt; which offers possibility of configuration via Magnolia admincentral config tree.&quot; doesn&apos;t really say anything unless I already know what TBCP does at which point I most likely don&apos;t need to read the javadoc for MCP.&lt;/p&gt;&lt;/li&gt;
	&lt;li&gt;&lt;tt&gt;TagRuleBundle&lt;/tt&gt; - ditto. Javadoc can use some love.&lt;/li&gt;
	&lt;li&gt;In &lt;tt&gt;SiteMeshModuleVersionHandler&lt;/tt&gt; remove commented out code ... or uncomment.&lt;/li&gt;
	&lt;li&gt;&lt;tt&gt;MagnoliaHttpServletRequestFilterable&lt;/tt&gt;
	&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
		&lt;li&gt;not clear what this is for from the javadoc and&lt;/li&gt;
		&lt;li&gt;contains some commented out code&lt;/li&gt;
	&lt;/ul&gt;
	&lt;/li&gt;
	&lt;li&gt;&lt;tt&gt;MagnoliaSiteMeshFilter&lt;/tt&gt; - commented out code&lt;/li&gt;
	&lt;li&gt;&lt;tt&gt;MagnoliaWebAppContext&lt;/tt&gt; - commented out code &amp;amp; javadoc should explain how/when is this context used&lt;br/&gt;
 ... didn&apos;t review templates and tests in first round.&lt;/li&gt;
	&lt;li&gt;In general, is this module a SiteMesh integration that has side effect of allowing us doing snippet caching or is main purpose of the module snippet caching and the fact that we use SiteMesh to achieve that is just implementation detail that might change in the future? Answer to this question might have impact on the name of the module.&lt;/li&gt;
	&lt;li&gt;Why do we need &lt;tt&gt;MagnoliaTagRuleBundle&lt;/tt&gt; and &lt;tt&gt;TagRuleBundleWrapper&lt;/tt&gt;? Can&apos;t they be merged in one?&lt;/li&gt;
&lt;/ol&gt;
</comment>
                            <comment id="96034" author="rkovarik" created="Mon, 8 Dec 2014 12:27:04 +0100"  >&lt;ol&gt;
	&lt;li&gt;&lt;/li&gt;
	&lt;li&gt;&lt;/li&gt;
	&lt;li&gt;Solved by &lt;a href=&quot;https://jira.magnolia-cms.com/browse/MSITEMESH-10&quot; title=&quot;Use enterprise parent pom, clean up&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MSITEMESH-10&quot;&gt;&lt;del&gt;MSITEMESH-10&lt;/del&gt;&lt;/a&gt;.&lt;/li&gt;
	&lt;li&gt;&lt;/li&gt;
	&lt;li&gt;&lt;/li&gt;
	&lt;li&gt;&lt;/li&gt;
	&lt;li&gt;&lt;/li&gt;
	&lt;li&gt;&lt;/li&gt;
	&lt;li&gt;&lt;/li&gt;
	&lt;li&gt;Solved by &lt;a href=&quot;https://jira.magnolia-cms.com/browse/MSITEMESH-4&quot; title=&quot;Improve javadoc&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MSITEMESH-4&quot;&gt;&lt;del&gt;MSITEMESH-4&lt;/del&gt;&lt;/a&gt;&lt;/li&gt;
	&lt;li&gt;To be addressed by &lt;a href=&quot;https://jira.magnolia-cms.com/browse/MSITEMESH-11&quot; title=&quot;Consider move of snippet specific stuff out of SiteMesh module&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MSITEMESH-11&quot;&gt;&lt;del&gt;MSITEMESH-11&lt;/del&gt;&lt;/a&gt;.&lt;/li&gt;
	&lt;li&gt;The &lt;tt&gt;TagRuleBundlesWrapper&lt;/tt&gt; can be used for wrapping of useful &lt;tt&gt;TagRuleBundles&lt;/tt&gt; provided by SiteMesh3 out of the box (without ability to add/remove hardcoded rules from the bundle).&lt;br/&gt;
&lt;tt&gt;MagnoliaTagRuleBundle&lt;/tt&gt; is able to add/remove rules at runtime.&lt;/li&gt;
&lt;/ol&gt;
</comment>
                            <comment id="96401" author="efochr" created="Mon, 15 Dec 2014 12:27:06 +0100"  >&lt;p&gt;1 /server/filters/sitemesh/decoratedFilter/contentProcessor/tagRuleBundles/magnolia/rules/injectAdminCentralButtonRule/tag@class broken path.&lt;br/&gt;
2 Button got to admincentral, should be disabled by default.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10020">
                    <name>dependency</name>
                                                                <inwardlinks description="is depended upon by">
                                        <issuelink>
            <issuekey id="41691">MSITEMESH-3</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10111" key="com.atlassian.jira.toolkit:reporterdomain">
                        <customfieldname>Company</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>magnolia-cms.com</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10031" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of First Response</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Sat, 6 Dec 2014 13:14:51 +0100</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_12730" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_14151" key="com.atlassian.jira.toolkit:message">
                        <customfieldname>Docu info</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10061" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comm is not jira-dev</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>false</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10071" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last participant</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>ajones</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_13136" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            9 years, 9 weeks, 6 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10020" key="com.atlassian.jira.toolkit:attachments">
                        <customfieldname>Number of attachments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10150" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname>Number of comments</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>3.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>efochr</customfieldvalue>
            <customfieldvalue>had</customfieldvalue>
            <customfieldvalue>rkovarik</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10833" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|i04f9b:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10244" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>25925</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_14145" key="com.intenso.jira.issue-templates:issue-templates-customfield">
                        <customfieldname>Template</customfieldname>
                        <customfieldvalues>
                            


                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_15131" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Time in Discovery</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time in Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            </customfields>
    </item>
</channel>
</rss>