Issue Details (XML | Word | Printable)

Key: MAGNOLIA-2245
Type: Task Task
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Grégory Joseph
Reporter: Grégory Joseph
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Magnolia

Review and suppress usage of deprecated code

Created: 10/Jul/08 07:57 PM   Updated: 03/Jun/09 10:09 PM
Component/s: None
Affects Version/s: None
Fix Version/s: 4.0

Time Tracking:
Issue & Sub-Tasks
Issue Only
Not Specified

File Attachments: 1. Zip Archive deprecation-report-for-core.zip (91 kB)

Issue Links:
Cloners
 
duplicate
 
relation
supersession
 

Labels: cleanup
Resolution Date: 26/Jan/09 05:00 PM
Date of First Response: 09/Dec/08 01:39 PM

Sub-Tasks  All   Open   

 Description  « Hide
We deprecated a lot of code for 3.5
Unfortunately, we're showing a bad example by still using some of it ourselves We should get rid of that.

See http://confluence.magnolia-cms.com/display/DEV/Deprecation+cleanup+for+4.0



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Hudson CI server added a comment - 09/Dec/08 01:39 PM
Integrated in magnolia_main-trunk #252
:
  • removed deprecated/unused ModuleLoader, ModuleRegistration
  • betwixt can now convert version instances
    MAGNOLIA-1843 : completely removed the RestartPage

Hudson CI server added a comment - 09/Dec/08 03:44 PM
Integrated in magnolia_main-trunk #253
: ModuleDefinition constructor now takes a Version instance as argument

Hudson CI server added a comment - 09/Dec/08 04:29 PM
Integrated in magnolia_main-trunk #255
: ModuleDefinition.getVersionDefinition() is now ModuleDefinition.getVersion()

Hudson CI server added a comment - 09/Dec/08 08:04 PM
Integrated in magnolia_main-trunk #259
MAGNOLIA-2504 / : removed DeploymentUtilsPage - moved i18n reload tool to DevelopmentUtilsPage
(+ slight improvement of the devutilspages)

Hudson CI server added a comment - 09/Dec/08 08:34 PM
Integrated in magnolia_main-trunk #260
removed unused methods from ModuleUtil - moved some tasksDeploymentUtilsPage - moved i18n reload tool to DevelopmentUtilsPage
removed writing methods from WebXmlUtil

Hudson CI server added a comment - 09/Dec/08 10:10 PM
Integrated in magnolia_main-trunk #262
moved i.m.cms.beans.config.Bootstrapper to i.m.importexport (+ a bit of cleanup)

Hudson CI server added a comment - 09/Dec/08 10:24 PM
Integrated in magnolia_main-trunk #263
extracted OrderedProperties out of PropertiesImportExport and reimplement getProperty - damn you java.util.Properties !

Hudson CI server added a comment - 09/Dec/08 10:55 PM
Integrated in magnolia_main-trunk #265
removed DateComparator and StringComparator (deprecated since about 3.0.4 - see AbstractContentComparator for replacements)

Hudson CI server added a comment - 10/Dec/08 03:09 PM
Integrated in magnolia_main-trunk #266
forgot to move ServletDefinition.betwixt

Hudson CI server added a comment - 10/Dec/08 08:59 PM
Integrated in magnolia_main-trunk #271
removed Listener, LocalStore and Server from the info.magnolia.cms.beans package

Hudson CI server added a comment - 10/Dec/08 09:14 PM
Integrated in magnolia_main-trunk #272
removed info.magnolia.cms.beans.config.Subscriber and Aggregator, BaseException, BaseRuntimeException from the info.magnolia.cms.core package

Grégory Joseph added a comment - 10/Dec/08 11:24 PM
Here's the current state of affairs (for core only).

Hudson CI server added a comment - 10/Dec/08 11:24 PM
Integrated in magnolia_main-trunk #273
removed unused/deprecated methods from DateUtil
removed unused filters

Hudson CI server added a comment - 10/Dec/08 11:29 PM
Integrated in magnolia_main-trunk #274
removed unused constant from LicenseFileExtractor

Hudson CI server added a comment - 10/Dec/08 11:39 PM
Integrated in magnolia_main-trunk #275
removed deprecated/unused FreeMarkerUtil and JSPIncludeUtil

Hudson CI server added a comment - 10/Dec/08 11:44 PM
Integrated in magnolia_main-trunk #276
removed deprecated/unused PropertyInitializer

Hudson CI server added a comment - 11/Dec/08 10:18 PM
Integrated in magnolia_main-trunk #282
ConfigLoader does not check the indexers names anymore to silence logging

Hudson CI server added a comment - 11/Dec/08 10:49 PM
Integrated in magnolia_main-trunk #283
/ MAGNOLIA-1806 : moved DataTransporter to info.magnolia.importexport

Hudson CI server added a comment - 11/Dec/08 10:51 PM

Hudson CI server added a comment - 12/Dec/08 03:49 PM
Integrated in magnolia_main-trunk #289
MAGNOLIA-405 - removed unused package completely.

Hudson CI server added a comment - 12/Dec/08 03:59 PM
Integrated in magnolia_main-trunk #290
moved info.magnolia.cms.core.ie.filters to info.magnolia.importexport.filters

Hudson CI server added a comment - 12/Dec/08 08:49 PM
Integrated in magnolia_main-trunk #293
moved ICE draft classes to sandbox

Hudson CI server added a comment - 12/Dec/08 09:04 PM
Integrated in magnolia_main-trunk #294
MAGNOLIA-2514 removed deprecated fckeditor servlet and dialog classes, updated bootstrap file and module descriptor, added update task

Hudson CI server added a comment - 12/Dec/08 09:13 PM
Integrated in magnolia_main-trunk #296
removed unused and non-functional DAVServlet

Hudson CI server added a comment - 12/Dec/08 09:38 PM
Integrated in magnolia_main-trunk #297
MAGNOLIA-1788 simplify FreemarkerUtil / removed/merged unused methods

Hudson CI server added a comment - 14/Dec/08 05:54 PM
Integrated in magnolia_main-trunk #298
MAGNOLIA-1788 simplify FreemarkerUtil (r20502 introduced a stupid bug)

Hudson CI server added a comment - 14/Dec/08 10:19 PM
Integrated in magnolia_main-trunk #299
: now that we don't extend the context sensitive servlet anymore, we should not call the super method otherwise the post fails

Hudson CI server added a comment - 15/Dec/08 11:14 AM
Integrated in magnolia_main-trunk #300
removed UUIDRequestDispatcher

Hudson CI server added a comment - 15/Dec/08 12:54 PM
Integrated in magnolia_main-trunk #301
removed deprecated Resource methods with a HttpServletRequest argument

Hudson CI server added a comment - 15/Dec/08 12:59 PM
Integrated in magnolia_main-trunk #302
removed deprecated Resource methods with a HttpServletRequest argument

Hudson CI server added a comment - 15/Dec/08 01:08 PM
Integrated in magnolia_main-trunk #303
removed Resource.getFile() - moved selector methods to SelectorUtil

Hudson CI server added a comment - 15/Dec/08 06:49 PM
Integrated in magnolia_main-trunk #308
: since we removed ContextSensitiveServlet, don't call super methods.

Hudson CI server added a comment - 15/Dec/08 06:54 PM
Integrated in magnolia_main-trunk #309
Resource.getPostedForm()

Hudson CI server added a comment - 15/Dec/08 07:14 PM
Integrated in magnolia_main-trunk #310
deprecated most of MultipartForm and RequestFormUtil - should not be necessary since fixing MAGNOLIA-2449 - request parameters should be correctly wrapped.

Hudson CI server added a comment - 15/Dec/08 07:49 PM
Integrated in magnolia_main-trunk #311
replaced usage of Resource.getPostedForm() by MgnlContext.getPostedForm()

Hudson CI server added a comment - 16/Dec/08 09:29 PM
Integrated in magnolia_main-trunk #328
/ MAGNOLIA-2517 previewMode is now in AggregationState and set by the InterceptFilter

Hudson CI server added a comment - 18/Dec/08 06:04 PM
Integrated in magnolia_main-trunk #337
: moved Resource class to the taglibs module

Hudson CI server added a comment - 22/Dec/08 12:59 PM
Integrated in magnolia_main-trunk #340
Removed BasicFileExtractor.installFiles()

Hudson CI server added a comment - 22/Dec/08 09:13 PM
Integrated in magnolia_main-trunk #346
info.magnolia.cms.core.Path : removed unused constants, deprecated methods, and moved decodeURI method to AggregationState

Hudson CI server added a comment - 22/Dec/08 09:20 PM
Integrated in magnolia_main-trunk #347
info.magnolia.cms.core.Path : removed unused constants, deprecated methods, and moved decodeURI method to AggregationState

Hudson CI server added a comment - 23/Dec/08 02:19 PM
Integrated in magnolia_main-trunk #352
removed deprecated/unused methods

Hudson CI server added a comment - 23/Dec/08 03:09 PM
Integrated in magnolia_main-trunk #353
deprecated HierarchyManager getPage(), isPage() and isNodeType() methods
Cleanup of MockHiearchyManager - removed unnecessary/confusing methods

Hudson CI server added a comment - 23/Dec/08 03:13 PM
Integrated in magnolia_main-trunk #354
Removed Content.updateMetaData(HttpServletRequest request)

Hudson CI server added a comment - 23/Dec/08 03:33 PM
Integrated in magnolia_main-trunk #355
Removed deprecated methods of Content interface and implementations

Hudson CI server added a comment - 24/Dec/08 07:14 PM
Integrated in magnolia_main-trunk #357
  • MetaData: removed unused and deprecated constants: SEQUENCE_POS, SEQUENCE_POS_COEFFICIENT, removed setAccessManager which should have been private, deprecated unused getProperties method

Hudson CI server added a comment - 24/Dec/08 07:28 PM
Integrated in magnolia_main-trunk #358
removed (deprecated) getInstanceWithoutDiscovery methods from FactoryUtil
  • MetaDataUtil and NodeDataUtil - removed constructor and instance methods - now entirely static
  • ContentUtil - removed deprecated methods which are replaced by Content2BeanUtil equivalents

Hudson CI server added a comment - 24/Dec/08 07:33 PM
Integrated in magnolia_main-trunk #359
Removed registerDefferedChangeListener methods from ObservationUtil (typo) - replaced by registerDeferredChangeListener equivalents since 3.6

Hudson CI server added a comment - 29/Dec/08 03:09 PM
Integrated in magnolia_main-trunk #360
Removed info.magnolia.cms.security.Authenticator and its usages

Hudson CI server added a comment - 29/Dec/08 03:13 PM
Integrated in magnolia_main-trunk #361
Removed info.magnolia.module.delta.IsModuleInstalledDelegateTask - replaced by IsModuleInstalledOrRegistered since 3.6

Hudson CI server added a comment - 29/Dec/08 03:19 PM
Integrated in magnolia_main-trunk #362
Removed info.magnolia.cms.beans.config.Listener - use IPSecurityManager instead

Hudson CI server added a comment - 29/Dec/08 03:59 PM
Integrated in magnolia_main-trunk #364
Removed deprecated methods from MgnlContext : setUser(), getActivePage(), getFile()
Javadoc cleanup

Hudson CI server added a comment - 29/Dec/08 04:04 PM
Integrated in magnolia_main-trunk #365
Removed deprecated methods from WebContext : getActivePage(), getFile() and init(HttpServletRequest request, HttpServletResponse response)

Hudson CI server added a comment - 29/Dec/08 04:28 PM
Integrated in magnolia_main-trunk #366
Removed unused constants/properties: BOOTSTRAP_IF_EMPTY (magnolia.bootstrap.ifEmpty) and BOOTSTRAP_FORCE (magnolia.bootstrap.force), both deprecated since 3.5

Hudson CI server added a comment - 29/Dec/08 05:04 PM
Integrated in magnolia_main-trunk #368
: info.magnolia.cms.license.LicenseFileExtractor - removed PRIVIDER_EMAIL , replaced by the correctly typed PROVIDER_EMAIL since 3.6.2
: removed NT_UNSTRUCTRUED and NT_NODEDATA

Hudson CI server added a comment - 29/Dec/08 05:28 PM
Integrated in magnolia_main-trunk #371
: Removed deprecated unused and unimplemented TemplateManager.getAvailableTemplates method.

Hudson CI server added a comment - 29/Dec/08 06:04 PM
Integrated in magnolia_main-trunk #372
: Removed unused and deprecated getMIMEType(HttpServletRequest request), getMIMEType() and getContentEncoding(HttpServletRequest request) methods from MIMEMapping

Hudson CI server added a comment - 29/Dec/08 06:09 PM
Integrated in magnolia_main-trunk #373
: Removed unused and deprecated getCurrentLocale and setUserLanguage methods from MessagesManager.

Hudson CI server added a comment - 02/Jan/09 12:14 PM
Integrated in magnolia_main-trunk #392
  • Removed deprecated (de)activate methods taking a String path parameter
  • Removed deActivate methods spelled with a capital A (deprecated since 3.5)

Hudson CI server added a comment - 02/Jan/09 01:52 PM
Integrated in magnolia-module-data #13
Removed NodeDataUtil methods which were deprecated since 3.0.2/3

Hudson CI server added a comment - 02/Jan/09 01:54 PM
Integrated in magnolia_main-trunk #396
Removed NodeDataUtil methods which were deprecated since 3.0.2/3

Hudson CI server added a comment - 02/Jan/09 02:59 PM
Integrated in magnolia_main-trunk #398
Removed SimpleFlowDefinitionManager, use DefaultFlowDefinitionManager instead

Hudson CI server added a comment - 02/Jan/09 04:04 PM

Hudson CI server added a comment - 02/Jan/09 05:50 PM
Integrated in magnolia_main-trunk #403
Removed FactoryUtil.getInstance() (deprecated since 3.0)

Hudson CI server added a comment - 05/Jan/09 11:24 AM
Integrated in magnolia_main-trunk #408
MAGNOLIA-2016 moved constant used to allow 3.0 activation to ReceiveFilter, made it private.

Hudson CI server added a comment - 05/Jan/09 01:05 PM
Integrated in magnolia_main-trunk #415
Removed ConfigLoader.isConfigured()

Hudson CI server added a comment - 05/Jan/09 01:59 PM
Integrated in magnolia_main-trunk #417
trying to cleanup ConfigUtil

Hudson CI server added a comment - 05/Jan/09 03:34 PM
Integrated in magnolia_main-trunk #418
Removed ConfigLoader.isConfigured() --> ReceiveFilter will never use SystemContext

Hudson CI server added a comment - 07/Jan/09 07:05 PM
Integrated in magnolia_main-trunk #447
MAGNOLIA-2541 TemplateMessagesUtil is now deprecated. Removed usages.

Hudson CI server added a comment - 08/Jan/09 10:05 AM
Integrated in magnolia_main-trunk #452
Filter manager have been dropped as of r9292 in May 2006

Hudson CI server added a comment - 08/Jan/09 04:55 PM
Integrated in magnolia_main-trunk #456
CustomSaveHandler was renamed to FieldSaveHandler in 3.6.2

Hudson CI server added a comment - 14/Jan/09 06:12 PM
Integrated in magnolia-module-data #25
Fixed code broken by removing deprecated methods in Syndicator.

Grégory Joseph added a comment - 26/Jan/09 05:00 PM
This should be about it for 4.0