[#MAGNOLIA-2420] Allow mail.smtp.starttls.enable property configuration

Magnolia

Allow mail.smtp.starttls.enable property configuration

Created: 09/Oct/08 01:02 PM Updated: 17/Mar/09 09:51 PM

Component/s:

mail

Affects Version/s:

None

Fix Version/s:

4.0, 3.6.4, 3.6.5

Time Tracking:

Not Specified

File Attachments:

MgnlMailFactory.patch (1 kB)
2.

module-mail_MAGNOLIA-2420.patch (4 kB)

Issue Links:

duplicate

This issue is duplicated by:

~~MAGNOLIA-2484~~ Possibility to send mails through SSL (SMTP)

Patch included:	Yes
Labels:
Resolution Date:	23/Jan/09 10:15 AM
Date of First Response:	09/Oct/08 05:04 PM

Description

« Hide

For some smtp server (gmail) we need to set mail.smtp.starttls.enable property to true when creating a mail Session

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Grégory Joseph added a comment - 09/Oct/08 05:04 PM

Thanks for the patch, will review and apply asap.

[ Permlink | « Hide ]

Alejandro Scandroli added a comment - 18/Jan/09 06:18 PM

Different patch to solve the same problem.
I have added the socketFactory port, class, & fallback configurations, I have also added the "debug" option and finally I have modified the bootstrap config file.

[ Permlink | « Hide ]

Grégory Joseph added a comment - 19/Jan/09 01:13 PM

Thanks ! Will have to be modified to be applied on trunk. We'll also have to add an update task to add the new properties in the config.

[ Permlink | « Hide ]

Hudson CI server added a comment - 19/Jan/09 05:10 PM

Integrated in

magnolia_main-trunk #552
add new configurable prperty (starttsl) to smtp ones, applied patch suggested by user

[ Permlink | « Hide ]

Alejandro Scandroli added a comment - 19/Jan/09 11:49 PM

I just realized that my patch only works on port 465 (SSL) and doesn't support the other gmail port 587 (TLS)
I've mixed up the configuration parameters and they are mutually exclusive.
The code should be something like this:

if (Boolean.valueOf((String) this.mailParameters.get(SMTP_SSL)).booleanValue()) {
            props.put("mail.smtp.socketFactory.class", "javax.net.ssl.SSLSocketFactory");
            props.put("mail.smtp.socketFactory.fallback", "false");
        }

        if (Boolean.valueOf((String) this.mailParameters.get(SMTP_TLS)).booleanValue()) {
            props.put("mail.smtp.starttls.enable", "true");
        }