Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-512

Make it easier to extend Save.java

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • 2.1 Final
    • 2.1 Final
    • None
    • None
    • all

      I don't know what your policy is regarding members of a class.

      Do you want to make them protected or expose the members through protected / public getters and setters?

      To minimize the change in code I've chosen to make the private members to protected.

      Patch for revision 1139 (created with 'diff -uBbPr' on linux):
      — originals/magnolia-2.1-SNAPSHOT/src/main/info/magnolia/cms/gui/control/Save.java 2005-07-13 17:15:01.000000000 +0200
      +++ patched/magnolia-2.1-SNAPSHOT/src/main/info/magnolia/cms/gui/control/Save.java 2005-07-30 18:57:26.000000000 +0200
      @@ -85,7 +85,7 @@
      /**

      • The from, containing all the fields and files. This form is generated by magnolia.
        */
      • private MultipartForm form;
        + protected MultipartForm form;

      /**

      • creates the node if it is not present
        @@ -96,7 +96,7 @@
        /**
      • The name of the repository to store the data. Website is default.
        */
      • private String repository = ContentRepository.WEBSITE;
        + protected String repository = ContentRepository.WEBSITE;

      /**

      • Do not use this without a reason.

        Acceptance criteria

              pbaerfuss Philipp Bärfuss
              aemi Michael Aemisegger
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Task DoD