Uploaded image for project: 'Admincentral'
  1. Admincentral
  2. ADMINCTR-478

Logout from external IdPs no longer works

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 6.3.0, 6.2.34
    • 6.2.33
    • None
    • Yes

    Description

      Since ADMINCTR-450, we invalidate the HttpSession too eagerly, thus killing other/external logout logic that happens downstream from VaadinSession destroy, such as SSOs' logout filter: we use Pac4j's SessionStore (info in the http-session) to track the web session and interaction with the IdP.

      Desired behavior:

      • let a Vaadin session timeout kill itself
      • if it's the last/only Vaadin session alive within the HTTP session, trigger http session expiry
      • but do that via redirect, not via session#invalidate (not to harm SSO's session-tracking)

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            causes

            Bug - A problem which impairs or prevents the functions of the product. MGNLSSO-308 Logout no longer works - Improve integration tests

            • Major - Major loss of function, or significant new/changed feature
            • Closed
            depends upon

            Improvement - An improvement or enhancement to an existing feature or task. MAGNOLIA-9090 Add option to trigger logout logic, post-request handling

            • Neutral -
            • Closed

            Improvement - An improvement or enhancement to an existing feature or task. MAGNOLIA-9091 Add option to trigger logout logic, post-request handling (Magnolia 6.3)

            • Neutral -
            • Closed
            is cloned by

            Bug - A problem which impairs or prevents the functions of the product. ADMINCTR-479 Logout from external IdPs no longer works (Magnolia 6.3)

            • Major - Major loss of function, or significant new/changed feature
            • Closed

            Activity

              People

                mgeljic Mikaël Geljić
                mgeljic Mikaël Geljić
                AdminX
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:
                  Work Started: