Uploaded image for project: 'Analytics'
  1. Analytics
  2. ANALYTICS-313

json data after formatting date and decimal must be cached

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Not an issue
    • Icon: Neutral Neutral
    • 1.2
    • None
    • None

      Steps to reproduce

      1.  Add log to see time execution for function createDashboardComponent. Ex: execution-time.diff. See img  
      2.  Add some widgets of matomo, google, adobe
      3. Restart the instance, open analytic app and drag drop 2 times 
      4. Comment the code #doDateOrDecimalNumberFormatting and repeat the step
      5. Compare 2 execution times. See the time executions of doDateOrDecimalNumberFormatting is bigger than 

      Logs, screenshots, gifs...

      Expected results

      .. Justify non-trivial expectations with a link to a doc or a relevant discussion.

      Actual results

      // #doDateOrDecimalNumberFormatting is commented 
      Execution time in milliseconds: 5340
      Execution time in milliseconds: 61
      Execution time in milliseconds: 76
      
      
      
      
      
      
      // #doDateOrDecimalNumberFormatting is running
      Execution time in milliseconds: 7756
      Execution time in milliseconds: 7396
      Execution time in milliseconds: 4187

      Workaround

      Development notes

       

      https://git.magnolia-cms.com/projects/ADDON/repos/analytics/browse/magnolia-analytics-amcharts/src/main/java/info/magnolia/analytics/amcharts/vaadin/AmChartsComponent.java#109

       

      The json after format date or decimal must be cached to improve performance of loading

        Acceptance criteria

              oanh.thai Oanh Thai Hoang
              oanh.thai Oanh Thai Hoang
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Bug DoR
                  Task DoD

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0d
                    0d
                    Logged:
                    Time Spent - 1d 2.55h
                    1d 2.55h