Uploaded image for project: 'Cloudinary DAM Connector'
  1. Cloudinary DAM Connector
  2. CLOUDINARY-28

Add a property in Subapp descriptor to handle the initial open/close state

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Neutral
    • 1.1.12
    • 1.1.11
    • None

    Description

      Looking at following code, using closable property to handle wether a dam subapp shall be open or not (line 52) is not ideal and can lead to unwanted behavior as soon as cloudinary widget is installed with other dam modules, because we are iterating on all dam connector subapps (line 50)

      https://git.magnolia-cms.com/projects/INCUBATOR/repos/cloudinary-parent/browse/cloudinary-media-widget-integration/src/main/java/info/magnolia/external/dam/cloudinary/widget/app/DamApp.java#50,52

      We shall create another property like defaultClosed or just closed for that behavior in cloudinary module to make sure that only cloudinary is impacted.

       

      EDIT on Apr 18th

      This extra field has to be added at subapp descriptor level. If overriding the DamApp is needed, we need to make sure that it gets loaded after all other potential dam modules that could be added to a Magnolia bundle.

      Nevertheless, overriding DamApp is not ideal, if another dam module would also require a special behavior it would result in a dead end, as both would then require to have their own DamApp class loaded last.

      So if another way than overriding DamApp exists to consider the new property, we shall go that other way.

       

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                rdrangovski Riste Drangovski
                rfalvo Raphael Falvo
                Services
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:
                  Work Started:

                  Checklists

                    Bug DoR
                    Task DoD