Uploaded image for project: 'Content Diff module'
  1. Content Diff module
  2. CONTDIFF-9

Children versions aren't correctly accessed

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Neutral Neutral
    • 1.0.3
    • 1.0.2
    • None

      Currently, the logic used to go into the children nodes, works for the actual values, but doesn't work for versioned nodes, since parent and children nodes are stored on completely different paths and aren't dependent one from another. 

      The issue comes mostly from this part of the ContentDiffHandler class:

              if (depth > 0) {
                  final NodeIterator nodes = node.getNodes();
                  while (nodes.hasNext()) {
                      Node child = nodes.nextNode();
                      if ((!excludedNodeTypes.contains(VersionUtil.getNodeTypeName(child))) && (!excludedNodeNames.contains(child.getName()))) {
                          marshallNode(child, rootNode, depth-1, excludedNodeTypes, excludedNodeNames, includeMeta, parentPath, previousVersion);
                      }
                  }
              } 

        Acceptance criteria

              yen.lactue Yen Lac Tue
              rgaona Roberto Gaona
              Services
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - Not Specified
                  Not Specified
                  Logged:
                  Time Spent - 4.25h
                  4.25h