Uploaded image for project: 'Content Tags'
  1. Content Tags
  2. CONTTAGS-105

Modify tags action doesn't have writePermissionRequired set in pages app

    XMLWordPrintable

Details

    Description

      Timebox: 1 SP to verify.

      writePermissionRequired is used to check writting permissions in a node. In the old pages app, it disabled all the actions that required write permisions. In the new pages app, not all the actions that requires write permissions in the node are including it, it leads to actions available and errors when trying to execute this actions.

      This is the status of the action bar when a read-only permissions assigned to a node in new pages-app:

      This is how it used to be in 5.7.*:

      Steps to reproduce (bundle with travel-demo)

      1. As superuser, go to the Security App and configure user eric readonly permissions for website > sportstation (role: travel-demo-editor).
      2. Login as eric
      3. Go to pages app and click on /sportstation. See that almost all the actions are available. Choose one: Edit the page > Click on Edit Page Properties > Edit the dialog and save.

      Expected result

      When opening pages app and click on /sportstation(readonly), actions that require write permissions shouldn't be available.

      Current result

      You can select an action that requires writting permissions. An error comes up:

      Workaround

      Decorate the pages-app and add writePermissionRequired: true to all the actions that need it.

      Development notes

      We might preset writePermissingRequired in ModifyTagsAction|Definition so we don't need to set it in every app config explicitly.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                thuy.to Thuy To
                miruela Mercedes Iruela
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD

                    Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Remaining Estimate - Not Specified
                      Not Specified
                      Logged:
                      Time Spent - 7.5h
                      7.5h