Uploaded image for project: 'E-commerce'
  1. E-commerce
  2. ECOMMERCE-508

Error when select product

    XMLWordPrintable

Details

    Description

      Step to reproduce:

      + Go to Pages app, add a product detail component on page.

      + Choose a product which the price is null as below image:

       

      Problem


      Development Notes:
      Stream/optional APIs are not well handling for retrieve product information. Potential NPE or 

      NoSuchElementException (call optional.get() without check, or accessing properties without null check) can be thrown.

      see CommercetoolsProduct#populatePrice -> call get() without check
      CommercetoolsProduct#populateImageURLs -> productProjection.getMasterVariant().getImages()

      We need to check and do some refactor to ensure that the APIs are using correctly.

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              lam.nguyen Lam Nguyen Bao
              lam.nguyen Lam Nguyen Bao
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Bug DoR
                  Task DoD

                  Time Tracking

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - Not Specified
                    Not Specified
                    Logged:
                    Time Spent - 7h
                    7h

                    Jenkins

                      No builds found.