Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-1978

uuidLinkType does not function properly - returns no results

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • 3.5.3
    • 3.5.2
    • taglibs
    • None

      In Out.java, there is an error where the uuidLink is pulled from the cms:out attribute "uuid" instead of from the value of the node. The handle one was set up correctly - but the others were not.

      To test this out - you can set up a simple paragraph that has this in its content:

      <strong>absolute:</strong><cms:out nodeDataName="northeast" uuidToLink="absolute"/><br/> <!-- should output an absolute link -->
      <strong>relative:</strong><cms:out nodeDataName="northeast" uuidToLink="relative"/><br/> <!-- should output a relative link -->
      <strong>handle:</strong><cms:out nodeDataName="northeast" uuidToLink="handle"/><br/> <!-- should output a handle -->
      <strong>none:</strong><cms:out nodeDataName="northeast" uuidToLink="none"/><br/> <!-- should output the uuid -->

      and make a dialog where you have "northeast" defined by controlType "uuidLink"

      The above page will render with blanks for the values in the current code, and that's because of an error in the code. The fix is to have it use the value of the node as the UUID to build the link - not the uuid attribute of the tag.

      I have attached a patch that applies this fix. It works properly on my system. In the patch, I also added more documentation to the Out.java code to help explain the existing logic that is in the code.

      With this fix, the above output works the way it is expected.

        Acceptance criteria

              pbaerfuss Philipp Bärfuss
              ryangardner Ryan Gardner
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Estimated:
                  Original Estimate - 1h
                  1h
                  Remaining:
                  Remaining Estimate - 1h
                  1h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified