Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-2101

[PATCH] Problem with using dollar sign in URLs

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 3.6, 3.5.9
    • 3.5.4
    • core
    • None

    Description

      We want to be able to create URLs like "/foo/bar.html?var=${some_var}" in the FCK editor in Magnolia. We then post-process the content once it comes out of Magnolia to substitute in the variable.

      Unfortunately putting a dollar sign in the URL causes "IllegalArgumentException: Illegal group reference" to be thrown in info.magnolia.cms.link.LinkHelper.convertUsingLinkTransformer() as it fails to escape the dollar sign before passing it as the second argument to Matcher.appendReplacement().

      The attached patch fixes this issue and adds an extra test case for it.

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              gjoseph Magnolia International
              simon_macmullen Simon MacMullen
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Bug DoR
                  Task DoD