Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-2115

The ServletDispatchingFilter doesn't support the servlet spec for mapping of servlets

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Major
    • 3.6.2, 3.6.3
    • 3.5.4
    • core
    • None
    • Yes
    • Yes

    Description

      Proposed implementation:

      1) A basic mapping must adhere to the servlet spec exactly (i.e., /test* would require the url passed from the browser to literally be '/test*') servletPath and pathInfo are split according to the spec.
      2) A mapping prepended with 'regex:' is treated as a regular expression but the servletPath and pathInfo are more complex:
      a) The servletPath will always include everything that is within the mapping url with the following exception
      b) If the regex ends with a '/' it is included, along with any other characters to the end of the request url as part of the pathInfo
      c) No groupings (parentheses) are allowed unless escaped to be treated as literals

      See attached patch for implementation of this with updated tests.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                gjoseph Magnolia International
                tomjnsn Tom Jensen
                Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoD