Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-3884

cmsu:AHref always use default extension

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Won't Do
    • Icon: Neutral Neutral
    • None
    • 4.4.5
    • taglibs
    • None
    • Yes

      cmsu:ahref works with default extension only. This might be incorrect behaviour.
      See line 240 of AHref.java (4.4.5).

      Extension output section is

      AHref.java
      if (MgnlContext.getHierarchyManager(ContentRepository.WEBSITE).isPage(path)) {
     out.print("."); //$NON-NLS-1$
     out.print(ServerConfiguration.getInstance().getDefaultExtension());
}

      If site is running multiple extensions .getDefaultExtension() might be handicap. I.e. case when xml refers to another xml.

      Suggested workaround is to add additional attribute to ahref tag which will enforce some particular extension, i.e. <cmsu:ahref .... extension="xml">link</cmsu:ahref>. See patch.

      Patched AHref.java
                      if (MgnlContext.getHierarchyManager(ContentRepository.WEBSITE).isPage(path)) {
                    out.print("."); //$NON-NLS-1$
                    out.print(extension == null ? ServerConfiguration.getInstance().getDefaultExtension() : extension);
                }

      Forum link:
      http://forum.magnolia-cms.com/forum/thread.html?threadId=16c4ec22-e94b-43e4-a1dd-fa6693544aba&page=1

        Acceptance criteria

          1. ahref-extension.patch
            4 kB
          2. ahref-extension-1.patch
            2 kB

              fgiust Fabrizio Giustina
              lauri Lauri
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Task DoD