Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-5745

Revise compatibility of JspTemplatingFunction and TemplatingFunctions

XMLWordPrintable

      MAGNOLIA-5668 introduced usage of info.magnolia.templating.jsp.cmsfn.JspTemplatingFunction instead of info.magnolia.templating.functions.TemplatingFunctions in JSP renderer.

      JspTemplatingFunction have static method, e.g.
      public static boolean JspTemplatingFunction .isEditMode()
      vs
      public boolean TemplatingFunction.isEditMode()

      which is probably the cause of this issue:

      <?xml version="1.0" encoding="UTF-8"?>
      <jsp:root version="2.0"
                xmlns:jsp="http://java.sun.com/JSP/Page"
                xmlns:c="http://java.sun.com/jsp/jstl/core"
                xmlns:fmt="http://java.sun.com/jsp/jstl/fmt"
                xmlns:fn="http://java.sun.com/jsp/jstl/functions"
                xmlns:cmsc="cms-custom-taglib"
                xmlns:cms="http://magnolia-cms.com/taglib/templating-components/cms"
                xmlns:cmsfn="http://magnolia-cms.com/taglib/templating-components/cmsfn">
      
      [..]
      
      <c:when test="${cmsfn.editMode}">

      this now fails with:

      Caused by: javax.el.PropertyNotFoundException: The class 'info.magnolia.templating.jsp.cmsfn.JspTemplatingFunction' does not have the property 'editMode'.
      	at javax.el.BeanELResolver.getBeanProperty(BeanELResolver.java:722)
      	at javax.el.BeanELResolver.getValue(BeanELResolver.java:351)
      	at javax.el.CompositeELResolver.getValue(CompositeELResolver.java:188)
      	at com.sun.el.parser.AstValue.getValue(AstValue.java:138)
      	at com.sun.el.parser.AstValue.getValue(AstValue.java:183)
      	at com.sun.el.ValueExpressionImpl.getValue(ValueExpressionImpl.java:224)
      	at org.apache.jasper.runtime.PageContextImpl.evaluateExpression(PageContextImpl.java:1009)
      	at org.apache.jsp.templates.vanlanschot.templates.master_002dtemplate_jsp._jspx_meth_c_when_4(master_002dtemplate_jsp.java:895)
      

      For detail, see http://jira.magnolia-cms.com/browse/SUPPORT-3242?focusedCommentId=82829&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-82829.
      Investigate possibility of extending JspTemplatingFunction from TemplatingFunction.

        Acceptance criteria

              ehechinger Eric Hechinger
              rkovarik Roman Kovařík
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Bug DoR
                  Task DoD