Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-5890

Node2BeanTransformer: setProperty can throw Node2BeanException, and expose method to handle setProperty exceptions

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Neutral Neutral
    • None
    • None
    • core
    • 5

      With commit #36e6c2a7, we introduced a private handleSetPropertyException method. We could make this method protected, thus overridable for custom transformers, but that would only make sense if those methods can throw Node2BeanException (for now it only throws RepositoryException, because that's what the signature of Node2BeanTransformer#setProperty lets us throw).

      Validate: what are the impacts, what happens when a transformer throws a Node2BeanException there and then. (since this is in a catch(Exception) block, it might not be any useful, it might interrupt the "flow" and no other properties are set anyway ?)

        Acceptance criteria

              Unassigned Unassigned
              gjoseph Magnolia International
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:

                  Task DoD