Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-6877

YamlDefinitionProvider#getLastModified() emits mis-leading redundant and noisy log statements

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Neutral Neutral
    • 5.4.10, 5.5.1
    • 5.4.9, 5.5
    • None
    • None
    • Basel 71
    • 1

      The following logic is executed within a loop that calculates the max last modified date of a resource and all of its dependencies:

      if (dependency.getLastModified() > lastModified) {
  log.info("Definition at [{}] will be re-resolved since its dependency at [{}] has changed", dependencyPath, resourcePath);
}

      Since this ^ comparison happens before the actual max value is calculated - the whole log statement is incorrect. Also in this particular method we shouldn't make comments about how to interpret the last modified date at all!

        Acceptance criteria

              apchelintcev Aleksandr Pchelintcev
              apchelintcev Aleksandr Pchelintcev
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Bug DoR
                  Task DoD