Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-7258

ModelExecutionFilter should stop rendering if response is committed

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Neutral Neutral
    • None
    • 5.6.1
    • rendering
    • None

      ModelExecutionFilter continues rendering after models executeEarly although the response is committed already (e.g. Response#sendRedirect).

      In ModelExecutionFilter#handleExecutionResult there is a comment to describe this behavior but the return value should be true instead of false.

       // If the model rendered something on its own or sent a redirect we will not proceed with rendering.
        if (response.isCommitted()) {
            return false;
        }

        Acceptance criteria

              Unassigned Unassigned
              mbuettner Marcus Büttner
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:

                  Bug DoR
                  Task DoD