Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-7318

DialogDefinitionValidator should handle deprecation cases correctly

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Neutral
    • None
    • 5.6.5
    • None
    • None

    Description

      Currently info.magnolia.ui.dialog.registry.validator.DialogDefinitionValidator only check if the given definition class has a deprecated field type definition and if yes it reports it. That behaviour will become incorrect in the next release, however, as with the next release we have made changes in FieldFactoryFactory that deprecated field types will be not selected if there is non-deprecated one present. That means for the validator that current logic of reporting any deprecation will cause false positives in the definitions app.

      info.magnolia.ui.dialog.registry.validator.DialogDefinitionValidator should be checking if the given definition class have deprecated field types, if yes it should also check if there is one non-deprecated one, if yes it shouldn't report anything because FieldFactoryFactory will simply use that. Same goes for the decoration.

      For more information have a look at MGNLUI-4427.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                ilgun Ilgun Ilgun
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:

                  Checklists

                    Task DoD