Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-7435

Performance: incorrect decoration of info.magnolia.rendering.renderer.AbstractRenderer#render

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Outdated
    • Neutral
    • None
    • 5.7.1, 6.0
    • None
    • None

    Description

      The info.magnolia.rendering.renderer.FreemarkerRenderer#render is being wrongly decorated by info.magnolia.config.source.DefinitionProviderWrapperWithProxyFallback.

      The "render" method in AbstractRenderer has a void return type so the condition at line 84 in DefinitionProviderWrapperWithProxyFallback ( if (result == null) { ) will always be true resulting in unnecessary invocation attempt that throws an exception because the arguments are not passed at line 86 (return method.invoke(fallbackDefinition).

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              Unassigned Unassigned
              viet.nguyen Viet Nguyen
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Task DoD