Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-8255

QueryTask warning might be more subtle

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Neutral
    • None
    • None
    • None
    • None

    Description

      Steps to reproduce

      1.  Use a QueryTask in a version handler
      2.  Update an instance

      Expected results

      If I know the content I want to update a content that shouldn't be updated in the same Magnolia version update, I should be able to use the QueryTask without a warning (at least on the installation screen).

      Actual results

      QueryTask produces a warning introduced by MAGNOLIA-5857, making developers use
      NodeVisitorTask which in turn introduces performance issues (especially because info.magnolia.module.delta.NodeVisitorTask#getFilteringPredicate doesn't filter out any nodes, making the tasks iterate on all system nodes), see linked tickets.

      Workaround

      Use the QueryTask despite the warning.

      Development notes

      The warning was quite useful at the time it was introduced as we had huge amount of updates, often depending on changes in the same session. Nowadays are the update tasks rare especially due to do config in YAML and often developing only using light modules.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                rkovarik Roman Kovařík
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:

                  Checklists

                    Task DoD