Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-8481

Review ConfigurationSource / Registry refactoring potential blindspots

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • Neutral
    • None
    • None
    • None
    • Large

    Description

      There is still a few loose ends around MAGNOLIA-8044:

      Missing tests

      Some test / test assertions have been commented out without a replacement. Amongst maybe others:

      YamlDefinitionDecoratorTest#cannotDecorateMapProblemShouldHaveSevereLevel
      YamlConfigurationSourceTest#...

      Deprecations without (indicating) replacements 

      Some entities have been deprecated without indicating how to replace their functionality. Amongst maybe others in:

      AbstractRegistry
      JcrConfigurationSourceBuilder
      ConfigurationSourceBuilder

      Breaking changes 

      There are breaking changes causing downstream failures. See e.g. MGNLRESTCL-179. One of which is the AbstractRegistry#onRegister and AbstractRegistry#register call backs not being called anymore.

      Tasks

      • Re-establish full test coverage
      • Document deprecations and indicate replacements
      • Reintroduce functionality that causes breaking changes if possible. Otherwise document how adjust client code.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                mgeljic Mikaël Geljić
                mmichel Maxime Michel
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Work Started:

                  Checklists

                    Task DoR