Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-9159

Performance: Publishing site configuration shouldn't trigger module restart

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Neutral
    • 6.3.0, 6.2.41
    • None
    • None
    • Yes
    • Yes
    • Yes

    Description

      Steps to reproduce

      1. Go to https://demoauthor.magnolia-cms.com/.magnolia/admincentral#app:site:browser;/sportstation:null:
      2. Open site app
      3. Choose sportstation. https://demoauthor.magnolia-cms.com/.magnolia/admincentral#app:site:browser;/sportstation:null:
      4. Click publish include subnodes
      5. See in log, module multisite is start/stop

       
       

      INFO  info.magnolia.module.scheduler.CommandJob 27.10.2023 05:59:10 -- Starting job [UI Action triggered execution of [default:activate] by user [superuser]. (0)]... 
      INFO  info.magnolia.module.scheduler.CommandJob 27.10.2023 05:59:16 -- Job executed successfully [UI Action triggered execution of [default:activate] by user [superuser]. (0)]
      INFO  info.magnolia.module.ModuleManagerImpl 27.10.2023 05:59:17 -- Stopping module multisite
      INFO  info.magnolia.module.ModuleManagerImpl 27.10.2023 05:59:17 -- Starting module multisite
      WARN  info.magnolia.multisite.registry.MultiSiteRegistry 27.10.2023 05:59:17 -- Maximum number of allowed sites (2) reached. Following sites are registered: [travel, sportstation].

       

       

      In my case: I have 1000 site. There fore, if I just publish one site and trigger reload + start module then register 1000 site again seem unnecessary to me.

      See my below log:

      INFO  info.magnolia.module.ModuleManagerImpl 27.10.2023 13:09:19 -- Starting module multisite
      WARN  info.magnolia.multisite.registry.MultiSiteRegistry 27.10.2023 13:09:24 -- Maximum number of allowed sites (1000) reached. Following sites are registered: [test239..]
      

      .. Logs, screenshots, gifs...

      Expected results

      Multisite does not need to reload, stop and start.. Justify non-trivial expectations with a link to a doc or a relevant

      discussion.

      Actual results

      Workaround

      Development notes

      Stop/ start multisite because of publishing events seem unnecessary to me. After reload, multisite will start and  trigger register all sites again via https://git.magnolia-cms.com/projects/ENTERPRISE/repos/multisite/browse/src/main/java/info/magnolia/multisite/MultiSiteModule.java?at=refs%2Fheads%2Frelease%2F1.3#144

       

      Maybe we can filter out any events related to publishing property in info.magnolia.config.module.ModuleJcrConfigurationSource

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                oanh.thai Oanh Thai Hoang
                oanh.thai Oanh Thai Hoang
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:
                  Work Started:

                  Checklists

                    Task DoD

                    Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Remaining Estimate - Not Specified
                      Not Specified
                      Logged:
                      Time Spent - 3d
                      3d