Uploaded image for project: 'Advanced Cache'
  1. Advanced Cache
  2. MGNLADVCACHE-66

Site aware cache could retrieve mappings from site definitions which would simplifying configuration

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Neutral
    • 1.7.3
    • 1.7
    • core
    • Centos 7
    • Kromeriz 36
    • 3

    Description

      The advanced caching module creates several caches when 'createSeparateCachesForEachSite' is set. Each cache is created with the name of the site definition.

      When caching the info.magnolia.module.advancedcache.filter.SiteAwareCacheFilter takes care of storing and serving the content in the corresponding site cache.

      However the info.magnolia.module.advancedcache.SiteAwareFlushAllListeningPolicy which
      extends from info.magnolia.module.advancedcache.AbstractSiteAwareListeningFlushPolicy does not use this mechanism. Instead it uses the cache name (which is the site definition name) as the path to the root of the tree in the workspace to watch. This observation is started in info.magnolia.module.cache.AbstractListeningFlushPolicy using the path provided by the FlushPolicy.

      This breaks flushing in our case because of two reasons:

      • The site definition is called pip-buitenhof but the node in the workspace buitenhof
      • The site does not live at the root but in /programma/buitenhof

      A second problem we don't encounter in our case is the fact that there is no discrimination between workspaces for the path. So the multisite content needs to live a the same place in all workspaces that are multisite aware.

      It would be better if the FlushPolicy used the sitedefinition and its repository mappings to register the correct path and workspace to observe.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                rkovarik Roman Kovařík
                rico.jansen Rico Jansen
                Mathijn Elhorst, Michiel Meeuwissen, Nils Breunese
                Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD