Uploaded image for project: 'Backup'
  1. Backup
  2. MGNLBACKUP-105

Invoking backup via REST might be logged as success although it actually failed

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Neutral
    • 2.0, 2.1
    • 2.0, 2.1
    • None
    • Basel 69
    • 5

    Description

      Directly from the commit message:

      • Essentially before this commit, backup request's done via REST would simply always return true. This is due to v2 endpoint to rely on exception is being thrown. If no exception occurs, it assumes that command is successful. Therefore we have aligned BackupCommand with CommandsManager by simply returning 'false' when it is successful and throwing the exception when it fails.
      • Also trying to obtain stacktrace in the BackupLauncher so that user's will have the chance to track what went wrong if something goes wrong.
      • Throwing a RuntimeException by default at ObservationAwareBackupExecutor because it's possible to fail the backup request when something had changed meanwhile in the version workspace. If an exception really occurs this predefined exception will be overridden anyways. If the backup execution succeeds we will be returning 'false' and hence predefined exception will not be used.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                ilgun Ilgun Ilgun
                ilgun Ilgun Ilgun
                Nucleus
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD