Uploaded image for project: 'Cache Modules'
  1. Cache Modules
  2. MGNLCACHE-128

EhCacheWrapper does not catch LockTimeOutException properly

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Neutral
    • 5.4.4
    • 5.4
    • ehcache
    • None
    • Kromeriz 36
    • 1

    Description

      I am seeing exceptions in our monitoring system (New Relic) with regards to LockTimeOutExceptions generating error 500 pages. These are caused by pages being rendered too slow (our problem).

      However I do not see those errors in the magnolia log, which I would expect.

      Some investigation turns up that info.magnolia.module.cache.filter.CacheFilter#doFilter catches a info.magnolia.module.cache.exception.MgnlLockTimeoutException and logs a warning in that case.

      The code that is supposed to throw that exception in info.magnolia.module.cache.ehcache.EhCacheWrapper#get is faulty.
      The get() call on ehcache is outside of the try/catch instead of in it.
      The code inside the try/catch is just returning the result object and will never throw a LockTimeoutException.

      This means the MgnlLockTimeoutException will never be thrown.
      Therefore there will be no magnolia log messages.

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              rkovarik Roman Kovařík
              rico.jansen Rico Jansen
              Mathijn Elhorst, Michiel Meeuwissen, Nils Breunese
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Bug DoR
                  Task DoD