Uploaded image for project: 'Community Edition'
  1. Community Edition
  2. MGNLCE-34

Provide better expected conditions for 'dialogIsOpen' and 'tabIsOpen'

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Neutral Neutral
    • 5.4.7
    • None
    • None
    • None
    • Basel 41
    • 8

      When executing tests on a fast machine, current expected condition dialogIsOpen might be returning true even though the dialog is still in transition. This can become a problem when trying to access element afterwards: they will be found in the DOM but due to the animation/transition still being in progress, selenium is not able to click on the item, resulting in test failure.

      With this issue we should tackle the most prominent two cases: dialogs and tabs.

      Thanks to mgeljic who has provided screenshots showing the various states of such a click, we can now provide locators and adjust/add expected conditions.

      The status' are:

      1. First tab is active
      2. Click on second tab
      3. Transition is ongoing and tab marked active
      4. Tab marked active and transition done

      As a result a tab can be considered open when it has the class active and when the app-preloader is gone from the DOM.

        Acceptance criteria

          1. 04-tab_active_transition_done.png
            242 kB
            Philip Mundt
          2. 03-transition_ongoing_and_tab_active.png
            260 kB
            Philip Mundt
          3. 02-pressed_on_second_tab.png
            244 kB
            Philip Mundt
          4. 01-first_tab_active.png
            242 kB
            Philip Mundt

              pmundt Philip Mundt
              pmundt Philip Mundt
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0d
                  0d
                  Logged:
                  Time Spent - 7h
                  7h