Uploaded image for project: 'Magnolia DAM Module'
  1. Magnolia DAM Module
  2. MGNLDAM-553

RenditionAwareAssetProvider breaks design of DAM API

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Neutral
    • 2.0.8
    • 2.0.7
    • DAM API
    • None

    Description

      MGNLDAM-523 introduced this new interface, but it's flawed. It was added without the understanding that something was missing before:

      • JcrAssetProvider should be implementing getRendererFor()

      RenditionAwareAssetProvider adds a method that looks like a shortcut for the above, except that it also prevents using the whole system correctly
:

      AssetProviderRegistry.getRendererFor(myAsset, MediaType.JPEG).render(myAsset, MediaType.JPEG, "myRenditionName")

      (i see the verbosity/redundancy, for which we could add a shortcut in APR)

      I'd like to deprecate this interface ASAP, and remove it in 2.1, since it just creates noise and confusion.

      STK has an implementation of this, which should also go.

      In addition, we'll need:

      • a default renderer that knows about our imaging module
      • a noop renderer so there is always at minimum one renderer which does nothing.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                gjoseph Magnolia International
                gjoseph Magnolia International
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD