Uploaded image for project: 'Magnolia Data Module (closed)'
  1. Magnolia Data Module (closed)
  2. MGNLDATA-70

DataDialog limits should not hardcode the return value of getJsExecutedAfterSaving

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 1.4.1
    • 1.3.2
    • None
    • Yes

    Description

      DataDialog.getJsExecutedAfterSaving() returns a hardcoded String: "opener.mgnl.data.DataTree.reloadAfterEdit('" + this.itemType + "', '" + this.path + "')". This will get the opener to load the standard tree for the node type at the given path. But if the dialog was called from somewhere else (e.g. custom tree) then the user is out of luck. Therefore there should be a way to simply reload/refresh the opener page in the state it was before.

      The patch below changes the behavior of DataDialog.getJsExecutedAfterSaving() so that it only returns the JS to load the standard tree when nothing else has been specified. This seems to work for the standard data trees and for custom trees. However I have not tested this for other situations (e.g. opening the dialog from a custom page).

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                had Jan Haderka
                will Will Scheidegger
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: