Uploaded image for project: 'Magnolia Frontend Helpers'
  1. Magnolia Frontend Helpers
  2. MGNLFE-151

peerDependencies Angular 11+

    XMLWordPrintable

Details

    • Bug
    • Resolution: Duplicate
    • Neutral
    • None
    • 1.1.2
    • Angular Renderer
    • None

    Description

      When using npm install with npm 7+ you got an error. Works with npm 6, since it treats is not as errors, just as warnings. so only Angular 10 will work.

      npm ERR! Found: @angular/common@13.0.2
      npm ERR! node_modules/@angular/common
      npm ERR!   @angular/common@"~13.0.2" from the root project
      npm ERR! 
      npm ERR! Could not resolve dependency:
      npm ERR! peer @angular/common@"^10.2.4" from @magnolia/angular-editor@1.1.2
      npm ERR! node_modules/@magnolia/angular-editor
      npm ERR!   @magnolia/angular-editor@"1.1.2" from the root project
      

      https://git.magnolia-cms.com/projects/MODULES/repos/frontend-helpers/browse/packages/angular-editor/projects/angular-editor/package.json

        "peerDependencies": {
          "@angular/common": "^10.2.4",
          "@angular/core": "^10.2.4"
        }
       

      needs to be changed to ">=10.2.4".

        "peerDependencies": {
          "@angular/common": ">=10.2.4",
          "@angular/core": ">=10.2.4"
        }
       

       

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                canh.nguyen Canh Nguyen
                mhilbe Marcus Hilbe
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD