Uploaded image for project: 'Magnolia Frontend Helpers'
  1. Magnolia Frontend Helpers
  2. MGNLFE-301

Remove templateAnnotationsUpdated

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Neutral
    • None
    • None
    • None

    Description

      On Angular, depending on the way the sample is coded, templateAnnotationsUpdated might be needed. However, it adds complexity to the code without any big benefit.

      If "content" and "template-annotations" are loaded (or templateAnnotations are loaded firstly) and then do others, templateAnnotationsUpdated is redundant. (https://git.magnolia-cms.com/projects/MODULES/repos/frontend-helpers/pull-requests/158/diff#samples/angular-sample/src/app/root.component.ts). In addition, React and Vue load both firstly also.

      Pros:

      • Reduce complexity
      • Consistent with Vue and React

      Cons:

      • Need asking customers to verify their code
      • May break customers' code on a rare occasion in edit mode if their code have not updated yet

       

      B.T.W, we might think about providing a loading method in the editors for loading content and templateAnnotations instead of SPA do.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                plequoc Phong Le Quoc
                DeveloperX
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:

                  Checklists

                    Task DoD