Details
-
Improvement
-
Resolution: Unresolved
-
Neutral
-
None
-
None
-
None
Description
On Angular, depending on the way the sample is coded, templateAnnotationsUpdated might be needed. However, it adds complexity to the code without any big benefit.
If "content" and "template-annotations" are loaded (or templateAnnotations are loaded firstly) and then do others, templateAnnotationsUpdated is redundant. (https://git.magnolia-cms.com/projects/MODULES/repos/frontend-helpers/pull-requests/158/diff#samples/angular-sample/src/app/root.component.ts). In addition, React and Vue load both firstly also.
Pros:
- Reduce complexity
- Consistent with Vue and React
Cons:
- Need asking customers to verify their code
- May break customers' code on a rare occasion in edit mode if their code have not updated yet
B.T.W, we might think about providing a loading method in the editors for loading content and templateAnnotations instead of SPA do.
Checklists
Attachments
Issue Links
- is related to
-
MGNLFE-284 Angular sometimes does not show green bars
-
- Closed
-