Uploaded image for project: 'Magnolia Frontend Helpers'
  1. Magnolia Frontend Helpers
  2. MGNLFE-403

Remove duplicated onFrameReady call

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Neutral
    • None
    • None
    • None
    • None

    Description

      This PR removes the duplicated call https://git.magnolia-cms.com/projects/MODULES/repos/frontend-helpers/pull-requests/156/overview. However, it made a side effect. Therefore, the other PR rollback this change https://git.magnolia-cms.com/projects/MODULES/repos/frontend-helpers/pull-requests/183/overview. So we should verify this again to see if we can remove the duplicated call or not and comment some if it is impossible.

       

      Robert Šiška's note:

      In external SPA, the onFrameReady is called after the PageEditorBridge 
      receives initialization message from the server. However, on 
      magnolia-hosted SPAs this is never called.
      This change means, that the function is called 
      twice on external SPAs (first when the page is mounted, and second in 
      the PageEditorBridge). This is not ideal, but doesn't seem to cause an 
      issues.
      Please try on all three frameworks (external & SPA) to see if there are any side-effects.
       

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                plequoc Phong Le Quoc
                DeveloperX
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:

                  Checklists

                    Task DoD