Uploaded image for project: 'Magnolia Google Analytics'
  1. Magnolia Google Analytics
  2. MGNLGA-19

Update install tasks for ga resources

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • Neutral
    • 1.3.1
    • 1.3
    • Saigon 26
    • 2

    Description

      In MGNLSTK-1519, we updated how STK resources are installed:

      • We replaced deprecated tasks with newer InstallTextResourceTask and InstallBinaryResourceTask
      • We don't strip resource extensions anymore
      • We updated those resources as well, thanks to the purposely introduced ResourceCleanUpTask; this includes:
        • resources matching /templating-kit/js/*.swf
        • resources matching /templating-kit/js/*.js
        • InstallSTKResourcesTask#specialResources

      Now, because google-analytics module installs its resources inside STK scriptloaders, it means the STK upgrade is taking care of them (cleanup task by JS pattern), while for fresh installs extensions are still stripped.

      Worth noting that nothing is broken; just 4 minor migration diffs show up.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                mgeljic Mikaël Geljić
                mgeljic Mikaël Geljić
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoR