Uploaded image for project: 'Migration 4.4 to 4.5 (closed)'
  1. Migration 4.4 to 4.5 (closed)
  2. MGNLMIGRATION-188

Review log strategy in the Task catch section of executeTask(...

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Neutral
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: 1.2.3
    • Component/s: None
    • Labels:
      None

      Description

      remove the log.error.... of the catch section of executeTask(... method.
      Log should be performed by the method catching the throwed exception. Else we will log twice the exception.

      FROM:
      installContext.error("Unable to execute PostMigrationTask for the following module:"+getModuleName(), e);
      log.error("Unable to execute PostMigrationTask for the following module:"+getModuleName(), e);
      reportException(e);
      throw new TaskExecutionException(e.getMessage());

      TO:
      installContext.error("Unable to execute PostMigrationTask for the following module:"+getModuleName(), e);
      reportException(e);
      throw new TaskExecutionException("Unable to handle PostMigrationTask for the following module:"+getModuleName(),e);

        Checklists

        Acceptance criteria

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                rsiska Robert Šiška
                Reporter:
                ehechinger Eric Hechinger
                Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Checklists

                    Task DoR