Uploaded image for project: 'Migration 4.4 to 4.5 (closed)'
  1. Migration 4.4 to 4.5 (closed)
  2. MGNLMIGRATION-188

Review log strategy in the Task catch section of executeTask(...

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Neutral Neutral
    • 1.2.3
    • 1.2
    • None
    • None

      remove the log.error.... of the catch section of executeTask(... method.
      Log should be performed by the method catching the throwed exception. Else we will log twice the exception.

      FROM:
      installContext.error("Unable to execute PostMigrationTask for the following module:"+getModuleName(), e);
      log.error("Unable to execute PostMigrationTask for the following module:"+getModuleName(), e);
      reportException(e);
      throw new TaskExecutionException(e.getMessage());

      TO:
      installContext.error("Unable to execute PostMigrationTask for the following module:"+getModuleName(), e);
      reportException(e);
      throw new TaskExecutionException("Unable to handle PostMigrationTask for the following module:"+getModuleName(),e);

        Acceptance criteria

              rsiska Robert Šiška
              ehechinger Eric Hechinger
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Task DoR