Uploaded image for project: 'Magnolia Public User Registration'
  1. Magnolia Public User Registration
  2. MGNLPUR-165

Configuration resolver should use SiteManager

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Neutral Neutral
    • 2.5.2
    • 2.5.1
    • multisite
    • None
    • Kromeriz 28
    • 1

      The configuration is resolved from the current URI. To be precise, the first path segment of the URI is used to find a matching config name which will be returned.

      If the URI doesn't contain such a valid name – which is tha case when a site uses a domain + mapping with a handlePrefix – the correct configuration is not resolved.

      Travel Demo uses a custom config named travel:

      Suggested solutions

      1. Deprecate DefaultConfigurationResolver and use the info.magnolia.module.site.SiteManager by default to resolve the config
        • Might break clients installation because their config resolution might rely on old one
      2. Maintain the old ConfigurationResolver and a new one (info.magnolia.module.publicuserregistration.configuration.DelegatingConfigurationResolver) that is aware of both resolver
        • Maintains backwards compat.

        Acceptance criteria

              rkovarik Roman Kovařík
              rkovarik Roman Kovařík
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Bug DoR
                  Task DoD

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0d
                    0d
                    Logged:
                    Time Spent - 4.75h
                    4.75h