Uploaded image for project: 'Magnolia Standard Templating Kit (closed)'
  1. Magnolia Standard Templating Kit (closed)
  2. MGNLSTK-1496

STK has no (Default)I18nContentSupport anymore

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Critical
    • 2.9.1
    • 2.9
    • base system
    • Sprint 4 (Kromeriz)
    • 5

    Description

      In a CE instance STK was relying on the info.magnolia.cms.i18n.DefaultI18nContentSupport defined under config:/server/i18n/content. In MGNLSITE-22 the info.magnolia.module.site.i18n.SiteI18nContentSupport was introduced, which delegates to the i18n content spport defined on site-level – but STK doesn't have one in a CE bundle.

      This should be added to /modules/standard-templating-kit/config/site/i18n in order to follow the pattern of one single source of site definition (migration is done by task).

      Side-effects

      UI tests are failing due to missing i18n content spport. See:

      • info.magnolia.integrationtests.uitest.CompositeFieldUITest.testI18nCompositeField()
      • info.magnolia.integrationtests.uitest.MultiFieldUITest.testI18nMultiField()

      Tasks

      • Add default i18n content support definition to STK's site definition
        • Should be enabled=false just like the default used to be
      • Adjust UI tests to be setting the new property under /modules/site/config/site/i18n/enabled
        • info.magnolia.integrationtests.uitest.MultiFieldUITest
        • info.magnolia.integrationtests.uitest.CompositeFieldUITest
        • See: #setUp() and #tearDown()

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                jsimak Jaroslav Simak
                pmundt Philip Mundt
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Time Tracking

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0d
                    0d
                    Logged:
                    Time Spent - 4.5h
                    4.5h