Uploaded image for project: 'Magnolia Standard Templating Kit (closed)'
  1. Magnolia Standard Templating Kit (closed)
  2. MGNLSTK-535

STK JDK 1.5 cleanups (for each loops, parameterized lists, removing unboxing)

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 1.4.2
    • 1.2
    • base system
    • None
    • Yes
    • Yes

      I noticed a few methods in STK Util could benefit by using parameterized lists.

      Upon looking deeper, I noticed a number of places that for / while loops could be replaced with "for each loops" and make the code easier to read and simpler to maintain.

      In also removed instances of unnecessary unboxing.

      All three of these changes are implemented in separate patches, and I also have one that has all the changes combined into one patch (whichever you find easiest to work with)

      (tested this and all tests apply fine after these changes are applied)

        Acceptance criteria

          1. CombinedChanges.patch
            39 kB
          2. Genericize_STKUtil.patch
            4 kB
          3. stk-foreach.patch
            29 kB
          4. UnboxingFixes.patch
            10 kB

              gjoseph Magnolia International
              ryangardner Ryan Gardner
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Created:
                Updated:
                Resolved: